Skip to content

Coordinate spring and dubbo shutdown hook#5504

Merged
mercyblitz merged 1 commit intoapache:2.7.5-releasefrom
chickenlj:coordinate-spring-dubbo-shutdown
Dec 18, 2019
Merged

Coordinate spring and dubbo shutdown hook#5504
mercyblitz merged 1 commit intoapache:2.7.5-releasefrom
chickenlj:coordinate-spring-dubbo-shutdown

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj commented Dec 18, 2019 •
edited
Loading

  1. Dubbo ShutdownHook will be registered by default, it does two things

    • Run callbacks to do customized resource collection
    • Run Bootstrap.stop collect Dubbo related resource collection.

  2. Spring ShutdownHook is optional, it will be responsible for destroying Bootstrap by triggering ApplicationListeners.

image

@mercyblitz mercyblitz merged commit 39ffc17 into apache:2.7.5-release Dec 18, 2019
@chickenlj chickenlj deleted the coordinate-spring-dubbo-shutdown branch December 18, 2019 08:17
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 18, 2019

Codecov Report

Merging #5504 into 2.7.5-release will increase coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.5-release    #5504      +/-   ##
===================================================
+ Coverage            61.11%   61.17%   +0.06%     
- Complexity             420      422       +2     
===================================================
  Files                  921      920       -1     
  Lines                37574    37555      -19     
  Branches              5464     5462       -2     
===================================================
+ Hits                 22964    22975      +11     
+ Misses               12108    12073      -35     
- Partials              2502     2507       +5
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/config/DubboShutdownHook.java 59.09% <ø> (+4.74%) 0 <0> (ø) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 90.47% <ø> (-2.39%) 0 <0> (ø)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 53.94% <80%> (+0.49%) 0 <0> (ø) ⬇️
...ubbo/registry/support/AbstractRegistryFactory.java 70.58% <0%> (-3.93%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 78.57% <0%> (-2.39%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0%> (-1%) 0% <0%> (ø)
...apache/dubbo/common/extension/ExtensionLoader.java 75.58% <0%> (-0.71%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.1% <0%> (-0.35%) 0% <0%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3ed0c...6947edd. Read the comment docs.

chickenlj added a commit that referenced this pull request Dec 19, 2019
@chickenlj
coordinate spring and dubbo shutdown hook. (#5504)
4848762
@oaoit oaoit mentioned this pull request Jan 10, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chickenlj @codecov-io @mercyblitz