Skip to content

Fix multi protocol does not work when referencing in ProviderConfig#5498

Merged
chickenlj merged 2 commits intoapache:2.7.5-releasefrom
chickenlj:fix-multi-protocol-5398
Dec 18, 2019
Merged

Fix multi protocol does not work when referencing in ProviderConfig#5498
chickenlj merged 2 commits intoapache:2.7.5-releasefrom
chickenlj:fix-multi-protocol-5398

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj commented Dec 17, 2019

Fixes #5398

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 17, 2019

Codecov Report

Merging #5498 into 2.7.5-release will decrease coverage by 0.02%.
The diff coverage is 42.85%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.5-release    #5498      +/-   ##
===================================================
- Coverage            61.13%   61.11%   -0.03%     
  Complexity             422      422              
===================================================
  Files                  919      919              
  Lines                37543    37549       +6     
  Branches              5463     5466       +3     
===================================================
- Hits                 22952    22947       -5     
- Misses               12080    12095      +15     
+ Partials              2511     2507       -4
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/config/ServiceConfig.java 61.9% <ø> (ø) 0 <0> (ø) ⬇️
...onfig/spring/schema/DubboBeanDefinitionParser.java 65.59% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/apache/dubbo/config/ReferenceConfigBase.java 58.53% <50%> (-0.15%) 0 <0> (ø)
...ava/org/apache/dubbo/config/ServiceConfigBase.java 56.56% <50%> (-0.14%) 0 <0> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0%> (-9.1%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-6.9%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0%> (-6.78%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 61.94% <0%> (-2.66%) 0% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a17015...a48b38c. Read the comment docs.

@chickenlj chickenlj merged commit d32d9a2 into apache:2.7.5-release Dec 18, 2019
chickenlj added a commit that referenced this pull request Dec 19, 2019
@chickenlj
Fix multi protocol does not work when referencing in ProviderConfig (#…
7e4b2f3 
…5498)

fix #5398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chickenlj @codecov-io