Skip to content

[Bugfix] The dubbo services can't be exported #5495#5496

Merged
chickenlj merged 5 commits intoapache:2.7.5-releasefrom
mercyblitz:2.7.5-release
Dec 18, 2019
Merged

[Bugfix] The dubbo services can't be exported #5495#5496
chickenlj merged 5 commits intoapache:2.7.5-releasefrom
mercyblitz:2.7.5-release

Conversation

@mercyblitz
Copy link
Copy Markdown
Contributor

@mercyblitz mercyblitz commented Dec 17, 2019 •
edited
Loading

@mercyblitz mercyblitz added this to the 2.7.5 milestone Dec 17, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 17, 2019

Codecov Report

Merging #5496 into 2.7.5-release will decrease coverage by <.01%.
The diff coverage is 87.17%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.5-release    #5496      +/-   ##
===================================================
- Coverage            61.13%   61.12%   -0.01%     
  Complexity             422      422              
===================================================
  Files                  919      921       +2     
  Lines                37543    37567      +24     
  Branches              5463     5461       -2     
===================================================
+ Hits                 22952    22964      +12     
- Misses               12080    12099      +19     
+ Partials              2511     2504       -7
Impacted Files Coverage Δ Complexity Δ
...annotation/ServiceAnnotationBeanPostProcessor.java 80.82% <100%> (+0.13%) 0 <0> (ø) ⬇️
...t/annotation/DubboLifecycleComponentRegistrar.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...xt/DubboLifecycleComponentApplicationListener.java 100% <100%> (+34.78%) 0 <0> (ø) ⬇️
...eTimeExecutionApplicationContextEventListener.java 55.55% <55.55%> (ø) 0 <0> (?)
...ing/context/DubboBootstrapApplicationListener.java 92.3% <92.3%> (ø) 0 <0> (?)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 70.83% <0%> (-16.67%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0%> (-9.1%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 76.72% <0%> (-8.63%) 0% <0%> (ø)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 57.14% <0%> (-7.15%) 0% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a17015...a918012. Read the comment docs.

@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Dec 18, 2019

LGTM.

@chickenlj chickenlj merged commit a5b8a87 into apache:2.7.5-release Dec 18, 2019
chickenlj pushed a commit that referenced this pull request Dec 19, 2019
@mercyblitz @chickenlj
[Dubbo-5495] Services can't be exported for projects driven by annota…
2d2341e 
…tion but with EnableDubbo/EnableDubboLifecycle not enabled (#5496)

Fixes #5495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.7.5

Development

Successfully merging this pull request may close these issues.

3 participants

@mercyblitz @codecov-io @chickenlj