Revert #3688 config-center-config#3853
Merged
ralf0131 merged 2 commits intoapache:masterfrom Apr 12, 2019
Merged
Conversation
Contributor
Author
/**
* if {@link #key()} is specified, it will be used as the key for the annotated property when generating url.
* by default, this key will also be used to retrieve the config value:
* <pre>
* {@code
* class ExampleConfig {
* // Dubbo will try to get "dubbo.example.alias_for_item=xxx" from .properties, if you want to use the original property
* // "dubbo.example.item=xxx", you need to set useKeyAsProperty=false.
* @Parameter(key = "alias_for_item")
* public getItem();
* }
* }
*
* </pre>
*/
boolean useKeyAsProperty() default true; boolean useKeyAsProperty() default true; |
Contributor
Author
class ExampleConfig {
// Dubbo will try to get "dubbo.example.alias_for_item=xxx" from .properties, if you want to use the original property
// "dubbo.example.item=xxx", you need to set useKeyAsProperty=false.
@Parameter(key = "alias_for_item")
public getItem() {
return "xxx";
}
}Only key is set or not matters: URL: dubbo://xxxxx?alias_for_item=xxxx# when useKeyAsProperty=true.
dubbo.example.alias_for_item=xxx
# useKeyAsProperty=false.
dubbo.example.item=xxx |
ralf0131
approved these changes
Apr 11, 2019
Contributor
ralf0131
left a comment
There was a problem hiding this comment.
I got what you mean, I think it is reasonable to revert it.
Contributor
|
@tswstarplanet Could you please verify it? |
chenlushun
approved these changes
Apr 12, 2019
Contributor
|
@tswstarplanet I am merging it, please feel free to reopen this, if you have any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
see issue described here #3682
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.