Skip to content

ConfigCenterConfig's member field's key wrong #3682

@tswstarplanet

Description

@tswstarplanet
  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.1-SNAPSHOT
  • Operating System version: MacOS 10.14
  • Java version: 1.8

I find some member fields of ConfigCenterConfig are annotated by @parameter, and the 'useKeyAsProperty' property of the annotation is set 'false'.
For example, the 'check' member field is annotated by @parameter, and its key is "config.check", but the 'useKeyAsProperty' is false.
So the key of this field in URL's parameters is 'check' because the 'useKeyAsProperty' is false, but in config center configuration class like ApolloDynamicConfiguration, the class use 'config.check' to get the property from parameters of URL.
So I think we should adjust the setting.
How about set the 'useKeyAsProperty' to true ?
I want to listen others' proposals.

Steps to reproduce this issue

config

<dubbo:configcenter address:xxx check="false"/>

Expected Result

the key in url's parameters should be "config.check", because in apollo dynamic configuration class, it use the key to get the check property
What do you expected from the above steps?

Actual Result

the key in parameters is check

If there is an exception, please attach the exception trace:

Just put your stack trace here!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions