enhance monitor module javadoc#3121
Merged
ralf0131 merged 1 commit intoapache:masterfrom Jan 3, 2019
lixiaojiee:dubbo-monitor-annotated
Merged
enhance monitor module javadoc#3121ralf0131 merged 1 commit intoapache:masterfrom lixiaojiee:dubbo-monitor-annotated
ralf0131 merged 1 commit intoapache:masterfrom
lixiaojiee:dubbo-monitor-annotated
Conversation
khanimteyaz
reviewed
Jan 3, 2019
...-monitor/dubbo-monitor-api/src/main/java/org/apache/dubbo/monitor/support/MonitorFilter.java
Show resolved
Hide resolved
khanimteyaz
reviewed
Jan 3, 2019
...-monitor/dubbo-monitor-api/src/main/java/org/apache/dubbo/monitor/support/MonitorFilter.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3121 +/- ##
============================================
- Coverage 63.67% 63.54% -0.14%
Complexity 75 75
============================================
Files 652 652
Lines 28190 28190
Branches 4784 4784
============================================
- Hits 17950 17913 -37
- Misses 7989 8022 +33
- Partials 2251 2255 +4
Continue to review full report at Codecov.
|
ralf0131
approved these changes
Jan 3, 2019
Contributor
ralf0131
left a comment
There was a problem hiding this comment.
LGTM, thanks for the pull request.
This was referenced Jan 7, 2019
khanimteyaz
pushed a commit
to khanimteyaz/incubator-dubbo
that referenced
this pull request
Jan 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
enhance dubbo-monitor module javadoc #2997
Brief changelog
/dubbo-monitor-api/src/main/java/org/apache/dubbo/monitor/support/AbstractMonitorFactory.java
/dubbo-monitor-api/src/main/java/org/apache/dubbo/monitor/support/MonitorFilter.java
/dubbo-monitor-default/src/main/java/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
Verifying this change
unit test passed
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.