Simple date format each time new object creation removed#3080
Closed
khanimteyaz wants to merge 15 commits intoapache:masterfrom
Closed
Simple date format each time new object creation removed#3080khanimteyaz wants to merge 15 commits intoapache:masterfrom
khanimteyaz wants to merge 15 commits intoapache:masterfrom
Conversation
6 tasks
Contributor
Author
Member
|
Hi, @khanimteyaz |
Contributor
Author
@carryxyh thanks. |
…orListener. * refactor ScriptRouter * refactor TagRouter * refactor AbstractConfiguratorListener * make sure parameter should not be null * correct comments * make ReferenceConfigurationListener private static * avoid dup code in init * add fixme for potential useless code
…/dubbo-registry-default (apache#3053) * add FailedRetryTaskTest.java
carryxyh
reviewed
Dec 28, 2018
| } | ||
|
|
||
| private AccessLogData buildAccessLogData(Invoker<?> invoker, Invocation inv) { | ||
| RpcContext context = RpcContext.getContext(); |
Member
There was a problem hiding this comment.
How about move this to AccessLogData's constructor?
Member
|
Would u pls rebase master to fix ci failed? |
…yaz/incubator-dubbo into acesslog-dateformat-enhancemnet
Codecov Report
@@ Coverage Diff @@
## master #3080 +/- ##
=========================================
Coverage ? 63.59%
Complexity ? 75
=========================================
Files ? 654
Lines ? 28311
Branches ? 4817
=========================================
Hits ? 18004
Misses ? 8040
Partials ? 2267
Continue to review full report at Codecov.
|
Contributor
Author
|
@carryxyh It seems my rebase has introduce lots of commits of others, so raising another PR. |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
AcceLogFilter message creation and last and current check was performing by each time simple date formate object creation. In this version of code I have use the ThreadLocal for each thread wise to create simple date format object instead of each call
#3026
In this PR
- Method naming
- Reducing big methods to small.
This PR is a resurrection of old 3027 (#3027) PR
Sorry for the inconvenience
Brief changelog
XXXXX
Verifying this change
Runnig UT and verifying generated access log.
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.