Skip to content

add unit test to dubbo-registry/dubbo-registry-api and dubbo-registry/dubbo-registry-default#3053

Merged
lovepoem merged 4 commits intoapache:masterfrom
lixiaojiee:20181225-A
Dec 28, 2018
Merged

add unit test to dubbo-registry/dubbo-registry-api and dubbo-registry/dubbo-registry-default#3053
lovepoem merged 4 commits intoapache:masterfrom
lixiaojiee:20181225-A

Conversation

@lixiaojiee
Copy link
Copy Markdown
Contributor

@lixiaojiee lixiaojiee commented Dec 24, 2018 •
edited
Loading

What is the purpose of the change

add unit test to dubbo-registry/dubbo-registry-api and dubbo-registry/dubbo-registry-default
#1690

Brief changelog

dubbo-registry/dubbo-registry-default/src/test/java/org/apache/dubbo/registry/dubbo/DubboRegistryTest.java

Verifying this change

ut pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@lovepoem
Copy link
Copy Markdown
Member

lovepoem commented Dec 27, 2018

Please merge origin/master to make ci success

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 27, 2018

Codecov Report

Merging #3053 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3053      +/-   ##
============================================
+ Coverage     63.43%   63.46%   +0.03%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28261    28261              
  Branches       4820     4820              
============================================
+ Hits          17926    17937      +11     
+ Misses         8057     8053       -4     
+ Partials       2278     2271       -7
Impacted Files Coverage Δ Complexity Δ
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-2.18%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 63.79% <0%> (-1.73%) 0% <0%> (ø)
...dubbo/metadata/support/AbstractMetadataReport.java 69.35% <0%> (-1.62%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 71.81% <0%> (-1.35%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 57.57% <0%> (-0.76%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 81.2% <0%> (-0.76%) 0% <0%> (ø)
...mon/src/main/java/org/apache/dubbo/common/URL.java 45.9% <0%> (+0.14%) 0% <0%> (ø) ⬇️
...bo/remoting/transport/netty/NettyCodecAdapter.java 54.68% <0%> (+1.56%) 0% <0%> (ø) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea4fa5...a51fd02. Read the comment docs.

@lixiaojiee
Copy link
Copy Markdown
Contributor Author

lixiaojiee commented Dec 28, 2018

Please merge origin/master to make ci success

It has been processed.

@lovepoem
Copy link
Copy Markdown
Member

lovepoem commented Dec 28, 2018

LGTM

@lovepoem lovepoem merged commit cd56069 into apache:master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carryxyh carryxyh carryxyh left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lixiaojiee @lovepoem @codecov-io @carryxyh