Skip to content

fix #3070#3073

Merged
ralf0131 merged 2 commits intoapache:masterfrom
CrazyHZM:removeDuplicateCode
Jan 3, 2019
Merged

fix #3070#3073
ralf0131 merged 2 commits intoapache:masterfrom
CrazyHZM:removeDuplicateCode

Conversation

@CrazyHZM
Copy link
Copy Markdown
Member

@CrazyHZM CrazyHZM commented Dec 27, 2018

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 2, 2019

Codecov Report

Merging #3073 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3073      +/-   ##
============================================
+ Coverage     63.52%   63.56%   +0.04%     
  Complexity       75       75              
============================================
  Files           652      652              
  Lines         28183    28179       -4     
  Branches       4791     4790       -1     
============================================
+ Hits          17902    17913      +11     
+ Misses         8023     8004      -19     
- Partials       2258     2262       +4
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/config/AbstractConfig.java 80.13% <100%> (+1.03%) 0 <0> (ø) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-2.44%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.15% <0%> (-2.02%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 57.3% <0%> (-0.77%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 81.2% <0%> (+1.12%) 0% <0%> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (+2.17%) 0% <0%> (ø) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.88% <0%> (+4.7%) 0% <0%> (ø) ⬇️
...ava/org/apache/dubbo/config/DubboShutdownHook.java 84.37% <0%> (+6.25%) 0% <0%> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 53.94% <0%> (+10.52%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41408e...c76b231. Read the comment docs.

ralf0131
ralf0131 approved these changes Jan 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request!

@ralf0131 ralf0131 merged commit 6aad8da into apache:master Jan 3, 2019
This was referenced Jan 7, 2019
Open
Closed
@CrazyHZM CrazyHZM deleted the removeDuplicateCode branch January 11, 2019 03:27
khanimteyaz pushed a commit to khanimteyaz/incubator-dubbo that referenced this pull request Jan 18, 2019
@CrazyHZM @khanimteyaz
Remove unused code, fix apache#3070 (apache#3073)
e0f960a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralf0131 ralf0131 ralf0131 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CrazyHZM @codecov-io @ralf0131