make loadbalance robust, add comments#2962
Merged
beiwei30 merged 1 commit intoapache:masterfrom Dec 17, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
=========================================
Coverage ? 64.05%
=========================================
Files ? 584
Lines ? 26062
Branches ? 4562
=========================================
Hits ? 16694
Misses ? 7186
Partials ? 2182
Continue to review full report at Codecov.
|
Codeprh
added a commit
to Codeprh/dubbo-go
that referenced
this pull request
May 9, 2022
…va optimization records. For example:
apache/dubbo#2962
apache/dubbo#5909
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This patch can make random choose in LoadBalance more robust .
As the getWeight method in AbstractLoadBalance uses System.currentTimeMillis(),
so in the random choose stage of RandomLoadBalance ,the weight may change
as System.currentTimeMillis() will get new time stamp.
simplified a little bit code in LeastActiveLoadBalance
make getweight always return weight above zero
Also add comments for AbstractLoadBalance
Brief changelog
org.apache.dubbo.rpc.cluster.loadbalance.AbstractLoadBalance
org.apache.dubbo.rpc.cluster.loadbalance.RandomLoadBalance
org.apache.dubbo.rpc.cluster.loadbalance.LeastActiveLoadBalance
org.apache.dubbo.rpc.cluster.loadbalance.RoundRobinLoadBalance
Verifying this change