typo: prvoiderService->providerService; connectSkiped->connectSkipped#2396
Merged
diecui1202 merged 1 commit intoapache:masterfrom Aug 28, 2018
Merged
typo: prvoiderService->providerService; connectSkiped->connectSkipped#2396diecui1202 merged 1 commit intoapache:masterfrom
diecui1202 merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2396 +/- ##
===========================================
+ Coverage 54.76% 54.8% +0.04%
- Complexity 5234 5237 +3
===========================================
Files 573 573
Lines 25453 25456 +3
Branches 4537 4537
===========================================
+ Hits 13939 13951 +12
+ Misses 9416 9410 -6
+ Partials 2098 2095 -3
Continue to review full report at Codecov.
|
|
@363230482 Thanks for u contribution. It looks good to me. |
zzzzhougit
pushed a commit
to zzzzhougit/incubator-dubbo
that referenced
this pull request
Sep 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
typo
Brief changelog
prvoiderService->providerService; connectSkiped->connectSkipped
Verifying this change
none
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.