Skip to content

New ascii logo.#2395

Merged
diecui1202 merged 1 commit intoapache:masterfrom
carryxyh:newlogo
Aug 28, 2018
Merged

New ascii logo.#2395
diecui1202 merged 1 commit intoapache:masterfrom
carryxyh:newlogo

Conversation

@carryxyh
Copy link
Copy Markdown
Member

@carryxyh carryxyh commented Aug 28, 2018

New ascii logo.

Voting is here:
#2332

@carryxyh
Copy link
Copy Markdown
Member Author

carryxyh commented Aug 28, 2018

The effect of the new LOGO is：
image

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 28, 2018

Codecov Report

Merging #2395 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2395      +/-   ##
============================================
+ Coverage     54.76%   54.82%   +0.06%     
- Complexity     5234     5238       +4     
============================================
  Files           573      573              
  Lines         25453    25455       +2     
  Branches       4537     4537              
============================================
+ Hits          13939    13956      +17     
+ Misses         9416     9405      -11     
+ Partials       2098     2094       -4
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/qos/server/DubboLogo.java 0% <ø> (-50%) 0 <0> (-1)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 77.77% <0%> (-11.12%) 5% <0%> (-2%)
.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java 68.33% <0%> (-3.34%) 11% <0%> (ø)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-1.26%) 12% <0%> (ø)
...e/dubbo/remoting/transport/netty4/NettyClient.java 63.33% <0%> (-1.08%) 11% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 58.46% <0%> (-0.92%) 9% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 59.16% <0%> (+0.83%) 31% <0%> (+1%) ⬆️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (+1.86%) 15% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty4/NettyServer.java 75.4% <0%> (+3.27%) 10% <0%> (+1%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f8adf0...c8cbd21. Read the comment docs.

@diecui1202
Copy link
Copy Markdown

diecui1202 commented Aug 28, 2018

looks good to me.

@diecui1202 diecui1202 merged commit ff373a7 into apache:master Aug 28, 2018
@diecui1202
Copy link
Copy Markdown

diecui1202 commented Aug 29, 2018

@carryxyh 2.6.x will also get this change?

@carryxyh
Copy link
Copy Markdown
Member Author

carryxyh commented Aug 29, 2018

@diecui1202
Nope, I will send another pr to 2.6.x branch.
In addition, I checked the logo of the spring-boot-dubbo project. At present, the spring-boot-dubbo directly references the dubbo logo, so there is no need for a new pr.

@diecui1202
Copy link
Copy Markdown

diecui1202 commented Aug 29, 2018

Got it.

@carryxyh carryxyh deleted the newlogo branch August 29, 2018 09:17
zzzzhougit pushed a commit to zzzzhougit/incubator-dubbo that referenced this pull request Sep 9, 2018
@carryxyh @zzzzhougit
New ascii logo. (apache#2395)
f3fcbda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carryxyh @codecov-io @diecui1202