Skip to content

Binding attachment before a clusterInvoker invoke. #2125

Merged
chickenlj merged 1 commit intoapache:masterfrom
carryxyh:fix/attachment
Jul 31, 2018
Merged

Binding attachment before a clusterInvoker invoke. #2125
chickenlj merged 1 commit intoapache:masterfrom
carryxyh:fix/attachment

Conversation

@carryxyh
Copy link
Copy Markdown
Member

@carryxyh carryxyh commented Jul 24, 2018

  • Binding attachments into invocation so that a rpc invoke have a same invocation
  • Fix a bug that the ForkingClusterInvoker don't clear attachment when a rpc invoke is over.

@carryxyh
* Binding attachments into invocation so that a rpc invoke have a sam…
d03a7b1 
…e invocation

* Fix a bug that the ForkingClusterInvoker don't clear attachment when a rpc invoke is over.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 24, 2018

Codecov Report

Merging #2125 into master will decrease coverage by 0.08%.
The diff coverage is 79.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #2125      +/-   ##
===========================================
- Coverage     54.19%   54.1%   -0.09%     
+ Complexity     5085    5081       -4     
===========================================
  Files           559     559              
  Lines         24922   24926       +4     
  Branches       4442    4443       +1     
===========================================
- Hits          13506   13487      -19     
- Misses         9380    9402      +22     
- Partials       2036    2037       +1
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...bo/rpc/cluster/support/AbstractClusterInvoker.java 70.47% <66.66%> (-0.12%) 42 <0> (+1)
...bbo/rpc/cluster/support/ForkingClusterInvoker.java 85.71% <83.33%> (+0.42%) 7 <6> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 42.25% <0%> (-11.27%) 15% <0%> (-1%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.5% <0%> (-8.75%) 19% <0%> (-2%)
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-8.48%) 12% <0%> (-1%)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-1.48%) 29% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 58.33% <0%> (-0.84%) 30% <0%> (-1%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 88.88% <0%> (+5.55%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6e6f3...d03a7b1. Read the comment docs.

@carryxyh carryxyh mentioned this pull request Jul 24, 2018
Merged
@kimmking
Copy link
Copy Markdown
Member

kimmking commented Jul 26, 2018

awesome

@chickenlj chickenlj merged commit 971d80d into apache:master Jul 31, 2018
@carryxyh carryxyh deleted the fix/attachment branch July 31, 2018 06:51
carryxyh added a commit to carryxyh/incubator-dubbo that referenced this pull request Aug 2, 2018
@carryxyh
Merge pull request apache#2125, binding attachments into invocation s…
1376b26 
…o that a rpc invoke have a same invocation.

Fixes apache#1978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carryxyh @codecov-io @kimmking @chickenlj