Skip to content

rename access log in unit test from 'alibaba' to 'alibaba.log' #2051

Merged
beiwei30 merged 1 commit intoapache:masterfrom
beiwei30:unit-test-access-log
Jul 9, 2018
Merged

rename access log in unit test from 'alibaba' to 'alibaba.log' #2051
beiwei30 merged 1 commit intoapache:masterfrom
beiwei30:unit-test-access-log

Conversation

@beiwei30
Copy link
Copy Markdown
Member

@beiwei30 beiwei30 commented Jul 9, 2018

What is the purpose of the change

rename access log in unit test from 'alibaba' to 'alibaba.log'

Brief changelog

dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 9, 2018

Codecov Report

Merging #2051 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2051      +/-   ##
============================================
- Coverage     52.19%   52.09%   -0.11%     
+ Complexity     4963     4955       -8     
============================================
  Files           568      568              
  Lines         25453    25453              
  Branches       4486     4486              
============================================
- Hits          13285    13259      -26     
- Misses        10144    10164      +20     
- Partials       2024     2030       +6
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/config/DubboShutdownHook.java 40% <0%> (-36%) 6% <0%> (-1%)
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-8.48%) 12% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 60% <0%> (-6.25%) 21% <0%> (-2%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) 11% <0%> (-2%)
...e/dubbo/remoting/transport/netty4/NettyServer.java 72.13% <0%> (-3.28%) 9% <0%> (-1%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-1.87%) 15% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (ø) 6% <0%> (ø) ⬇️
...bo/remoting/transport/netty/NettyCodecAdapter.java 54.68% <0%> (+1.56%) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36a6ee...2436a73. Read the comment docs.

@beiwei30 beiwei30 merged commit f0f8dba into apache:master Jul 9, 2018
@beiwei30 beiwei30 deleted the unit-test-access-log branch July 9, 2018 06:44
July-X pushed a commit to July-X/dubbo that referenced this pull request Jul 12, 2018
@Z-starts
Merge commit 'b055991b317f4e58d256721875a00c52fe415510'
e198810 
* commit 'b055991b317f4e58d256721875a00c52fe415510': (271 commits)
  Merge pull request apache#1957, enhancements for the new async way of Dubbo.
  rename log file from alibaba to custom-access (apache#2057)
  Merge pull request apache#2049, upgrade netty4 to the latest release and make it the default option for transporter.
  Format style.
  Restore the badges in README.
  Polish README.
  Refactor README.
  Merge pull request apache#2047, deprecate dubbo-rpc-thrift.
  Merge pull request apache#2005, change maven parent from sonatype to apache.
  rename access log in unit test from 'alibaba' to 'alibaba.log' so that it cannot be committed by accident. (apache#2051)
  add test cases for injvm rpc protocol (apache#2041)
  add test cases for rpc thrift protocol (apache#2042)
  Merge pull request apache#1966, introduces dubbo metrics API module.
  [Dubbo- unit test class not found] fix class not found "hi" (apache#2034)
  add README for compatible module (apache#2019)
  Polish README.
  update README (apache#2025)
  [Dubbo-1695] Enhance the test coverage part-16 : dubbo-rpc/dubbo-rpc-api  module (apache#2004)
  Merge pull request apache#1997, clienthandler in netty4 should trigger heartbeat handler.
  Update issue template description.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beiwei30 @codecov-io