[Dubbo-1765] Fix ReferenceBean initialization issue#1999
Merged
zonghaishang merged 1 commit intoapache:masterfrom Aug 1, 2018
Merged
[Dubbo-1765] Fix ReferenceBean initialization issue#1999zonghaishang merged 1 commit intoapache:masterfrom
zonghaishang merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1999 +/- ##
===========================================
+ Coverage 50.98% 52.2% +1.22%
- Complexity 4775 4912 +137
===========================================
Files 562 562
Lines 25218 25249 +31
Branches 4449 4450 +1
===========================================
+ Hits 12857 13181 +324
+ Misses 10431 10065 -366
- Partials 1930 2003 +73
Continue to review full report at Codecov.
|
carryxyh
pushed a commit
to carryxyh/incubator-dubbo
that referenced
this pull request
Aug 2, 2018
This was referenced Aug 30, 2018
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixed a bug described in Dubbo-1765
If the provider is temporarily unavailable, the reference bean initialization will failed with exception. However, the initialized flag will be set to true, which will cause spring to hold a NULL_OBJECT cache. The subsequent call will always get a null instance.
This change will allow the consumer to obtain the correct instance when provider become available.
Brief changelog
Verifying this change
unit test passed
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.