[Dubbo-889-Attachments] support implicit delivery of attachments from provider to consumer#1442
Closed
chickenlj wants to merge 4 commits intoapache:masterfrom
chickenlj:provider_attachments
Closed
[Dubbo-889-Attachments] support implicit delivery of attachments from provider to consumer#1442chickenlj wants to merge 4 commits intoapache:masterfrom chickenlj:provider_attachments
chickenlj wants to merge 4 commits intoapache:masterfrom
chickenlj:provider_attachments
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1442 +/- ##
==========================================
+ Coverage 31.57% 31.58% +<.01%
==========================================
Files 682 682
Lines 33035 33099 +64
Branches 6592 6604 +12
==========================================
+ Hits 10432 10454 +22
- Misses 20750 20785 +35
- Partials 1853 1860 +7
Continue to review full report at Codecov.
|
|
我认为这个commit存在bug, |
Contributor
|
thumbs up |
Contributor
Author
|
没毛病，是我看漏了 |
Member
|
can you commit a test case for the change? |
Contributor
Author
|
I will resolve the conflicts, add some test cases. |
Contributor
Author
|
Sorry, some problem with the personal remote repository, i will submit a new PR. |
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes #889, support implicit delivery of attachments from provider to consumer
Brief changelog
Not completely finished yet.
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.