implement FiniteFirehoseFactory in InlineFirehose#8682
Merged
fjy merged 2 commits intoapache:masterfrom Oct 17, 2019
aditya-r-m:fix-inlineFireHoseParallelIndex
Merged
implement FiniteFirehoseFactory in InlineFirehose#8682fjy merged 2 commits intoapache:masterfrom aditya-r-m:fix-inlineFireHoseParallelIndex
fjy merged 2 commits intoapache:masterfrom
aditya-r-m:fix-inlineFireHoseParallelIndex
Conversation
Contributor
Author
|
@ccaominh @jihoonson the approach mentioned on the ticket is implemented here. |
Contributor
|
@aditya-r-m thank you for your contribution! I have a couple of comments.
|
Contributor
Author
|
@jihoonson thank you for your guidance. |
Contributor
Author
|
@jihoonson implemented the suggested updates. |
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Nov 27, 2019
* implement FiniteFirehoseFactory in InlineFirehose * override isSplittable in InlineFirehoseFactory & improve tests
jon-wei
added a commit
that referenced
this pull request
Nov 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8673.
Description
Implementation of FiniteFirehoseFactory to support index_parallel tasks with inline data ingestion.
The implementation always returns 1 split.
This PR has:
Key changed/added classes in this PR
InlineFirehoseFactory.java