Skip to content

[fix](metrics) fix routine_load_task_execute_count metrics #59937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cambyzju merged 1 commit into from
Jan 16, 2026
Merged

[fix](metrics) fix routine_load_task_execute_count metrics #59937

cambyzju merged 1 commit into from
Jan 16, 2026
+2 −2

Conversation

@cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Jan 15, 2026

What problem does this PR solve?

come from: #48209

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 15, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@cambyzju cambyzju changed the title [fix](metrics) fix routine_load_task_execute_count routine load metrics [fix](metrics) fix routine_load_task_execute_count metrics Jan 15, 2026
@cambyzju
Copy link
Contributor Author

cambyzju commented Jan 15, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Jan 15, 2026

TPC-H: Total hot run time: 31759 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 53bba284b9616b2b66dfd8162c09f0c213dfc997, data reload: false

------ Round 1 ----------------------------------
q1	17670	4307	4083	4083
q2	2034	342	239	239
q3	10184	1269	698	698
q4	10201	853	307	307
q5	7517	2051	1843	1843
q6	181	171	138	138
q7	943	796	647	647
q8	9279	1377	1193	1193
q9	4884	4554	4528	4528
q10	6789	1790	1416	1416
q11	547	284	282	282
q12	695	739	587	587
q13	17789	3862	3130	3130
q14	293	299	273	273
q15	588	520	509	509
q16	692	694	651	651
q17	654	802	484	484
q18	6796	6238	6672	6238
q19	1116	1191	684	684
q20	435	401	270	270
q21	3202	2681	2525	2525
q22	1095	1149	1034	1034
Total cold run time: 103584 ms
Total hot run time: 31759 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4316	4335	4337	4335
q2	330	420	331	331
q3	2282	2889	2440	2440
q4	1452	1871	1472	1472
q5	4535	4372	4385	4372
q6	221	170	127	127
q7	1984	1910	1787	1787
q8	2530	2362	2396	2362
q9	7158	7160	7267	7160
q10	2524	2593	2124	2124
q11	515	451	446	446
q12	681	706	577	577
q13	3328	3821	3116	3116
q14	268	293	271	271
q15	530	496	484	484
q16	607	660	596	596
q17	1111	1331	1350	1331
q18	7467	7276	7225	7225
q19	863	822	803	803
q20	1879	1944	1840	1840
q21	4518	4280	4225	4225
q22	1085	1013	991	991
Total cold run time: 50184 ms
Total hot run time: 48415 ms

@doris-robot
Copy link

doris-robot commented Jan 15, 2026

TPC-DS: Total hot run time: 174267 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 53bba284b9616b2b66dfd8162c09f0c213dfc997, data reload: false

query5	4989	632	486	486
query6	347	229	204	204
query7	4218	453	261	261
query8	336	231	230	230
query9	8725	2853	2782	2782
query10	549	391	323	323
query11	15243	15226	14850	14850
query12	189	117	110	110
query13	1238	460	377	377
query14	6414	3080	2823	2823
query14_1	2704	2668	2700	2668
query15	197	192	172	172
query16	994	494	470	470
query17	1066	680	589	589
query18	2621	443	342	342
query19	228	223	199	199
query20	122	119	115	115
query21	221	140	115	115
query22	4015	4024	4005	4005
query23	15947	15577	15252	15252
query23_1	15513	15425	15331	15331
query24	7115	1586	1180	1180
query24_1	1187	1169	1174	1169
query25	563	489	444	444
query26	1242	274	159	159
query27	2750	438	277	277
query28	4544	2141	2116	2116
query29	767	577	448	448
query30	310	248	212	212
query31	793	629	569	569
query32	87	78	85	78
query33	541	355	328	328
query34	897	898	541	541
query35	736	749	688	688
query36	934	895	781	781
query37	177	92	85	85
query38	2739	2654	2669	2654
query39	766	743	717	717
query39_1	703	727	707	707
query40	216	148	117	117
query41	67	62	60	60
query42	108	98	101	98
query43	467	458	401	401
query44	1307	724	736	724
query45	188	188	181	181
query46	835	939	582	582
query47	1388	1501	1375	1375
query48	318	315	231	231
query49	608	427	335	335
query50	621	277	204	204
query51	3769	3835	3781	3781
query52	104	106	99	99
query53	286	319	275	275
query54	285	268	274	268
query55	82	80	76	76
query56	307	309	320	309
query57	1019	1033	929	929
query58	274	266	270	266
query59	2009	2181	2026	2026
query60	341	335	309	309
query61	150	158	154	154
query62	402	358	315	315
query63	295	269	266	266
query64	4837	1290	980	980
query65	3816	3714	3704	3704
query66	1401	429	302	302
query67	15499	15569	15452	15452
query68	2428	1081	742	742
query69	450	393	331	331
query70	983	965	963	963
query71	321	311	297	297
query72	5472	3469	3399	3399
query73	600	715	328	328
query74	8719	8719	8574	8574
query75	2781	2816	2442	2442
query76	2283	1080	648	648
query77	352	386	313	313
query78	9745	9844	9190	9190
query79	1179	883	583	583
query80	1318	574	490	490
query81	544	265	234	234
query82	987	144	111	111
query83	348	262	249	249
query84	256	119	99	99
query85	912	515	474	474
query86	412	296	306	296
query87	2848	2896	2770	2770
query88	3484	2582	2558	2558
query89	392	337	326	326
query90	1994	176	165	165
query91	185	172	138	138
query92	80	72	69	69
query93	1085	878	535	535
query94	654	325	305	305
query95	599	400	325	325
query96	637	499	224	224
query97	2366	2398	2356	2356
query98	217	209	203	203
query99	581	571	503	503
Total cold run time: 248021 ms
Total hot run time: 174267 ms

@doris-robot
Copy link

doris-robot commented Jan 15, 2026

ClickBench: Total hot run time: 26.85 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 53bba284b9616b2b66dfd8162c09f0c213dfc997, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.04	0.04
query3	0.26	0.09	0.08
query4	1.61	0.12	0.11
query5	0.27	0.26	0.25
query6	1.14	0.67	0.65
query7	0.03	0.02	0.03
query8	0.06	0.04	0.04
query9	0.57	0.52	0.51
query10	0.56	0.55	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.58	0.58
query14	0.95	0.94	0.95
query15	0.78	0.76	0.78
query16	0.38	0.37	0.40
query17	1.05	1.07	1.07
query18	0.22	0.21	0.21
query19	1.96	1.79	1.79
query20	0.02	0.01	0.01
query21	15.46	0.27	0.14
query22	4.99	0.05	0.04
query23	15.85	0.28	0.11
query24	2.21	0.37	0.47
query25	0.12	0.08	0.07
query26	0.13	0.14	0.14
query27	0.06	0.05	0.06
query28	4.59	1.06	0.88
query29	12.56	3.97	3.22
query30	0.30	0.14	0.12
query31	2.81	0.63	0.38
query32	3.24	0.57	0.46
query33	3.05	3.03	2.99
query34	16.19	5.04	4.38
query35	4.44	4.42	4.45
query36	0.67	0.49	0.48
query37	0.11	0.07	0.06
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.16	0.13
query41	0.09	0.04	0.04
query42	0.05	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.15 s
Total hot run time: 26.85 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 15, 2026

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

dataroaring
dataroaring approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

PR approved by anyone and no changes requested.

lide-reed
lide-reed approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xy720
xy720 approved these changes Jan 16, 2026
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMTM

@cambyzju cambyzju merged commit d7ee4fb into apache:master Jan 16, 2026
36 of 37 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 16, 2026
@cambyzju
[fix](metrics) fix routine_load_task_execute_count metrics (#59937)
c013cd8 
### What problem does this PR solve?

come from: #48209

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Jan 16, 2026
Merged
yiguolei pushed a commit that referenced this pull request Jan 16, 2026
@github-actions @cambyzju
branch-4.0: [fix](metrics) fix routine_load_task_execute_count metrics …
e1a27ce 
…#59937 (#59961)

Cherry-picked from #59937

Co-authored-by: camby <104178625@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lide-reed lide-reed lide-reed approved these changes

@xy720 xy720 xy720 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.x dev/3.1.x dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cambyzju @hello-stephen @doris-robot @lide-reed @xy720 @dataroaring @yiguolei