Skip to content

[fix](catalog) fix wrong issue of getBackendMeta #59191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Dec 22, 2025
Merged

[fix](catalog) fix wrong issue of getBackendMeta #59191

morningman merged 1 commit into from
Dec 22, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Dec 19, 2025 •
edited
Loading

What problem does this PR solve?

Related PR: #57898

Problem Summary:
The getBackendMeta does not need to call to Master FE.
If use specified non-master FE address in Doris Catalog, it will result in dead loop

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Dec 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 19, 2025

TPC-H: Total hot run time: 36684 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8f8526a0b0aebad2c04a205d46c2f65b3a295f30, data reload: false

------ Round 1 ----------------------------------
q1	17646	4211	4080	4080
q2	2028	355	244	244
q3	10185	1331	758	758
q4	10212	857	321	321
q5	7943	2103	2114	2103
q6	252	178	137	137
q7	1018	829	743	743
q8	9394	1399	1117	1117
q9	7221	5371	5333	5333
q10	6876	2392	2010	2010
q11	526	317	305	305
q12	750	746	597	597
q13	17798	3706	3063	3063
q14	304	303	278	278
q15	602	541	513	513
q16	711	678	637	637
q17	710	782	595	595
q18	8156	8112	7758	7758
q19	1726	1017	650	650
q20	425	380	264	264
q21	4663	4316	4170	4170
q22	1145	1068	1008	1008
Total cold run time: 110291 ms
Total hot run time: 36684 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4627	4277	4116	4116
q2	325	404	330	330
q3	2363	2864	2440	2440
q4	1500	1878	1439	1439
q5	4530	4476	4700	4476
q6	227	171	124	124
q7	2027	1943	1816	1816
q8	2681	2498	2545	2498
q9	7562	7419	7428	7419
q10	3070	3336	2831	2831
q11	599	503	474	474
q12	638	710	566	566
q13	3298	3643	3050	3050
q14	272	279	260	260
q15	541	488	497	488
q16	621	661	594	594
q17	1135	1410	1415	1410
q18	7310	7179	7076	7076
q19	823	804	831	804
q20	1897	2014	1802	1802
q21	4645	4407	4176	4176
q22	1074	998	980	980
Total cold run time: 51765 ms
Total hot run time: 49169 ms

@doris-robot
Copy link

doris-robot commented Dec 19, 2025

TPC-DS: Total hot run time: 178463 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8f8526a0b0aebad2c04a205d46c2f65b3a295f30, data reload: false

query5	4719	615	483	483
query6	330	232	218	218
query7	4237	487	277	277
query8	299	260	244	244
query9	8763	2551	2567	2551
query10	490	380	333	333
query11	15399	14741	14524	14524
query12	182	117	119	117
query13	1265	501	404	404
query14	5718	3033	2783	2783
query14_1	2759	2682	2708	2682
query15	220	205	183	183
query16	881	489	460	460
query17	1135	723	610	610
query18	2451	454	353	353
query19	245	248	213	213
query20	124	119	116	116
query21	234	144	119	119
query22	3945	3921	3879	3879
query23	16539	16075	15788	15788
query23_1	16025	16129	16106	16106
query24	7371	1686	1250	1250
query24_1	1224	1244	1250	1244
query25	604	470	443	443
query26	1251	266	177	177
query27	2747	448	316	316
query28	4494	2135	2138	2135
query29	806	554	447	447
query30	322	248	214	214
query31	810	695	664	664
query32	88	71	70	70
query33	548	354	284	284
query34	900	941	542	542
query35	779	817	724	724
query36	872	905	823	823
query37	130	96	77	77
query38	2888	2898	2827	2827
query39	752	734	722	722
query39_1	687	693	711	693
query40	236	138	125	125
query41	89	66	63	63
query42	111	104	104	104
query43	440	448	397	397
query44	1364	741	746	741
query45	192	190	184	184
query46	912	1011	629	629
query47	1670	1681	1585	1585
query48	321	339	255	255
query49	643	457	352	352
query50	659	298	221	221
query51	3784	3850	3899	3850
query52	108	114	106	106
query53	326	344	294	294
query54	283	255	274	255
query55	80	73	74	73
query56	303	311	307	307
query57	1116	1119	1068	1068
query58	291	254	257	254
query59	2395	2491	2357	2357
query60	320	318	289	289
query61	164	159	161	159
query62	722	687	637	637
query63	328	297	309	297
query64	5026	1325	1010	1010
query65	3998	3949	3950	3949
query66	1484	454	323	323
query67	15157	15108	14647	14647
query68	3386	1045	761	761
query69	501	353	313	313
query70	1077	990	959	959
query71	367	312	293	293
query72	6553	5254	5088	5088
query73	700	638	315	315
query74	8754	8740	8561	8561
query75	3221	3202	2820	2820
query76	3713	1143	730	730
query77	530	414	311	311
query78	9543	9679	8848	8848
query79	1199	941	619	619
query80	1226	662	552	552
query81	552	275	248	248
query82	540	142	103	103
query83	361	252	245	245
query84	258	121	103	103
query85	949	512	460	460
query86	390	285	274	274
query87	3039	3036	2901	2901
query88	3316	2305	2297	2297
query89	470	421	386	386
query90	1973	162	159	159
query91	181	173	147	147
query92	72	72	67	67
query93	1126	941	565	565
query94	528	308	299	299
query95	575	339	311	311
query96	602	486	207	207
query97	2265	2361	2224	2224
query98	209	194	199	194
query99	1266	1292	1229	1229
Total cold run time: 255138 ms
Total hot run time: 178463 ms

@doris-robot
Copy link

doris-robot commented Dec 19, 2025

ClickBench: Total hot run time: 27.17 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8f8526a0b0aebad2c04a205d46c2f65b3a295f30, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.09	0.08
query4	1.60	0.11	0.11
query5	0.26	0.24	0.25
query6	1.17	0.65	0.63
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.56	0.52	0.50
query10	0.57	0.57	0.57
query11	0.16	0.11	0.10
query12	0.15	0.11	0.12
query13	0.62	0.60	0.61
query14	1.00	0.98	0.99
query15	0.81	0.79	0.81
query16	0.39	0.39	0.42
query17	1.04	1.02	1.06
query18	0.22	0.21	0.21
query19	1.89	1.86	1.80
query20	0.02	0.01	0.01
query21	15.44	0.29	0.14
query22	4.68	0.05	0.05
query23	15.98	0.28	0.10
query24	0.94	0.24	0.31
query25	0.09	0.07	0.06
query26	0.13	0.14	0.13
query27	0.06	0.06	0.05
query28	2.96	1.22	1.04
query29	12.61	3.98	3.20
query30	0.28	0.14	0.12
query31	2.83	0.63	0.40
query32	3.23	0.54	0.45
query33	3.02	3.07	3.04
query34	16.96	5.18	4.50
query35	4.56	4.51	4.58
query36	0.65	0.50	0.48
query37	0.10	0.07	0.06
query38	0.08	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 95.94 s
Total hot run time: 27.17 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 19, 2025

FE Regression Coverage Report

Increment line coverage 66.67% (2/3) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2025

PR approved by anyone and no changes requested.

@morningman morningman merged commit b4f4b21 into apache:master Dec 22, 2025
33 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 22, 2025
@morningman
[fix](catalog) fix wrong issue of getBackendMeta (#59191)
949ee4d 
### What problem does this PR solve?

Related PR: #57898

Problem Summary:
The `getBackendMeta` does not need to call to Master FE.
If use specified non-master FE address in Doris Catalog, it will result
in dead loop
@github-actions github-actions bot mentioned this pull request Dec 22, 2025
Merged
morningman added a commit that referenced this pull request Dec 23, 2025
@github-actions @morningman
branch-4.0: [fix](catalog) fix wrong issue of getBackendMeta #59191 (#…
b8a1459 
…59226)

Cherry-picked from #59191

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

+1 more reviewer

@hubgeter hubgeter hubgeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morningman @hello-stephen @doris-robot @CalvinKirs @hubgeter