Skip to content

[Improvement](function) reduce cast of input arg from decimal avg #58666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 2 commits into from
Dec 10, 2025
Merged

[Improvement](function) reduce cast of input arg from decimal avg #58666

BiteTheDDDDt merged 2 commits into from
Dec 10, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Dec 3, 2025 •
edited
Loading

What problem does this PR solve?

SELECT avg((ss_quantity * ss_list_price)) average_sales from store_sales;

before:
partial_avg(CAST((CAST(ss_quantity[#23] AS decimalv3(10,0)) * ss_list_price[#24]) AS decimalv3(19,4)))[#25]
doris 28.42 sec
doris disable check 25.17 sec

after:
partial_avg((CAST(ss_quantity[#23] AS decimalv3(10,0)) * ss_list_price[#24]))[#25]
doris 19.14 sec
doris disable check 17.12 sec

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 3, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 3, 2025

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 3, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.45% (18696/34977)
Line Coverage 39.09% (172589/441483)
Region Coverage 33.71% (133654/396452)
Branch Coverage 34.66% (57505/165927)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 3, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 3, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 3, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 3, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 3, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 3, 2025

BE UT Coverage Report

Increment line coverage 45.45% (15/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.36% (18638/34930)
Line Coverage 39.01% (172072/441053)
Region Coverage 33.63% (133226/396158)
Branch Coverage 34.59% (57330/165763)

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 3, 2025

BE Regression && UT Coverage Report

Increment line coverage 90.91% (30/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.15% (24710/34247)
Line Coverage 58.83% (259253/440661)
Region Coverage 53.73% (215449/400969)
Branch Coverage 55.24% (92067/166660)

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 3, 2025

FE Regression Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 4, 2025

run buildall

1 similar comment
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 4, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 4, 2025

BE UT Coverage Report

Increment line coverage 45.45% (15/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.39% (18651/34933)
Line Coverage 39.04% (172207/441079)
Region Coverage 33.65% (133354/396324)
Branch Coverage 34.61% (57389/165808)

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 4, 2025

BE Regression && UT Coverage Report

Increment line coverage 90.91% (30/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.20% (24730/34250)
Line Coverage 58.89% (259503/440689)
Region Coverage 53.74% (215561/401138)
Branch Coverage 55.29% (92178/166707)

morrySnow
morrySnow previously approved these changes Dec 4, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

PR approved by anyone and no changes requested.

HappenLee
HappenLee reviewed Dec 4, 2025
View reviewed changes
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 4, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 4, 2025
HappenLee
HappenLee previously approved these changes Dec 6, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt
reduce cast of input arg from decimal avg
4ea5278 
update

fix

fix

fix

fix

fix

fix test

fix

update
@BiteTheDDDDt
fix compile
7ec26c0
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 6, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 6, 2025

BE UT Coverage Report

Increment line coverage 45.45% (15/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.24% (18625/34981)
Line Coverage 38.93% (171852/441412)
Region Coverage 33.56% (133047/396397)
Branch Coverage 34.50% (57223/165877)

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 6, 2025

BE Regression && UT Coverage Report

Increment line coverage 90.91% (30/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.15% (24750/34303)
Line Coverage 58.86% (259619/441046)
Region Coverage 53.94% (216422/401211)
Branch Coverage 55.30% (92227/166776)

HappenLee
HappenLee approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

PR approved by at least one committer and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 14d8ea2 into apache:master Dec 10, 2025
26 of 29 checks passed
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@BiteTheDDDDt @nagisa-kunhah
[Improvement](function) reduce cast of input arg from decimal avg (ap…
703bc52 
…ache#58666)

```sql
SELECT avg((ss_quantity * ss_list_price)) average_sales from store_sales;
```
before: 
partial_avg(CAST((CAST(ss_quantity[apache#23] AS decimalv3(10,0)) *
ss_list_price[apache#24]) AS decimalv3(19,4)))[apache#25]
doris               28.42 sec
doris disable check 25.17 sec

after: 
partial_avg((CAST(ss_quantity[apache#23] AS decimalv3(10,0)) *
ss_list_price[apache#24]))[apache#25]
doris               19.14 sec
doris disable check 17.12 sec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BiteTheDDDDt @hello-stephen @HappenLee @morrySnow