-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[refactor](predicate) Refine column predicates on OLAP table #58582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
f89b74e to
db045ad
Compare
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 35134 ms |
|
run buildall |
be/src/olap/delete_handler.h
Outdated
| struct DeleteConditions { | ||
| int64_t filter_version = 0; // The version of this condition | ||
| std::vector<const ColumnPredicate*> column_predicate_vec; | ||
| std::vector<std::shared_ptr<ColumnPredicate>> column_predicate_vec; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为什么不是const的了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::vector must have a non-const, non-volatile value_type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::vector<std::shared_ptr> 我们应该是这个结构,感觉是可以的吧?
|
run buildall |
TPC-H: Total hot run time: 35912 ms |
|
run buildall |
TPC-H: Total hot run time: 36922 ms |
TPC-DS: Total hot run time: 171944 ms |
|
run buildall |
TPC-DS: Total hot run time: 171095 ms |
ClickBench: Total hot run time: 27.71 s |
ClickBench: Total hot run time: 27.3 s |
|
run buildall |
TPC-DS: Total hot run time: 0 ms |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 36232 ms |
TPC-DS: Total hot run time: 180953 ms |
ClickBench: Total hot run time: 27.21 s |
|
run buildall |
TPC-H: Total hot run time: 36329 ms |
TPC-DS: Total hot run time: 181928 ms |
ClickBench: Total hot run time: 27.3 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
skip buildall |
| return BloomFilterColumnPredicate<TYPE_IPV6>::create_shared(cid, filter_olap); | ||
| } | ||
| default: | ||
| return nullptr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also throw Exception here?
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)