Skip to content

[fix](regression) Fix case test_domain_connection_and_ak_sk_correction #58572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liaoxin01 merged 1 commit into from
Dec 2, 2025
Merged

[fix](regression) Fix case test_domain_connection_and_ak_sk_correction #58572

liaoxin01 merged 1 commit into from
Dec 2, 2025

Conversation

@0AyanamiRei
Copy link
Contributor

@0AyanamiRei 0AyanamiRei commented Dec 1, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx #56579

Problem Summary:

cuz we add the check : Pattern STANDARD_ENDPOINT_PATTERN = Pattern .compile("^(?:https?://)?(?:s3\\.)?oss-([a-z0-9-]+?)(?:-internal)?\\.aliyuncs\\.com$"); the case will be invalid

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@0AyanamiRei
Copy link
Contributor Author

0AyanamiRei commented Dec 1, 2025

run buildall

liaoxin01
liaoxin01 approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

PR approved by anyone and no changes requested.

sollhui
sollhui approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@sollhui sollhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 merged commit e84d9b5 into apache:master Dec 2, 2025
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 2, 2025
@0AyanamiRei
[fix](regression) Fix case test_domain_connection_and_ak_sk_correction (
412a618 
#58572)

Related PR: ##56579

Problem Summary:

cuz we add the check : `Pattern STANDARD_ENDPOINT_PATTERN = Pattern
.compile("^(?:https?://)?(?:s3\\.)?oss-([a-z0-9-]+?)(?:-internal)?\\.aliyuncs\\.com$");`
the case will be invalid
@github-actions github-actions bot mentioned this pull request Dec 2, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Dec 2, 2025
@0AyanamiRei
[fix](regression) Fix case test_domain_connection_and_ak_sk_correction (
5a63832 
#58572)

Related PR: ##56579

Problem Summary:

cuz we add the check : `Pattern STANDARD_ENDPOINT_PATTERN = Pattern
.compile("^(?:https?://)?(?:s3\\.)?oss-([a-z0-9-]+?)(?:-internal)?\\.aliyuncs\\.com$");`
the case will be invalid
@github-actions github-actions bot mentioned this pull request Dec 2, 2025
Merged
@0AyanamiRei 0AyanamiRei deleted the fix-CORE-5706 branch December 3, 2025 01:59
yiguolei pushed a commit that referenced this pull request Dec 3, 2025
@github-actions @0AyanamiRei
branch-4.0: [fix](regression) Fix case test_domain_connection_and_ak_…
d10258a 
…sk_correction #58572 (#58647)

Cherry-picked from #58572

Co-authored-by: Refrain <113875799+0AyanamiRei@users.noreply.github.com>
morrySnow pushed a commit that referenced this pull request Dec 3, 2025
@github-actions @0AyanamiRei
branch-3.1: [fix](regression) Fix case test_domain_connection_and_ak_…
aa243c8 
…sk_correction #58572 (#58646)

Cherry-picked from #58572

Co-authored-by: Refrain <113875799+0AyanamiRei@users.noreply.github.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@0AyanamiRei @nagisa-kunhah
[fix](regression) Fix case test_domain_connection_and_ak_sk_correction (
0d038ec 
apache#58572)

Related PR: #apache#56579

Problem Summary:

cuz we add the check : `Pattern STANDARD_ENDPOINT_PATTERN = Pattern
.compile("^(?:https?://)?(?:s3\\.)?oss-([a-z0-9-]+?)(?:-internal)?\\.aliyuncs\\.com$");`
the case will be invalid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

+1 more reviewer

@sollhui sollhui sollhui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.4-merged dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@0AyanamiRei @hello-stephen @liaoxin01 @sollhui @yiguolei @morrySnow