Skip to content

Conversation

@stdpain
Copy link
Contributor

@stdpain stdpain commented May 7, 2021

Proposed changes

Fix warning from brpc, S2
Fix -Warray-bounds

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix [Compile] Some compile warning in gcc > 8 #5546 ) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. kind/refactor Issues or PRs to refactor code labels May 10, 2021
@morningman morningman merged commit bd88309 into apache:master May 12, 2021
@stdpain stdpain deleted the fix-warning branch May 14, 2021 07:51
stdpain added a commit to stdpain/incubator-doris that referenced this pull request Jul 8, 2021
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 30, 2025
…on handshake failure apache#57364 (apache#5763)

cherry-picks from apache#57364
Related to apache#5448

Co-authored-by: abmdocrt <lianyukang@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/refactor Issues or PRs to refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Compile] Some compile warning in gcc > 8

3 participants