Skip to content

Conversation

@zzzxl1993
Copy link
Contributor

@zzzxl1993 zzzxl1993 commented Oct 20, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Oct 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zzzxl1993
Copy link
Contributor Author

run buildall

gavinchou
gavinchou previously approved these changes Oct 20, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

ClickBench: Total hot run time: 32.4 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ecbed762c0ea8d1c1b9ada86ec7e12fc669c09af, data reload: false

query1	0.07	0.05	0.06
query2	0.12	0.06	0.07
query3	0.26	0.09	0.10
query4	1.61	0.13	0.12
query5	0.31	0.27	0.28
query6	1.22	0.69	0.70
query7	0.03	0.04	0.03
query8	0.07	0.06	0.06
query9	0.68	0.56	0.56
query10	0.62	0.61	0.63
query11	0.18	0.13	0.13
query12	0.18	0.15	0.15
query13	0.66	0.64	0.63
query14	1.07	1.07	1.05
query15	0.94	0.91	0.91
query16	0.43	0.46	0.48
query17	1.13	1.31	1.18
query18	0.25	0.22	0.23
query19	2.09	1.94	2.02
query20	0.02	0.02	0.02
query21	15.36	1.07	0.67
query22	0.77	1.22	0.75
query23	14.85	1.62	0.67
query24	6.75	1.83	0.76
query25	0.46	0.19	0.15
query26	0.64	0.18	0.16
query27	0.08	0.07	0.07
query28	9.79	1.47	0.97
query29	12.59	4.52	3.73
query30	0.30	0.15	0.13
query31	2.84	0.66	0.43
query32	3.25	0.58	0.52
query33	3.25	3.26	3.28
query34	16.22	5.60	4.96
query35	5.03	4.98	5.04
query36	0.73	0.55	0.52
query37	0.12	0.09	0.08
query38	0.07	0.05	0.06
query39	0.05	0.04	0.04
query40	0.19	0.17	0.16
query41	0.10	0.04	0.03
query42	0.05	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 105.48 s
Total hot run time: 32.4 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 25.00% (1/4) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.61% (17874/33977)
Line Coverage 37.82% (162099/428555)
Region Coverage 32.23% (123580/383413)
Branch Coverage 33.65% (54165/160972)

@zzzxl1993
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 20, 2025
@zzzxl1993
Copy link
Contributor Author

run buildall

@zzzxl1993
Copy link
Contributor Author

run buildall

airborne12
airborne12 previously approved these changes Oct 20, 2025
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2025
@doris-robot
Copy link

ClickBench: Total hot run time: 31.05 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit be4766dfaf0342f47d2fd02cccf7beaaa0ab46d7, data reload: false

query1	0.06	0.06	0.05
query2	0.09	0.06	0.05
query3	0.26	0.09	0.09
query4	1.61	0.12	0.12
query5	0.28	0.28	0.25
query6	1.19	0.67	0.65
query7	0.03	0.02	0.02
query8	0.06	0.05	0.04
query9	0.63	0.55	0.53
query10	0.58	0.58	0.59
query11	0.17	0.12	0.11
query12	0.16	0.12	0.12
query13	0.65	0.64	0.62
query14	1.06	1.04	1.05
query15	0.89	0.86	0.90
query16	0.42	0.41	0.43
query17	1.10	1.13	1.13
query18	0.22	0.21	0.21
query19	2.09	1.97	1.90
query20	0.02	0.02	0.02
query21	15.41	0.95	0.61
query22	0.77	1.26	0.83
query23	14.75	1.42	0.62
query24	8.09	0.74	0.94
query25	0.48	0.20	0.13
query26	0.63	0.16	0.13
query27	0.07	0.05	0.05
query28	9.60	1.36	0.94
query29	12.56	3.99	3.35
query30	0.29	0.14	0.13
query31	2.84	0.61	0.40
query32	3.25	0.60	0.49
query33	3.07	3.12	3.14
query34	16.14	5.56	4.89
query35	4.97	4.94	4.92
query36	0.71	0.54	0.51
query37	0.11	0.07	0.08
query38	0.06	0.05	0.05
query39	0.04	0.03	0.02
query40	0.18	0.16	0.15
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 105.78 s
Total hot run time: 31.05 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.61% (17874/33977)
Line Coverage 37.82% (162102/428594)
Region Coverage 32.21% (123525/383460)
Branch Coverage 33.65% (54175/160987)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.37% (23774/33310)
Line Coverage 57.71% (247185/428346)
Region Coverage 52.86% (205330/388418)
Branch Coverage 54.59% (88370/161882)

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 20, 2025
@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 16.67% (1/6) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-DS: Total hot run time: 190571 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cc88b82cc711670f599effe161c9f3f1e24f229a, data reload: false

query1	1063	442	427	427
query2	6685	1732	1699	1699
query3	6805	229	226	226
query4	26429	23377	23110	23110
query5	4427	636	476	476
query6	358	247	231	231
query7	4643	497	304	304
query8	349	273	275	273
query9	8730	2608	2614	2608
query10	523	349	286	286
query11	15928	15213	15299	15213
query12	193	120	116	116
query13	1684	551	442	442
query14	12080	9498	9510	9498
query15	215	194	182	182
query16	7723	667	481	481
query17	1546	761	612	612
query18	2076	493	351	351
query19	232	213	192	192
query20	144	128	128	128
query21	212	150	117	117
query22	4750	4739	4549	4549
query23	34685	34178	33689	33689
query24	8518	2533	2563	2533
query25	584	558	465	465
query26	1258	277	171	171
query27	2779	524	385	385
query28	4824	2297	2191	2191
query29	794	650	495	495
query30	310	240	203	203
query31	961	882	804	804
query32	88	71	75	71
query33	590	504	371	371
query34	1646	871	539	539
query35	812	851	851	851
query36	992	1054	944	944
query37	118	113	84	84
query38	3566	3614	3493	3493
query39	1464	1405	1411	1405
query40	215	120	114	114
query41	69	69	63	63
query42	119	107	108	107
query43	478	510	474	474
query44	1355	834	824	824
query45	188	180	167	167
query46	850	1011	633	633
query47	1741	1792	1734	1734
query48	418	423	308	308
query49	785	485	422	422
query50	664	698	425	425
query51	3899	3935	3909	3909
query52	109	104	99	99
query53	234	266	194	194
query54	593	601	534	534
query55	90	81	86	81
query56	306	334	305	305
query57	1183	1195	1136	1136
query58	286	275	274	274
query59	2570	2633	2617	2617
query60	347	346	324	324
query61	162	142	150	142
query62	801	729	685	685
query63	231	196	197	196
query64	4370	1187	831	831
query65	4167	4001	4005	4001
query66	1088	436	330	330
query67	15422	15190	15099	15099
query68	6668	882	594	594
query69	479	328	281	281
query70	1350	1242	1308	1242
query71	406	343	314	314
query72	5750	4800	4791	4791
query73	626	565	353	353
query74	9085	9189	8682	8682
query75	3284	3352	2794	2794
query76	3270	1197	754	754
query77	421	414	319	319
query78	9673	9783	9105	9105
query79	1396	813	602	602
query80	711	622	537	537
query81	495	374	235	235
query82	315	156	138	138
query83	266	262	245	245
query84	250	105	93	93
query85	848	472	411	411
query86	335	300	298	298
query87	3655	3736	3609	3609
query88	2884	2305	2258	2258
query89	401	325	301	301
query90	1783	222	308	222
query91	170	169	134	134
query92	78	68	69	68
query93	1175	1006	645	645
query94	645	432	307	307
query95	401	324	318	318
query96	490	591	293	293
query97	2945	3019	2871	2871
query98	231	215	209	209
query99	1329	1421	1305	1305
Total cold run time: 275339 ms
Total hot run time: 190571 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cc88b82cc711670f599effe161c9f3f1e24f229a, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.06	0.05
query3	0.26	0.08	0.08
query4	1.61	0.13	0.12
query5	0.27	0.26	0.25
query6	1.21	0.66	0.64
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.63	0.54	0.52
query10	0.59	0.59	0.59
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.64	0.66	0.61
query14	1.02	1.05	1.03
query15	0.86	0.88	0.87
query16	0.40	0.40	0.38
query17	1.05	1.03	1.06
query18	0.21	0.20	0.21
query19	1.97	1.89	1.84
query20	0.01	0.02	0.01
query21	15.42	0.91	0.60
query22	0.77	1.24	0.84
query23	14.72	1.28	0.66
query24	7.11	1.20	0.78
query25	0.46	0.28	0.09
query26	0.56	0.16	0.14
query27	0.08	0.06	0.06
query28	9.65	1.37	0.95
query29	12.54	3.96	3.35
query30	0.31	0.14	0.12
query31	2.83	0.61	0.38
query32	3.27	0.57	0.50
query33	3.16	3.10	3.03
query34	16.18	5.48	4.91
query35	4.97	4.95	4.92
query36	0.68	0.51	0.54
query37	0.11	0.08	0.07
query38	0.06	0.04	0.04
query39	0.05	0.03	0.03
query40	0.20	0.15	0.15
query41	0.09	0.05	0.03
query42	0.04	0.04	0.04
query43	0.04	0.04	0.03
Total cold run time: 104.57 s
Total hot run time: 30.8 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.61% (17875/33977)
Line Coverage 37.83% (162139/428594)
Region Coverage 32.28% (123767/383460)
Branch Coverage 33.66% (54185/160987)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.39% (23780/33310)
Line Coverage 57.78% (247512/428346)
Region Coverage 52.91% (205522/388418)
Branch Coverage 54.66% (88482/161882)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 16.67% (1/6) 🎉
Increment coverage report
Complete coverage report

@zzzxl1993
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 30.28 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9391957a680105e6cf0be5dfadc56945ecb1b5e4, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.08
query4	1.61	0.13	0.12
query5	0.29	0.26	0.25
query6	1.17	0.66	0.64
query7	0.04	0.03	0.03
query8	0.06	0.05	0.05
query9	0.64	0.54	0.53
query10	0.59	0.59	0.58
query11	0.16	0.12	0.11
query12	0.16	0.12	0.12
query13	0.64	0.63	0.61
query14	1.06	1.04	1.04
query15	0.87	0.84	0.88
query16	0.40	0.41	0.40
query17	1.08	1.04	1.07
query18	0.22	0.20	0.20
query19	1.90	1.87	1.89
query20	0.01	0.01	0.01
query21	15.40	0.92	0.57
query22	0.76	1.10	0.61
query23	15.12	1.41	0.62
query24	6.93	2.15	0.59
query25	0.50	0.29	0.11
query26	0.57	0.17	0.13
query27	0.08	0.05	0.06
query28	9.63	1.34	0.94
query29	12.56	3.91	3.29
query30	0.29	0.16	0.11
query31	2.84	0.60	0.40
query32	3.24	0.57	0.50
query33	3.12	3.14	3.06
query34	16.02	5.48	4.90
query35	4.95	4.96	4.90
query36	0.70	0.51	0.50
query37	0.10	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.04	0.03
query40	0.19	0.15	0.15
query41	0.09	0.04	0.03
query42	0.04	0.04	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.57 s
Total hot run time: 30.28 s

Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.61% (17874/33977)
Line Coverage 37.83% (162122/428595)
Region Coverage 32.28% (123772/383460)
Branch Coverage 33.66% (54192/160987)

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 22, 2025
@airborne12
Copy link
Member

run check_coverage

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.38% (23776/33310)
Line Coverage 57.76% (247405/428347)
Region Coverage 52.78% (204998/388418)
Branch Coverage 54.51% (88234/161882)

@airborne12 airborne12 merged commit 8f22466 into apache:master Oct 22, 2025
28 of 29 checks passed
zzzxl1993 added a commit to zzzxl1993/doris that referenced this pull request Oct 23, 2025
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 24, 2025
@yiguolei yiguolei mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants