Skip to content

Conversation

@CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Oct 16, 2025

Iceberg and Paimon catalogs access object storage (OSS, OBS, etc.) using Hadoop FileSystem libraries. In environments with multiple storage configurations, the FileSystem cache may cause instances to be shared across configurations, leading to potential conflicts or incorrect access.

This PR disables the Hadoop FileSystem cache (fs.oss.impl.disable.cache=true) for each OSS to ensure configuration isolation and prevent cache overwrites.

If necessary, the cache can also be explicitly enabled for specific catalogs
by setting fs.oss.impl.disable.cache=false.

… object storage catalogs

Iceberg and Paimon catalogs access object storage (OSS, OBS, etc.) using Hadoop FileSystem libraries.
In environments with multiple storage configurations, the FileSystem cache may cause instances
to be shared across configurations, leading to potential conflicts or incorrect access.

This PR disables the Hadoop FileSystem cache (`fs.oss.impl.disable.cache=true`)
for each OSS to ensure configuration isolation and prevent cache overwrites.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

morningman
morningman previously approved these changes Oct 16, 2025
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 16, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@CalvinKirs
Copy link
Member Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 17, 2025
@doris-robot
Copy link

ClickBench: Total hot run time: 30.97 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 02f0f03787bd99cbaac3355cc0564728b9e1085a, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.06	0.05
query3	0.26	0.09	0.09
query4	1.62	0.13	0.12
query5	0.30	0.26	0.25
query6	1.19	0.67	0.65
query7	0.03	0.02	0.03
query8	0.06	0.04	0.05
query9	0.64	0.55	0.54
query10	0.59	0.58	0.57
query11	0.20	0.11	0.11
query12	0.16	0.12	0.12
query13	0.64	0.61	0.61
query14	1.03	1.05	1.04
query15	0.88	0.89	0.87
query16	0.41	0.39	0.40
query17	1.02	1.10	1.07
query18	0.22	0.20	0.21
query19	1.99	1.79	1.87
query20	0.02	0.01	0.02
query21	15.41	0.94	0.57
query22	0.77	1.15	0.70
query23	14.91	1.44	0.64
query24	7.00	1.60	1.07
query25	0.48	0.27	0.09
query26	0.59	0.16	0.16
query27	0.07	0.06	0.05
query28	9.62	1.36	0.94
query29	12.59	4.08	3.37
query30	0.31	0.15	0.11
query31	2.83	0.59	0.40
query32	3.24	0.56	0.47
query33	3.09	3.14	3.13
query34	16.23	5.44	4.87
query35	4.98	4.97	4.91
query36	0.70	0.53	0.51
query37	0.11	0.08	0.07
query38	0.07	0.05	0.05
query39	0.04	0.03	0.03
query40	0.20	0.15	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.04
query43	0.05	0.05	0.04
Total cold run time: 104.83 s
Total hot run time: 30.97 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (19/19) 🎉
Increment coverage report
Complete coverage report

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2025
@CalvinKirs CalvinKirs merged commit 017f9e4 into apache:master Oct 20, 2025
26 checks passed
@CalvinKirs CalvinKirs deleted the master-disable-cache branch October 20, 2025 07:44
github-actions bot pushed a commit that referenced this pull request Oct 20, 2025
…object storage catalogs (#57063)

… 

Iceberg and Paimon catalogs access object storage (OSS, OBS, etc.) using
Hadoop FileSystem libraries. In environments with multiple storage
configurations, the FileSystem cache may cause instances to be shared
across configurations, leading to potential conflicts or incorrect
access.

This PR disables the Hadoop FileSystem cache
(`fs.oss.impl.disable.cache=true`) for each OSS to ensure configuration
isolation and prevent cache overwrites.

If necessary, the cache can also be explicitly enabled for specific
catalogs
by setting `fs.oss.impl.disable.cache=false`.
github-actions bot pushed a commit that referenced this pull request Oct 20, 2025
…object storage catalogs (#57063)

… 

Iceberg and Paimon catalogs access object storage (OSS, OBS, etc.) using
Hadoop FileSystem libraries. In environments with multiple storage
configurations, the FileSystem cache may cause instances to be shared
across configurations, leading to potential conflicts or incorrect
access.

This PR disables the Hadoop FileSystem cache
(`fs.oss.impl.disable.cache=true`) for each OSS to ensure configuration
isolation and prevent cache overwrites.

If necessary, the cache can also be explicitly enabled for specific
catalogs
by setting `fs.oss.impl.disable.cache=false`.
morrySnow pushed a commit that referenced this pull request Oct 21, 2025
…onfigurationobject storage catalogs #57063 (#57153)

Cherry-picked from #57063

Co-authored-by: Calvin Kirs <guoqiang@selectdb.com>
yiguolei pushed a commit that referenced this pull request Oct 23, 2025
…onfigurationobject storage catalogs #57063 (#57154)

Cherry-picked from #57063

Co-authored-by: Calvin Kirs <guoqiang@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.2-merged dev/4.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants