[fix](inverted index) fix is null predicate for inverted index evaluate #56964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the evaluation of IS NULL predicates when using inverted indexes. The issue was that IS NULL queries were returning incorrect results (0 rows) when relying on inverted index evaluation instead of the expected non-zero counts.
- Corrected the logic in
FunctionIsNull::evaluate_inverted_indexto properly handle null bitmaps - Added comprehensive regression tests to verify IS NULL and NOT (IS NOT NULL) queries work correctly with inverted indexes
- Ensured consistent results between inverted index enabled and disabled modes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| be/src/vec/functions/is_null.h | Fixed the inverted index evaluation logic for IS NULL predicates by correcting bitmap handling |
| regression-test/suites/inverted_index_p0/test_inverted_is_null.groovy | Added comprehensive test coverage for IS NULL queries with inverted indexes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // null_bitmap is null bitmap | ||
| bitmap_result = segment_v2::InvertedIndexResultBitmap(null_bitmap, null_bitmap); | ||
| } | ||
| if (!index_iter->has_null()) { |
There was a problem hiding this comment.
When the index has no nulls, the function returns OK without setting bitmap_result, but the caller expects a valid bitmap. This could lead to undefined behavior when bitmap_result is accessed later.
Suggested change
| if (!index_iter->has_null()) { | |
| if (!index_iter->has_null()) { | |
| auto empty_bitmap = std::make_shared<roaring::Roaring>(); | |
| bitmap_result = segment_v2::InvertedIndexResultBitmap(empty_bitmap, empty_bitmap); |
| segment_v2::InvertedIndexQueryCacheHandle null_bitmap_cache_handle; | ||
| RETURN_IF_ERROR(index_iter->read_null_bitmap(&null_bitmap_cache_handle)); | ||
| std::shared_ptr<roaring::Roaring> null_bitmap = null_bitmap_cache_handle.get_bitmap(); | ||
| if (!null_bitmap) { |
There was a problem hiding this comment.
Similar to the previous issue, returning OK without setting bitmap_result when null_bitmap is null could cause problems for the caller expecting a valid bitmap result.
Suggested change
| if (!null_bitmap) { | |
| if (!null_bitmap) { | |
| // Set bitmap_result to an empty result if null_bitmap is null | |
| auto empty_bitmap = std::make_shared<roaring::Roaring>(); | |
| bitmap_result = segment_v2::InvertedIndexResultBitmap(empty_bitmap, empty_bitmap); |
Contributor
|
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 30.08 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Member
Author
|
run buildall |
TPC-DS: Total hot run time: 189941 ms |
ClickBench: Total hot run time: 30.68 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by at least one committer and no changes requested. |
Closed
airborne12
added a commit
to airborne12/apache-doris
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #50748 #56139
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)