Skip to content

[feature](function) support json_hash function #56962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gabriel39 merged 2 commits into from
Oct 17, 2025
Merged

[feature](function) support json_hash function #56962

Gabriel39 merged 2 commits into from
Oct 17, 2025

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Oct 14, 2025 •
edited
Loading

What problem does this PR solve?

apache/doris-website#2974

mysql> select json_hash(cast('{"a":123, "b":456}' as json)) , json_hash(cast('{"b":456, "a":123}' as json));
+-----------------------------------------------+-----------------------------------------------+
| json_hash(cast('{"a":123, "b":456}' as json)) | json_hash(cast('{"b":456, "a":123}' as json)) |
+-----------------------------------------------+-----------------------------------------------+
|                             82454694884268544 |                             82454694884268544 |
+-----------------------------------------------+-----------------------------------------------+

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Oct 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Oct 14, 2025

run buildall

@Mryange
Copy link
Contributor Author

Mryange commented Oct 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 14, 2025

TPC-DS: Total hot run time: 190909 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 56e143ac6ad4a2b3d452f3b8064177f8ff91389d, data reload: false

query1	1033	456	411	411
query2	6582	1725	1694	1694
query3	6753	224	229	224
query4	26779	23631	23344	23344
query5	4434	658	490	490
query6	337	240	217	217
query7	4649	498	298	298
query8	293	259	236	236
query9	8653	2565	2593	2565
query10	487	333	296	296
query11	15303	15150	14947	14947
query12	175	120	115	115
query13	1689	565	437	437
query14	10442	9206	9235	9206
query15	213	194	176	176
query16	7158	675	536	536
query17	1023	759	611	611
query18	1983	427	336	336
query19	238	200	182	182
query20	135	127	132	127
query21	219	140	129	129
query22	4832	5018	4617	4617
query23	34971	33972	34025	33972
query24	8474	2523	2524	2523
query25	692	572	452	452
query26	1329	295	162	162
query27	3003	507	370	370
query28	4621	2283	2207	2207
query29	884	643	505	505
query30	346	257	216	216
query31	1012	868	760	760
query32	91	75	75	75
query33	611	405	343	343
query34	848	907	544	544
query35	871	854	790	790
query36	1016	1064	947	947
query37	128	115	90	90
query38	3774	3757	3601	3601
query39	1473	1423	1414	1414
query40	234	138	119	119
query41	64	58	61	58
query42	123	123	113	113
query43	491	513	477	477
query44	1335	838	832	832
query45	187	177	188	177
query46	861	1004	638	638
query47	1791	1840	1786	1786
query48	382	435	310	310
query49	786	560	415	415
query50	639	705	413	413
query51	3899	3948	3888	3888
query52	121	114	97	97
query53	239	260	205	205
query54	608	589	528	528
query55	90	84	83	83
query56	351	336	305	305
query57	1192	1186	1137	1137
query58	288	275	286	275
query59	2632	2695	2497	2497
query60	356	344	324	324
query61	160	161	159	159
query62	793	735	676	676
query63	238	208	203	203
query64	4646	1260	916	916
query65	4062	4032	3979	3979
query66	1185	439	344	344
query67	15795	15586	15189	15189
query68	7923	946	601	601
query69	496	327	304	304
query70	1361	1299	1332	1299
query71	590	335	317	317
query72	5996	4943	4910	4910
query73	668	578	363	363
query74	9249	8843	8786	8786
query75	3945	3445	2830	2830
query76	3652	1172	753	753
query77	811	397	296	296
query78	9648	9688	9035	9035
query79	4919	804	576	576
query80	700	562	523	523
query81	491	256	225	225
query82	654	154	130	130
query83	302	262	248	248
query84	306	181	93	93
query85	893	474	434	434
query86	356	336	303	303
query87	3812	3738	3703	3703
query88	3411	2242	2231	2231
query89	459	329	290	290
query90	2002	208	216	208
query91	161	160	141	141
query92	84	67	62	62
query93	2785	1002	641	641
query94	705	443	334	334
query95	403	323	305	305
query96	482	569	288	288
query97	2957	2997	2885	2885
query98	242	212	221	212
query99	1449	1410	1275	1275
Total cold run time: 283014 ms
Total hot run time: 190909 ms

@doris-robot
Copy link

doris-robot commented Oct 14, 2025

ClickBench: Total hot run time: 29.97 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 56e143ac6ad4a2b3d452f3b8064177f8ff91389d, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.06
query3	0.24	0.08	0.08
query4	1.62	0.12	0.12
query5	0.29	0.27	0.26
query6	1.15	0.65	0.64
query7	0.04	0.03	0.03
query8	0.07	0.05	0.05
query9	0.62	0.53	0.52
query10	0.57	0.59	0.57
query11	0.19	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.62	0.63
query14	1.05	1.02	1.02
query15	0.90	0.86	0.89
query16	0.40	0.39	0.41
query17	1.10	1.03	1.03
query18	0.21	0.20	0.19
query19	1.97	1.86	1.85
query20	0.01	0.01	0.01
query21	15.43	0.91	0.58
query22	0.79	1.22	0.66
query23	14.88	1.37	0.63
query24	7.11	2.08	0.40
query25	0.48	0.20	0.06
query26	0.52	0.17	0.14
query27	0.07	0.05	0.06
query28	9.24	1.35	0.95
query29	12.64	3.98	3.28
query30	0.29	0.15	0.11
query31	2.83	0.59	0.39
query32	3.24	0.58	0.47
query33	3.13	3.05	3.13
query34	16.20	5.47	4.85
query35	4.94	4.87	4.99
query36	0.70	0.51	0.51
query37	0.10	0.08	0.08
query38	0.07	0.05	0.05
query39	0.04	0.03	0.02
query40	0.18	0.14	0.15
query41	0.09	0.04	0.04
query42	0.04	0.04	0.04
query43	0.05	0.04	0.03
Total cold run time: 104.41 s
Total hot run time: 29.97 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

BE UT Coverage Report

Increment line coverage 10.45% (7/67) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.54% (17758/33800)
Line Coverage 37.75% (161482/427822)
Region Coverage 32.20% (123199/382618)
Branch Coverage 33.63% (54133/160947)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (67/67) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.18% (23586/33135)
Line Coverage 57.60% (246283/427568)
Region Coverage 52.56% (203707/387568)
Branch Coverage 54.46% (88143/161836)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

FE Regression Coverage Report

Increment line coverage 92.31% (12/13) 🎉
Increment coverage report
Complete coverage report

mrhhsg
mrhhsg approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 19cf4c4 into apache:master Oct 17, 2025
27 of 28 checks passed
@yiguolei yiguolei added usercase Important user case type label dev/4.0.x labels Oct 23, 2025
github-actions bot pushed a commit that referenced this pull request Oct 23, 2025
@Mryange
[feature](function) support json_hash function (#56962)
dd15c6c 
apache/doris-website#2974
```sql
mysql> select json_hash(cast('{"a":123, "b":456}' as json)) , json_hash(cast('{"b":456, "a":123}' as json));
+-----------------------------------------------+-----------------------------------------------+
| json_hash(cast('{"a":123, "b":456}' as json)) | json_hash(cast('{"b":456, "a":123}' as json)) |
+-----------------------------------------------+-----------------------------------------------+
|                             82454694884268544 |                             82454694884268544 |
+-----------------------------------------------+-----------------------------------------------+
```
@github-actions github-actions bot mentioned this pull request Oct 23, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 23, 2025
@github-actions @Mryange
branch-4.0: [feature](function) support json_hash function #56962 (#5…
1d35aa5 
…7254)

Cherry-picked from #56962

Co-authored-by: Mryange <yanxuecheng@selectdb.com>
@yiguolei yiguolei mentioned this pull request Nov 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrhhsg mrhhsg mrhhsg approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Mryange @Thearas @doris-robot @hello-stephen @mrhhsg @Gabriel39 @yiguolei