Skip to content

[fix](nereids)forbid create sync mv based on annother sync mv #56912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 1 commit into from
Oct 14, 2025
Merged

[fix](nereids)forbid create sync mv based on annother sync mv #56912

starocean999 merged 1 commit into from
Oct 14, 2025

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Oct 13, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

starocean999 commented Oct 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-DS: Total hot run time: 190059 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bb42a17c46a28f0c39bcacdf0c552189dfee1120, data reload: false

query1	1063	438	403	403
query2	6568	1700	1704	1700
query3	6759	223	215	215
query4	26673	23709	23158	23158
query5	5588	642	483	483
query6	333	248	242	242
query7	4676	484	285	285
query8	313	257	273	257
query9	8703	2527	2549	2527
query10	542	326	282	282
query11	15405	15094	15552	15094
query12	224	133	125	125
query13	1730	611	479	479
query14	11506	9592	9614	9592
query15	248	228	198	198
query16	8975	737	538	538
query17	1795	817	655	655
query18	2067	439	350	350
query19	304	217	174	174
query20	157	132	137	132
query21	220	134	118	118
query22	4472	4663	4484	4484
query23	35008	33567	34118	33567
query24	8474	2380	2417	2380
query25	578	524	477	477
query26	1225	271	158	158
query27	2703	501	349	349
query28	4362	2189	2151	2151
query29	793	616	495	495
query30	297	231	198	198
query31	879	811	786	786
query32	85	76	68	68
query33	651	368	318	318
query34	779	842	529	529
query35	798	835	765	765
query36	995	1025	948	948
query37	128	113	84	84
query38	3519	3508	3446	3446
query39	1489	1394	1417	1394
query40	222	125	116	116
query41	72	57	65	57
query42	126	109	106	106
query43	490	488	484	484
query44	1306	829	826	826
query45	188	191	178	178
query46	830	994	634	634
query47	1742	1799	1742	1742
query48	391	426	322	322
query49	771	505	405	405
query50	630	689	396	396
query51	3876	3825	3863	3825
query52	110	108	102	102
query53	245	266	190	190
query54	601	601	527	527
query55	88	83	90	83
query56	327	330	317	317
query57	1180	1232	1124	1124
query58	275	276	287	276
query59	2518	2785	2578	2578
query60	341	327	334	327
query61	165	171	159	159
query62	797	715	681	681
query63	261	194	189	189
query64	4395	1162	841	841
query65	4073	4019	3998	3998
query66	1056	445	330	330
query67	15364	15192	14946	14946
query68	9328	938	601	601
query69	535	323	287	287
query70	1389	1363	1351	1351
query71	524	334	327	327
query72	5956	4872	4864	4864
query73	694	566	361	361
query74	8961	8754	8913	8754
query75	4619	3347	2847	2847
query76	3828	1175	738	738
query77	899	401	318	318
query78	9592	9753	8893	8893
query79	2234	842	608	608
query80	701	579	555	555
query81	496	270	229	229
query82	421	160	139	139
query83	304	287	244	244
query84	309	114	93	93
query85	897	482	473	473
query86	348	316	295	295
query87	3770	3796	3724	3724
query88	3349	2293	2249	2249
query89	398	331	308	308
query90	2052	227	223	223
query91	158	197	133	133
query92	81	68	68	68
query93	1181	1002	653	653
query94	692	442	325	325
query95	404	325	314	314
query96	481	596	285	285
query97	2956	3014	2927	2927
query98	249	220	212	212
query99	1444	1427	1298	1298
Total cold run time: 282774 ms
Total hot run time: 190059 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

ClickBench: Total hot run time: 29.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bb42a17c46a28f0c39bcacdf0c552189dfee1120, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.08
query4	1.60	0.11	0.11
query5	0.29	0.27	0.25
query6	1.15	0.65	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.64	0.53	0.53
query10	0.58	0.58	0.57
query11	0.17	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.62	0.62
query14	1.04	1.03	1.03
query15	0.88	0.85	0.88
query16	0.40	0.41	0.40
query17	1.03	1.06	1.05
query18	0.22	0.19	0.21
query19	1.89	1.86	1.84
query20	0.02	0.02	0.01
query21	15.43	0.96	0.57
query22	0.75	1.27	0.70
query23	14.87	1.41	0.57
query24	6.85	2.20	0.34
query25	0.30	0.17	0.11
query26	0.60	0.17	0.13
query27	0.07	0.06	0.06
query28	9.52	1.36	0.95
query29	12.55	3.95	3.24
query30	0.30	0.13	0.11
query31	2.83	0.59	0.40
query32	3.28	0.56	0.49
query33	3.06	3.06	3.20
query34	16.18	5.46	4.83
query35	4.94	4.97	4.84
query36	0.69	0.53	0.52
query37	0.10	0.08	0.07
query38	0.07	0.05	0.05
query39	0.04	0.03	0.03
query40	0.18	0.15	0.14
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 103.95 s
Total hot run time: 29.88 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@starocean999 starocean999 marked this pull request as ready for review October 14, 2025 07:40
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 483cd1c into apache:master Oct 14, 2025
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 14, 2025
@starocean999
[fix](nereids)forbid create sync mv based on annother sync mv (#56912)
4d2b2f6
@github-actions github-actions bot mentioned this pull request Oct 14, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 18, 2025
@github-actions @starocean999
branch-4.0: [fix](nereids)forbid create sync mv based on annother syn…
8fa9677 
…c mv #56912 (#56957)

Cherry-picked from #56912

Co-authored-by: starocean999 <lichi@selectdb.com>
@yiguolei yiguolei mentioned this pull request Nov 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@starocean999 @hello-stephen @doris-robot @englefly @morrySnow @yiguolei