[fix](iceberg) fix logic of getting namespaces #56874

morningman · 2025-10-11T16:31:43Z

What problem does this PR solve?

Followup #56415

Problem Summary:

The previous getNamespace logic is wrong, we should split the dbName by . to create namespaces.

Allow not specify oauth.uri of iceberg rest catalog, to follow the new spec of IRC

So we can connect Snowflake open catalog like this:

CREATE CATALOG ice PROPERTIES (
    'type' = 'iceberg',
    'warehouse' = 'yy_external_catalog3',
    'iceberg.catalog.type' = 'rest',
    'iceberg.rest.uri' = 'https://xxx.snowflakecomputing.com/polaris/api/catalog',
    'iceberg.rest.security.type' = 'oauth2',
    'iceberg.rest.oauth2.credential' = 'id:secrete,
    'iceberg.rest.oauth2.scope' = 'PRINCIPAL_ROLE:yy_sn_principal_role',
    'iceberg.rest.nested-namespace-enabled' = 'true',
    's3.endpoint' = 'https://s3.us-west-2.amazonaws.com',
    's3.region' = 'us-west-2',
    'iceberg.rest.nested-namespace-enabled' = 'true'
);

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-10-11T16:31:48Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

morningman · 2025-10-12T03:13:04Z

run buildall

doris-robot · 2025-10-12T04:00:44Z

ClickBench: Total hot run time: 30.54 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 288a734f90c529753e30297def9d1839e3def750, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.06
query3	0.25	0.08	0.08
query4	1.60	0.12	0.11
query5	0.27	0.27	0.25
query6	1.17	0.66	0.64
query7	0.04	0.03	0.03
query8	0.06	0.05	0.05
query9	0.62	0.54	0.52
query10	0.60	0.59	0.58
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.61	0.63
query14	1.03	1.05	1.02
query15	0.90	0.84	0.86
query16	0.40	0.39	0.40
query17	1.04	1.05	1.05
query18	0.21	0.20	0.20
query19	1.99	1.83	1.86
query20	0.02	0.02	0.01
query21	15.43	0.92	0.56
query22	0.78	1.21	0.73
query23	14.81	1.38	0.64
query24	6.76	0.87	1.09
query25	0.46	0.23	0.07
query26	0.59	0.17	0.13
query27	0.07	0.05	0.06
query28	10.20	1.40	0.92
query29	12.58	4.03	3.38
query30	0.28	0.13	0.11
query31	2.83	0.61	0.39
query32	3.23	0.57	0.48
query33	3.09	3.24	3.04
query34	16.17	5.44	4.81
query35	4.94	4.93	4.94
query36	0.71	0.52	0.50
query37	0.10	0.08	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.17	0.16
query41	0.08	0.03	0.04
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 104.77 s
Total hot run time: 30.54 s

hello-stephen · 2025-10-12T04:32:14Z

FE UT Coverage Report

Increment line coverage 76.92% (10/13) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2025-10-12T06:15:51Z

FE Regression Coverage Report

Increment line coverage 7.69% (1/13) 🎉
Increment coverage report
Complete coverage report

github-actions · 2025-10-15T15:10:17Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-10-15T15:10:20Z

PR approved by anyone and no changes requested.

### What problem does this PR solve? Followup #56415 Problem Summary: 1. The previous `getNamespace` logic is wrong, we should split the `dbName` by `.` to create namespaces. 2. Allow not specify `oauth.uri` of iceberg rest catalog, to follow the new spec of IRC So we can connect Snowflake open catalog like this: ``` CREATE CATALOG ice PROPERTIES ( 'type' = 'iceberg', 'warehouse' = 'yy_external_catalog3', 'iceberg.catalog.type' = 'rest', 'iceberg.rest.uri' = 'https://xxx.snowflakecomputing.com/polaris/api/catalog', 'iceberg.rest.security.type' = 'oauth2', 'iceberg.rest.oauth2.credential' = 'id:secrete, 'iceberg.rest.oauth2.scope' = 'PRINCIPAL_ROLE:yy_sn_principal_role', 'iceberg.rest.nested-namespace-enabled' = 'true', 's3.endpoint' = 'https://s3.us-west-2.amazonaws.com', 's3.region' = 'us-west-2', 'iceberg.rest.nested-namespace-enabled' = 'true' ); ```

Followup apache#56415 Problem Summary: 1. The previous `getNamespace` logic is wrong, we should split the `dbName` by `.` to create namespaces. 2. Allow not specify `oauth.uri` of iceberg rest catalog, to follow the new spec of IRC So we can connect Snowflake open catalog like this: ``` CREATE CATALOG ice PROPERTIES ( 'type' = 'iceberg', 'warehouse' = 'yy_external_catalog3', 'iceberg.catalog.type' = 'rest', 'iceberg.rest.uri' = 'https://xxx.snowflakecomputing.com/polaris/api/catalog', 'iceberg.rest.security.type' = 'oauth2', 'iceberg.rest.oauth2.credential' = 'id:secrete, 'iceberg.rest.oauth2.scope' = 'PRINCIPAL_ROLE:yy_sn_principal_role', 'iceberg.rest.nested-namespace-enabled' = 'true', 's3.endpoint' = 'https://s3.us-west-2.amazonaws.com', 's3.region' = 'us-west-2', 'iceberg.rest.nested-namespace-enabled' = 'true' ); ```

…7021) Cherry-picked from #56874 Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>

…#56874 (#57035) bp #56415 #56874

morningman added 2 commits October 12, 2025 00:07

support nested

f9097df

[fix](iceberg) fix logic of getting namespaces

468665c

morningman added dev/3.1.x dev/4.0.x labels Oct 11, 2025

2

288a734

morningman mentioned this pull request Oct 15, 2025

[fix](iceberg catalog) Remove the mandatory check of iceberg oauth2-server-uri #56851

Closed

16 tasks

zy-kkk approved these changes Oct 15, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 15, 2025

github-actions bot added the reviewed label Oct 15, 2025

hubgeter approved these changes Oct 16, 2025

View reviewed changes

morningman merged commit ce665f7 into apache:master Oct 16, 2025
28 of 29 checks passed

github-actions bot added the dev/3.1.x-conflict label Oct 16, 2025

github-actions bot mentioned this pull request Oct 16, 2025

branch-4.0: [fix](iceberg) fix logic of getting namespaces #56874 #57021

Merged

morningman mentioned this pull request Oct 16, 2025

branch-3.1: [opt](catalog) support nested namespaces of iceberg #56415 #56874 #57035

Merged

yiguolei pushed a commit that referenced this pull request Oct 16, 2025

branch-4.0: [fix](iceberg) fix logic of getting namespaces #56874 (#5…

32369a9

…7021) Cherry-picked from #56874 Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>

yiguolei added dev/4.0.1-merged and removed dev/4.0.x labels Oct 16, 2025

morningman added a commit that referenced this pull request Oct 16, 2025

branch-3.1: [opt](catalog) support nested namespaces of iceberg #56415 …

545394e

…#56874 (#57035) bp #56415 #56874

morningman added dev/3.1.2-merged and removed dev/3.1.x dev/3.1.x-conflict labels Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[fix](iceberg) fix logic of getting namespaces #56874

[fix](iceberg) fix logic of getting namespaces #56874

Uh oh!

morningman commented Oct 11, 2025 •

edited

Loading

Uh oh!

hello-stephen commented Oct 11, 2025

Uh oh!

morningman commented Oct 12, 2025

Uh oh!

doris-robot commented Oct 12, 2025

Uh oh!

hello-stephen commented Oct 12, 2025

Uh oh!

hello-stephen commented Oct 12, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[fix](iceberg) fix logic of getting namespaces #56874

[fix](iceberg) fix logic of getting namespaces #56874

Uh oh!

Conversation

morningman commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Oct 11, 2025

Uh oh!

morningman commented Oct 12, 2025

Uh oh!

doris-robot commented Oct 12, 2025

Uh oh!

hello-stephen commented Oct 12, 2025

FE UT Coverage Report

Uh oh!

hello-stephen commented Oct 12, 2025

FE Regression Coverage Report

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

morningman commented Oct 11, 2025 •

edited

Loading