Skip to content

[Feature](varbinary) add length, from_base64_binary, to_base64_bianry, sub_binary for VarBinary type #56648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zclllyybb merged 19 commits into from
Oct 21, 2025
Merged

[Feature](varbinary) add length, from_base64_binary, to_base64_bianry, sub_binary for VarBinary type #56648

zclllyybb merged 19 commits into from
Oct 21, 2025

Conversation

@wumeibanfa
Copy link
Contributor

@wumeibanfa wumeibanfa commented Sep 29, 2025 •
edited
Loading

What problem does this PR solve?

add some functions for varbinary

length(varbinary) -> int
from_base64_binary(string) -> varbinary
to_base64_bianry(varbinary) -> string
sub_binary(varbinary, <pos> [, <len>]) ->varbinary

Issue Number: #56426

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 29, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wumeibanfa
Copy link
Contributor Author

wumeibanfa commented Sep 29, 2025

run buildall

@wumeibanfa
Copy link
Contributor Author

wumeibanfa commented Sep 29, 2025

run buildall

@wumeibanfa
Copy link
Contributor Author

wumeibanfa commented Sep 29, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 29, 2025

TPC-DS: Total hot run time: 190979 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5e2bb9f9ae174a83d872a1764b517be5f5cf828b, data reload: false

query1	1050	421	397	397
query2	6573	1660	1671	1660
query3	6751	218	218	218
query4	26115	23846	23132	23132
query5	5488	654	507	507
query6	331	267	206	206
query7	4654	482	293	293
query8	300	273	256	256
query9	8667	2539	2598	2539
query10	523	335	267	267
query11	15745	15084	14888	14888
query12	185	117	117	117
query13	1684	574	440	440
query14	11824	9372	9450	9372
query15	209	206	178	178
query16	7725	683	515	515
query17	2381	832	679	679
query18	2104	496	396	396
query19	279	242	186	186
query20	159	132	154	132
query21	344	145	129	129
query22	4807	5196	5124	5124
query23	34785	34155	34123	34123
query24	8303	2504	2443	2443
query25	640	540	445	445
query26	1242	312	157	157
query27	2827	537	370	370
query28	4429	2276	2228	2228
query29	822	642	521	521
query30	304	231	206	206
query31	959	860	751	751
query32	81	75	67	67
query33	591	399	336	336
query34	808	874	513	513
query35	806	833	754	754
query36	974	1007	934	934
query37	122	114	87	87
query38	3562	3518	3490	3490
query39	1482	1401	1386	1386
query40	225	127	113	113
query41	59	56	55	55
query42	122	103	112	103
query43	491	501	459	459
query44	1323	813	837	813
query45	185	177	167	167
query46	838	993	643	643
query47	1761	1792	1760	1760
query48	384	443	329	329
query49	770	496	386	386
query50	666	684	407	407
query51	3866	3916	3911	3911
query52	113	107	104	104
query53	228	263	197	197
query54	589	580	544	544
query55	93	79	85	79
query56	319	324	288	288
query57	1159	1202	1110	1110
query58	283	277	280	277
query59	2611	2620	2637	2620
query60	364	340	329	329
query61	170	152	153	152
query62	815	720	664	664
query63	237	192	190	190
query64	4411	1160	857	857
query65	4060	3979	3967	3967
query66	1063	427	328	328
query67	15608	15198	15236	15198
query68	9487	935	592	592
query69	493	311	289	289
query70	1419	1319	1290	1290
query71	519	342	381	342
query72	5922	4841	4790	4790
query73	700	585	357	357
query74	8947	9157	8638	8638
query75	4533	3369	2879	2879
query76	3999	1161	749	749
query77	1032	411	326	326
query78	9550	9785	8980	8980
query79	3294	825	574	574
query80	695	583	519	519
query81	502	261	223	223
query82	441	159	135	135
query83	285	269	252	252
query84	301	106	99	99
query85	888	467	471	467
query86	343	325	285	285
query87	3876	3748	3869	3748
query88	2933	2260	2237	2237
query89	431	329	301	301
query90	2064	227	230	227
query91	173	167	130	130
query92	85	66	60	60
query93	2445	993	632	632
query94	706	455	342	342
query95	397	327	319	319
query96	495	583	290	290
query97	2975	2993	2904	2904
query98	227	216	213	213
query99	1458	1419	1298	1298
Total cold run time: 285063 ms
Total hot run time: 190979 ms

@doris-robot
Copy link

doris-robot commented Sep 29, 2025

ClickBench: Total hot run time: 30.78 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5e2bb9f9ae174a83d872a1764b517be5f5cf828b, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.06
query3	0.25	0.08	0.08
query4	1.60	0.12	0.11
query5	0.27	0.27	0.25
query6	1.20	0.64	0.65
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.64	0.53	0.53
query10	0.57	0.60	0.57
query11	0.17	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.62	0.62
query14	1.02	1.05	1.06
query15	0.86	0.85	0.87
query16	0.40	0.41	0.40
query17	1.05	1.08	1.06
query18	0.21	0.20	0.20
query19	1.94	1.88	1.86
query20	0.01	0.01	0.02
query21	15.43	0.92	0.59
query22	0.78	1.34	0.72
query23	14.76	1.38	0.63
query24	6.81	1.33	1.08
query25	0.51	0.31	0.07
query26	0.54	0.16	0.13
query27	0.06	0.05	0.06
query28	9.86	1.38	0.93
query29	12.58	3.99	3.26
query30	0.28	0.13	0.11
query31	2.83	0.62	0.39
query32	3.26	0.55	0.48
query33	3.04	3.07	3.13
query34	16.16	5.51	4.84
query35	4.95	4.90	4.94
query36	0.68	0.53	0.51
query37	0.11	0.08	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.19	0.16	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 104.31 s
Total hot run time: 30.78 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 29, 2025

FE UT Coverage Report

Increment line coverage 11.11% (5/45) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 29, 2025

FE Regression Coverage Report

Increment line coverage 26.67% (12/45) 🎉
Increment coverage report
Complete coverage report

@wumeibanfa
Copy link
Contributor Author

wumeibanfa commented Sep 29, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 29, 2025

TPC-DS: Total hot run time: 190257 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5583590f26772fa45564ebc1963718232bef7816, data reload: false

query1	1048	432	405	405
query2	6585	1729	1708	1708
query3	6759	224	218	218
query4	26264	23744	23069	23069
query5	5073	644	489	489
query6	330	237	228	228
query7	4653	516	317	317
query8	320	260	239	239
query9	8738	2560	2543	2543
query10	534	334	276	276
query11	15373	15111	14787	14787
query12	170	123	115	115
query13	1664	549	448	448
query14	11403	9372	9350	9350
query15	207	188	177	177
query16	7658	696	515	515
query17	1272	737	610	610
query18	2032	419	336	336
query19	242	235	196	196
query20	144	138	136	136
query21	216	131	127	127
query22	4563	4864	4573	4573
query23	34645	34646	33947	33947
query24	8595	2507	2542	2507
query25	601	537	478	478
query26	1299	282	166	166
query27	2868	515	364	364
query28	4748	2238	2194	2194
query29	859	694	541	541
query30	402	241	217	217
query31	950	870	787	787
query32	86	78	81	78
query33	611	401	386	386
query34	841	897	552	552
query35	841	867	752	752
query36	1011	996	944	944
query37	122	114	90	90
query38	3566	3579	3467	3467
query39	1511	1398	1404	1398
query40	223	126	122	122
query41	62	59	58	58
query42	123	108	114	108
query43	482	492	474	474
query44	1345	826	839	826
query45	187	175	170	170
query46	839	990	639	639
query47	1747	1806	1737	1737
query48	395	416	322	322
query49	798	512	433	433
query50	643	696	407	407
query51	3931	3958	3864	3864
query52	111	108	95	95
query53	239	271	198	198
query54	602	587	524	524
query55	92	96	86	86
query56	335	341	309	309
query57	1196	1179	1107	1107
query58	292	271	279	271
query59	2536	2641	2510	2510
query60	348	352	360	352
query61	160	159	158	158
query62	798	742	653	653
query63	230	196	194	194
query64	4503	1260	955	955
query65	4122	3977	3972	3972
query66	1096	525	333	333
query67	15567	15180	15362	15180
query68	8610	966	600	600
query69	485	322	293	293
query70	1392	1333	1277	1277
query71	509	332	319	319
query72	5409	4833	4863	4833
query73	705	573	359	359
query74	9128	9057	8724	8724
query75	4203	3418	2875	2875
query76	3768	1166	766	766
query77	830	397	310	310
query78	9578	9937	8928	8928
query79	1197	859	593	593
query80	640	592	496	496
query81	561	262	227	227
query82	215	157	127	127
query83	271	277	252	252
query84	267	108	101	101
query85	856	488	431	431
query86	374	333	316	316
query87	3797	3808	3741	3741
query88	2818	2261	2218	2218
query89	389	329	294	294
query90	2140	224	222	222
query91	173	161	134	134
query92	80	69	63	63
query93	1053	1002	651	651
query94	692	445	343	343
query95	410	330	323	323
query96	489	581	282	282
query97	2907	2983	2885	2885
query98	232	215	207	207
query99	1433	1430	1280	1280
Total cold run time: 277417 ms
Total hot run time: 190257 ms

@doris-robot
Copy link

doris-robot commented Sep 29, 2025

ClickBench: Total hot run time: 30.64 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5583590f26772fa45564ebc1963718232bef7816, data reload: false

query1	0.06	0.04	0.05
query2	0.09	0.05	0.06
query3	0.26	0.08	0.09
query4	1.61	0.12	0.12
query5	0.28	0.26	0.25
query6	1.16	0.67	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.62	0.52	0.52
query10	0.59	0.59	0.59
query11	0.17	0.12	0.11
query12	0.15	0.12	0.12
query13	0.63	0.63	0.63
query14	1.02	1.05	1.04
query15	0.88	0.85	0.86
query16	0.40	0.40	0.41
query17	1.04	1.06	1.06
query18	0.22	0.20	0.20
query19	1.93	1.85	1.83
query20	0.02	0.01	0.01
query21	15.43	0.96	0.56
query22	0.75	1.21	0.72
query23	14.84	1.39	0.64
query24	6.74	1.80	0.96
query25	0.50	0.19	0.13
query26	0.54	0.16	0.13
query27	0.07	0.06	0.06
query28	9.99	1.34	0.93
query29	12.55	3.94	3.23
query30	0.27	0.12	0.12
query31	2.83	0.58	0.39
query32	3.25	0.56	0.49
query33	3.14	3.06	3.09
query34	16.18	5.51	4.81
query35	4.89	4.92	4.93
query36	0.71	0.51	0.52
query37	0.10	0.08	0.08
query38	0.06	0.05	0.04
query39	0.04	0.02	0.03
query40	0.18	0.15	0.16
query41	0.08	0.04	0.02
query42	0.04	0.03	0.02
query43	0.05	0.04	0.03
Total cold run time: 104.45 s
Total hot run time: 30.64 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 29, 2025

FE UT Coverage Report

Increment line coverage 11.11% (5/45) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 29, 2025

BE UT Coverage Report

Increment line coverage 93.10% (189/203) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.47% (17674/33683)
Line Coverage 37.67% (160495/426073)
Region Coverage 32.15% (122348/380562)
Branch Coverage 33.54% (53668/160010)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 29, 2025

BE Regression && UT Coverage Report

Increment line coverage 93.10% (189/203) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.19% (23409/32881)
Line Coverage 57.63% (244871/424902)
Region Coverage 53.09% (204375/384969)
Branch Coverage 54.70% (87856/160603)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 29, 2025

FE Regression Coverage Report

Increment line coverage 26.67% (12/45) 🎉
Increment coverage report
Complete coverage report

@wumeibanfa
Copy link
Contributor Author

wumeibanfa commented Oct 1, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 1, 2025

TPC-DS: Total hot run time: 190732 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c682c7d3ba8b88fbb8dcbfede56213313a67220b, data reload: false

query1	1067	437	396	396
query2	6579	1667	1659	1659
query3	6762	228	223	223
query4	26770	23809	23195	23195
query5	4858	641	480	480
query6	333	269	237	237
query7	4669	500	297	297
query8	309	262	243	243
query9	8722	2605	2598	2598
query10	511	336	278	278
query11	15764	15484	14955	14955
query12	189	121	113	113
query13	1719	571	467	467
query14	11668	9373	9275	9275
query15	224	201	177	177
query16	7726	681	540	540
query17	1609	777	640	640
query18	2067	491	392	392
query19	231	214	212	212
query20	149	143	146	143
query21	228	142	129	129
query22	4882	4823	4989	4823
query23	35002	33784	33801	33784
query24	8914	2542	2485	2485
query25	632	549	479	479
query26	1415	281	168	168
query27	2826	509	372	372
query28	4454	2242	2183	2183
query29	785	648	503	503
query30	293	226	200	200
query31	964	837	794	794
query32	87	86	70	70
query33	655	391	369	369
query34	849	900	664	664
query35	843	858	786	786
query36	1005	1054	936	936
query37	129	115	96	96
query38	3495	3531	3446	3446
query39	1488	1427	1445	1427
query40	212	126	116	116
query41	64	58	57	57
query42	123	110	109	109
query43	493	484	471	471
query44	1356	845	827	827
query45	184	179	172	172
query46	840	1012	661	661
query47	1808	1821	1752	1752
query48	409	452	325	325
query49	791	500	412	412
query50	665	693	405	405
query51	3926	3943	3908	3908
query52	113	109	105	105
query53	243	264	200	200
query54	594	586	534	534
query55	87	87	81	81
query56	335	338	303	303
query57	1182	1198	1142	1142
query58	276	278	263	263
query59	2541	2711	2546	2546
query60	347	357	338	338
query61	152	152	151	151
query62	804	706	682	682
query63	233	192	193	192
query64	4391	1141	852	852
query65	4065	3958	3983	3958
query66	1094	426	342	342
query67	15588	15171	15330	15171
query68	9269	960	600	600
query69	482	324	293	293
query70	1437	1387	1259	1259
query71	502	336	319	319
query72	5946	4863	4860	4860
query73	693	603	362	362
query74	9226	8946	8764	8764
query75	4452	3368	2864	2864
query76	3735	1170	784	784
query77	847	431	324	324
query78	9712	9855	8887	8887
query79	1999	836	584	584
query80	715	568	517	517
query81	486	268	224	224
query82	458	162	134	134
query83	297	263	248	248
query84	305	109	91	91
query85	898	479	421	421
query86	339	324	309	309
query87	3864	3751	3689	3689
query88	2822	2227	2206	2206
query89	402	337	304	304
query90	2014	214	217	214
query91	165	166	132	132
query92	83	73	63	63
query93	1361	1018	643	643
query94	690	444	346	346
query95	405	322	315	315
query96	490	571	282	282
query97	2974	2950	2883	2883
query98	304	210	217	210
query99	1460	1409	1292	1292
Total cold run time: 282620 ms
Total hot run time: 190732 ms

@wumeibanfa
Copy link
Contributor Author

wumeibanfa commented Oct 17, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 17, 2025

FE UT Coverage Report

Increment line coverage 11.11% (5/45) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Oct 17, 2025

TPC-DS: Total hot run time: 190652 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 76e7a2cac3a33bfae4c8efdae0e8e2db7017b4d2, data reload: false

query1	1042	460	408	408
query2	6562	1721	1709	1709
query3	6755	218	217	217
query4	26560	23454	23726	23454
query5	4435	622	511	511
query6	357	275	232	232
query7	4670	498	299	299
query8	317	275	270	270
query9	8705	2586	2582	2582
query10	538	351	303	303
query11	15431	15106	14875	14875
query12	186	131	120	120
query13	1700	558	438	438
query14	10479	9319	9349	9319
query15	209	196	184	184
query16	7827	671	522	522
query17	1256	781	638	638
query18	2107	429	336	336
query19	225	228	208	208
query20	149	133	140	133
query21	224	143	133	133
query22	4754	4676	4438	4438
query23	34724	33828	33860	33828
query24	8980	2514	2463	2463
query25	638	543	489	489
query26	1248	283	168	168
query27	2841	528	371	371
query28	4335	2230	2181	2181
query29	808	700	538	538
query30	309	237	207	207
query31	894	824	809	809
query32	93	80	71	71
query33	596	399	354	354
query34	855	885	570	570
query35	857	862	802	802
query36	987	1005	907	907
query37	126	128	103	103
query38	3777	3754	3712	3712
query39	1573	1495	1499	1495
query40	241	136	134	134
query41	63	64	57	57
query42	130	109	110	109
query43	501	512	472	472
query44	1325	834	811	811
query45	181	187	174	174
query46	830	994	631	631
query47	1751	1775	1761	1761
query48	389	416	318	318
query49	758	555	400	400
query50	688	682	399	399
query51	3925	3896	3926	3896
query52	116	107	99	99
query53	238	267	197	197
query54	598	578	514	514
query55	89	84	82	82
query56	336	336	310	310
query57	1186	1201	1146	1146
query58	297	269	281	269
query59	2612	2686	2671	2671
query60	347	345	321	321
query61	156	152	151	151
query62	790	736	664	664
query63	225	190	188	188
query64	4437	1146	824	824
query65	4086	4002	3972	3972
query66	1103	424	324	324
query67	15462	15316	14985	14985
query68	9388	954	596	596
query69	500	326	286	286
query70	1376	1228	1317	1228
query71	483	352	313	313
query72	5497	4884	4930	4884
query73	676	567	362	362
query74	9229	8873	8739	8739
query75	4390	3312	2863	2863
query76	3863	1155	730	730
query77	999	414	318	318
query78	9613	9725	8892	8892
query79	4336	818	584	584
query80	702	551	554	551
query81	491	258	229	229
query82	405	159	132	132
query83	304	268	250	250
query84	295	115	99	99
query85	850	469	414	414
query86	337	324	292	292
query87	3771	3786	3686	3686
query88	2834	2242	2184	2184
query89	438	316	295	295
query90	2130	219	221	219
query91	172	163	144	144
query92	80	67	62	62
query93	2627	987	636	636
query94	698	449	343	343
query95	407	325	305	305
query96	489	587	280	280
query97	2904	3021	2906	2906
query98	240	224	215	215
query99	1423	1395	1339	1339
Total cold run time: 282936 ms
Total hot run time: 190652 ms

@doris-robot
Copy link

doris-robot commented Oct 17, 2025

ClickBench: Total hot run time: 30.33 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 76e7a2cac3a33bfae4c8efdae0e8e2db7017b4d2, data reload: false

query1	0.05	0.05	0.06
query2	0.10	0.05	0.05
query3	0.26	0.09	0.09
query4	1.60	0.11	0.12
query5	0.28	0.27	0.25
query6	1.21	0.66	0.64
query7	0.03	0.03	0.03
query8	0.06	0.04	0.05
query9	0.64	0.55	0.52
query10	0.62	0.59	0.59
query11	0.17	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.61	0.62
query14	1.02	1.06	1.03
query15	0.90	0.88	0.85
query16	0.40	0.41	0.41
query17	1.06	1.06	1.08
query18	0.22	0.21	0.20
query19	2.00	1.87	1.84
query20	0.01	0.01	0.02
query21	15.42	0.96	0.58
query22	0.76	1.11	0.75
query23	14.95	1.38	0.60
query24	7.49	1.95	0.55
query25	0.49	0.24	0.10
query26	0.61	0.16	0.13
query27	0.06	0.06	0.06
query28	9.24	1.33	0.94
query29	12.55	3.92	3.29
query30	0.28	0.14	0.12
query31	2.82	0.60	0.39
query32	3.24	0.56	0.47
query33	3.18	3.10	3.06
query34	16.12	5.47	4.85
query35	4.98	4.94	4.92
query36	0.72	0.52	0.51
query37	0.10	0.08	0.08
query38	0.07	0.05	0.05
query39	0.04	0.03	0.04
query40	0.18	0.16	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.05	0.04
Total cold run time: 104.87 s
Total hot run time: 30.33 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 17, 2025

BE UT Coverage Report

Increment line coverage 98.00% (196/200) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.58% (17854/33958)
Line Coverage 37.84% (162149/428547)
Region Coverage 32.26% (123693/383376)
Branch Coverage 33.67% (54201/160977)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 17, 2025

BE Regression && UT Coverage Report

Increment line coverage 98.00% (196/200) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.27% (23731/33297)
Line Coverage 57.69% (247087/428310)
Region Coverage 52.75% (204861/388346)
Branch Coverage 54.52% (88248/161872)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 17, 2025

FE Regression Coverage Report

Increment line coverage 73.33% (33/45) 🎉
Increment coverage report
Complete coverage report

@wumeibanfa wumeibanfa requested a review from zclllyybb October 20, 2025 02:04
zclllyybb
zclllyybb approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

PR approved by anyone and no changes requested.

@zclllyybb zclllyybb merged commit b36f517 into apache:master Oct 21, 2025
27 of 28 checks passed
@wumeibanfa wumeibanfa mentioned this pull request Oct 24, 2025
Closed
github-actions bot pushed a commit that referenced this pull request Oct 26, 2025
@wumeibanfa
[Feature](varbinary) add length, from_base64_binary, to_base64_bianry…
c90394e 
…, sub_binary for VarBinary type (#56648)

add some functions for varbinary
```text
length(varbinary) -> int
from_base64_binary(string) -> varbinary
to_base64_bianry(varbinary) -> string
sub_binary(varbinary, <pos> [, <len>]) ->varbinary
```
Issue Number: [#56426](#56426)
@github-actions github-actions bot mentioned this pull request Oct 26, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 27, 2025
@github-actions @wumeibanfa
branch-4.0: [Feature](varbinary) add length, from_base64_binary, to_b…
da37966 
…ase64_bianry, sub_binary for VarBinary type #56648 (#57334)

Cherry-picked from #56648

Co-authored-by: admiring_xm <86338598+wumeibanfa@users.noreply.github.com>
@yiguolei yiguolei mentioned this pull request Nov 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee left review comments

@zclllyybb zclllyybb zclllyybb approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

@zclllyybb zclllyybb

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wumeibanfa @Thearas @doris-robot @hello-stephen @HappenLee @zclllyybb @zhangstar333 @yiguolei