Skip to content

[metrics](warmup) add bvar for skipped warmup rowsets #56301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Sep 24, 2025
Merged

[metrics](warmup) add bvar for skipped warmup rowsets #56301

dataroaring merged 1 commit into from
Sep 24, 2025

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Sep 22, 2025

What problem does this PR solve?

Problem Summary:

Adds the bvar file_cache_event_driven_warm_up_skipped_rowset_num to the source cluster Backend to improve observability of the cache warmup process.

During event-driven warmup, rowsets can be skipped if the Backend fails to find the tablet's replica location information from a TGetTabletReplicaInfosRequest.

This new metric makes it possible to monitor and alert on these events, which helps in diagnosing incomplete cache warmups.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen
Copy link
Member Author

kaijchen commented Sep 22, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 22, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.40% (17626/33636)
Line Coverage 37.62% (160008/425324)
Region Coverage 32.14% (121865/379128)
Branch Coverage 33.50% (53430/159504)

liaoxin01
liaoxin01 approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 73c006a into apache:master Sep 24, 2025
28 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 24, 2025
@kaijchen
[metrics](warmup) add bvar for skipped warmup rowsets (#56301)
c70e62c 
### What problem does this PR solve?

Problem Summary:

Adds the bvar `file_cache_event_driven_warm_up_skipped_rowset_num` to
the source cluster Backend to improve observability of the cache warmup
process.

During event-driven warmup, rowsets can be skipped if the Backend fails
to find the tablet's replica location information from a
`TGetTabletReplicaInfosRequest`.

This new metric makes it possible to monitor and alert on these events,
which helps in diagnosing incomplete cache warmups.
@github-actions github-actions bot mentioned this pull request Sep 24, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 25, 2025
@github-actions @kaijchen
branch-3.1: [metrics](warmup) add bvar for skipped warmup rowsets #56301
da836fa 
 (#56373)

Cherry-picked from #56301

Co-authored-by: Kaijie Chen <chenkaijie@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.x dev/3.0.x-conflict dev/3.1.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaijchen @hello-stephen @liaoxin01 @dataroaring @morrySnow