Skip to content

[fix](test) try to fix two filecache regresion test case #56195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Sep 18, 2025
Merged

[fix](test) try to fix two filecache regresion test case #56195

dataroaring merged 1 commit into from
Sep 18, 2025

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Sep 18, 2025 •
edited
Loading

  • make test_filecache_with_base_compaction_thresthold run faster and use less memory
  • fix test_list_cache_file not stable

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@swjtu-zhanglei
[fix](test) try to fix two filecache regresion test case
6ea6367 
* make `test_filecache_with_base_compaction_thresthold` run faster and use less memory
* fix test_list_cache_file not stable
@Thearas
Copy link
Contributor

Thearas commented Sep 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 18, 2025

run buildall

dataroaring
dataroaring approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit bff47ec into apache:master Sep 18, 2025
36 of 38 checks passed
swjtu-zhanglei added a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Sep 22, 2025
@swjtu-zhanglei
branch-3.1: [fix](test) try to fix two filecache regresion test case (a…
652b3ce 
…pache#56195)

Cherry-picked from apache#56195

* make `test_filecache_with_base_compaction_thresthold` run faster and
use less memory
* fix test_list_cache_file not stable
github-actions bot pushed a commit that referenced this pull request Sep 22, 2025
@swjtu-zhanglei
[fix](test) try to fix two filecache regresion test case (#56195)
1e04168 
* make `test_filecache_with_base_compaction_thresthold` run faster and
use less memory
* fix test_list_cache_file not stable
@github-actions github-actions bot mentioned this pull request Sep 22, 2025
Closed
@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 25, 2025

the pr #56278 has contain the fix, please remove dev/3.1-conflict label @morrySnow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.2-merged dev/4.0.0-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@swjtu-zhanglei @Thearas @gavinchou @dataroaring @yiguolei @CalvinKirs