Skip to content

Conversation

@CalvinKirs
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34967 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 443f28d3a6d955419c800b497ed6583351c914bc, data reload: false

------ Round 1 ----------------------------------
q1	17613	5378	5139	5139
q2	2026	320	210	210
q3	10283	1367	729	729
q4	10251	1069	544	544
q5	7584	2415	2402	2402
q6	189	170	145	145
q7	962	767	646	646
q8	9359	1379	1112	1112
q9	6861	5130	5202	5130
q10	6982	2392	1984	1984
q11	495	314	296	296
q12	362	385	242	242
q13	17789	3726	3053	3053
q14	250	251	215	215
q15	571	498	493	493
q16	1016	973	937	937
q17	628	889	369	369
q18	7366	7167	7037	7037
q19	1388	964	569	569
q20	354	359	237	237
q21	3855	3247	2490	2490
q22	1062	1022	988	988
Total cold run time: 107246 ms
Total hot run time: 34967 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5345	5252	5200	5200
q2	256	334	228	228
q3	2254	2747	2315	2315
q4	1431	1836	1341	1341
q5	4405	4588	4563	4563
q6	219	172	136	136
q7	2098	2072	1888	1888
q8	2737	2540	2708	2540
q9	7379	7541	7354	7354
q10	3165	3363	2977	2977
q11	617	554	538	538
q12	697	863	656	656
q13	3737	3976	3387	3387
q14	289	329	314	314
q15	555	487	485	485
q16	1165	1117	1054	1054
q17	1187	1586	1404	1404
q18	7988	7785	7809	7785
q19	869	844	956	844
q20	2005	2078	1790	1790
q21	4807	4329	4380	4329
q22	1081	1054	987	987
Total cold run time: 54286 ms
Total hot run time: 52115 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185907 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 443f28d3a6d955419c800b497ed6583351c914bc, data reload: false

query1	1096	443	409	409
query2	6561	1722	1739	1722
query3	6767	217	219	217
query4	26402	23191	22916	22916
query5	4442	643	488	488
query6	354	246	231	231
query7	4650	541	302	302
query8	320	256	264	256
query9	9172	2681	2689	2681
query10	487	334	273	273
query11	15382	15053	14902	14902
query12	169	112	112	112
query13	1669	553	437	437
query14	10431	9202	9270	9202
query15	220	196	185	185
query16	7358	656	526	526
query17	1221	751	637	637
query18	2002	428	327	327
query19	203	205	169	169
query20	127	125	124	124
query21	215	138	115	115
query22	4064	4133	4032	4032
query23	33818	33003	32901	32901
query24	8448	2396	2474	2396
query25	619	552	476	476
query26	1254	281	164	164
query27	2721	524	363	363
query28	4368	2236	2221	2221
query29	877	634	512	512
query30	299	233	202	202
query31	917	823	761	761
query32	86	76	78	76
query33	592	396	377	377
query34	808	855	533	533
query35	815	851	752	752
query36	973	1004	928	928
query37	125	108	86	86
query38	3571	3498	3532	3498
query39	1532	1437	1481	1437
query40	218	127	120	120
query41	63	60	62	60
query42	122	117	112	112
query43	508	507	459	459
query44	1368	852	845	845
query45	185	173	169	169
query46	883	1015	664	664
query47	1739	1792	1725	1725
query48	397	418	315	315
query49	751	520	416	416
query50	635	688	409	409
query51	3983	3917	3882	3882
query52	120	112	103	103
query53	232	273	198	198
query54	618	600	531	531
query55	93	88	85	85
query56	326	334	306	306
query57	1176	1178	1126	1126
query58	274	266	273	266
query59	2644	2689	2610	2610
query60	347	339	326	326
query61	170	166	161	161
query62	825	765	672	672
query63	233	200	206	200
query64	4567	1169	824	824
query65	4051	3941	3977	3941
query66	1155	440	339	339
query67	15481	15187	15137	15137
query68	9074	949	585	585
query69	494	316	287	287
query70	1362	1280	1248	1248
query71	592	343	326	326
query72	6071	2684	5350	2684
query73	799	780	367	367
query74	9063	9043	8698	8698
query75	4318	3248	2831	2831
query76	3658	1174	787	787
query77	855	402	315	315
query78	9708	9722	8773	8773
query79	3273	830	583	583
query80	710	569	487	487
query81	530	259	225	225
query82	473	166	134	134
query83	299	277	253	253
query84	305	120	91	91
query85	887	474	438	438
query86	341	324	314	314
query87	3750	3757	3647	3647
query88	2824	2232	2219	2219
query89	439	339	296	296
query90	1936	212	207	207
query91	165	176	140	140
query92	83	70	65	65
query93	2229	991	645	645
query94	699	445	329	329
query95	398	319	311	311
query96	478	582	276	276
query97	2949	2977	2886	2886
query98	233	219	221	219
query99	1441	1372	1294	1294
Total cold run time: 278735 ms
Total hot run time: 185907 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.93 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 443f28d3a6d955419c800b497ed6583351c914bc, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.06
query3	0.24	0.08	0.09
query4	1.61	0.11	0.12
query5	0.28	0.29	0.26
query6	1.17	0.65	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.62	0.53	0.54
query10	0.56	0.58	0.58
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.63	0.64
query14	1.02	1.01	1.05
query15	0.87	0.86	0.85
query16	0.40	0.43	0.40
query17	1.06	1.05	1.08
query18	0.22	0.20	0.20
query19	1.97	1.85	1.85
query20	0.02	0.01	0.02
query21	15.45	0.89	0.59
query22	0.76	1.18	0.62
query23	14.98	1.37	0.67
query24	7.25	0.73	1.49
query25	0.50	0.12	0.19
query26	0.59	0.16	0.13
query27	0.06	0.06	0.06
query28	9.60	0.89	0.42
query29	12.59	3.91	3.27
query30	0.28	0.16	0.14
query31	2.84	0.60	0.39
query32	3.25	0.58	0.47
query33	3.05	3.10	3.12
query34	16.10	5.48	4.87
query35	4.93	4.91	4.88
query36	0.72	0.52	0.50
query37	0.10	0.08	0.07
query38	0.07	0.05	0.04
query39	0.04	0.04	0.03
query40	0.18	0.16	0.14
query41	0.09	0.03	0.04
query42	0.04	0.03	0.04
query43	0.04	0.04	0.03
Total cold run time: 104.71 s
Total hot run time: 29.93 s

@CalvinKirs
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34517 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 25328fd5faa2377c3f175405452beec888e2c1cf, data reload: false

------ Round 1 ----------------------------------
q1	17662	5165	5054	5054
q2	2006	307	215	215
q3	10297	1273	693	693
q4	10226	1025	520	520
q5	7558	2413	2337	2337
q6	181	174	137	137
q7	920	760	631	631
q8	9349	1326	1140	1140
q9	6884	5085	5165	5085
q10	6947	2410	1945	1945
q11	517	303	285	285
q12	340	358	223	223
q13	17781	3694	3028	3028
q14	235	247	229	229
q15	574	502	489	489
q16	1011	1016	933	933
q17	594	864	359	359
q18	7600	7234	7025	7025
q19	1633	951	566	566
q20	348	342	229	229
q21	3643	3218	2386	2386
q22	1090	1054	1008	1008
Total cold run time: 107396 ms
Total hot run time: 34517 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5198	5064	5040	5040
q2	251	331	229	229
q3	2144	2666	2275	2275
q4	1349	1761	1309	1309
q5	4177	4436	4580	4436
q6	227	184	138	138
q7	2102	2018	1753	1753
q8	2659	2649	2596	2596
q9	7442	7271	7174	7174
q10	3138	3295	2871	2871
q11	580	546	539	539
q12	694	818	652	652
q13	3487	3881	3323	3323
q14	273	301	274	274
q15	523	474	482	474
q16	1057	1114	1110	1110
q17	1215	1610	1435	1435
q18	8017	7739	7621	7621
q19	812	847	1008	847
q20	1953	1948	1852	1852
q21	4725	4337	4340	4337
q22	1080	1072	1001	1001
Total cold run time: 53103 ms
Total hot run time: 51286 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186958 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 25328fd5faa2377c3f175405452beec888e2c1cf, data reload: false

query1	1053	444	408	408
query2	6578	1691	1698	1691
query3	6762	220	215	215
query4	25860	23075	22780	22780
query5	4703	632	483	483
query6	340	245	233	233
query7	4685	531	317	317
query8	336	267	249	249
query9	8677	2577	2567	2567
query10	488	330	270	270
query11	15337	15010	14702	14702
query12	167	117	111	111
query13	1669	547	421	421
query14	10168	9117	9116	9116
query15	204	196	178	178
query16	7287	683	533	533
query17	1266	771	642	642
query18	2018	444	351	351
query19	207	250	159	159
query20	126	129	129	129
query21	219	140	113	113
query22	4150	4212	3977	3977
query23	33793	33119	32898	32898
query24	8509	2406	2401	2401
query25	561	499	427	427
query26	1235	268	159	159
query27	2763	503	368	368
query28	4408	2219	2189	2189
query29	828	593	479	479
query30	285	236	205	205
query31	892	828	754	754
query32	88	72	71	71
query33	581	402	337	337
query34	795	858	514	514
query35	834	817	746	746
query36	979	1038	926	926
query37	116	107	87	87
query38	3541	3536	3474	3474
query39	1534	1430	1434	1430
query40	221	126	120	120
query41	69	62	63	62
query42	126	113	112	112
query43	496	520	478	478
query44	1296	843	834	834
query45	219	195	172	172
query46	858	1019	641	641
query47	1778	1815	1753	1753
query48	392	410	316	316
query49	761	492	413	413
query50	642	695	403	403
query51	3863	4037	3896	3896
query52	107	105	99	99
query53	243	259	196	196
query54	589	571	527	527
query55	84	84	80	80
query56	308	323	312	312
query57	1192	1179	1143	1143
query58	279	272	262	262
query59	2605	2720	2495	2495
query60	336	329	341	329
query61	175	161	155	155
query62	838	724	703	703
query63	229	190	193	190
query64	4542	1161	936	936
query65	4017	3979	3960	3960
query66	1203	466	355	355
query67	15541	15241	14957	14957
query68	8436	912	589	589
query69	488	318	276	276
query70	1380	1329	1204	1204
query71	550	370	338	338
query72	5906	4859	4749	4749
query73	711	562	363	363
query74	8938	9250	8637	8637
query75	3865	3362	2870	2870
query76	3642	1181	722	722
query77	808	405	317	317
query78	9472	9773	8924	8924
query79	2236	830	580	580
query80	625	547	498	498
query81	491	267	227	227
query82	447	163	127	127
query83	293	261	252	252
query84	295	111	89	89
query85	877	459	416	416
query86	341	322	299	299
query87	3785	3725	3596	3596
query88	3205	2192	2209	2192
query89	400	339	301	301
query90	1912	212	213	212
query91	162	166	132	132
query92	85	69	63	63
query93	1137	1005	643	643
query94	691	436	401	401
query95	403	311	311	311
query96	484	559	276	276
query97	2923	2996	2853	2853
query98	242	221	209	209
query99	1432	1422	1283	1283
Total cold run time: 273713 ms
Total hot run time: 186958 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.41 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 25328fd5faa2377c3f175405452beec888e2c1cf, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.07
query4	1.60	0.11	0.11
query5	0.30	0.27	0.25
query6	1.16	0.64	0.65
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.62	0.54	0.53
query10	0.58	0.57	0.59
query11	0.17	0.12	0.11
query12	0.17	0.12	0.12
query13	0.63	0.62	0.62
query14	1.03	1.04	1.06
query15	0.87	0.84	0.86
query16	0.40	0.40	0.38
query17	1.03	1.06	1.04
query18	0.21	0.20	0.20
query19	1.91	1.87	1.83
query20	0.02	0.01	0.01
query21	15.46	0.95	0.58
query22	0.77	1.18	0.66
query23	14.94	1.39	0.64
query24	7.44	1.78	1.35
query25	0.46	0.23	0.15
query26	0.60	0.15	0.14
query27	0.06	0.05	0.06
query28	9.89	0.78	0.42
query29	12.65	3.86	3.27
query30	0.29	0.13	0.12
query31	2.83	0.58	0.39
query32	3.25	0.58	0.47
query33	3.00	3.03	3.05
query34	16.21	5.39	4.87
query35	4.89	4.87	4.92
query36	0.70	0.51	0.50
query37	0.10	0.08	0.07
query38	0.07	0.05	0.04
query39	0.03	0.03	0.03
query40	0.18	0.15	0.14
query41	0.09	0.04	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 105.15 s
Total hot run time: 30.41 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 30.52% (47/154) 🎉
Increment coverage report
Complete coverage report

@CalvinKirs
Copy link
Member Author

run compile

private static final ExecutorService ALTER_BE_SYNC_THREAD_POOL = Executors.newFixedThreadPool(1);
private final SystemInfoService systemInfoService;

public static final String S3_ROOT_PATH = "s3.root.path";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate in S3StorageVault.java.
I think we can move it to S3Properties?

return alterObjVaultBuilder;
}

private static Cloud.ObjectStoreInfoPB.Builder getObjStoreInfoPB(Map<String, String> properties) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this method should be moved to S3Properties?

  1. properties -> S3StorageProperties
  2. S3StorageProperties -> ObjectStoreInfoPB

S3Properties.SECRET_KEY,
S3Properties.Env.SECRET_KEY,
MCProperties.SECRET_KEY));
SENSITIVE_KEY.addAll(S3Properties.SENSITIVE_KEYS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use method like SENSITIVE_KEY.addAll(ConnectorPropertiesUtils.getSensitiveKeys(OBSProperties.class));

@Getter
protected String forceParsingByStandardUrl = "false";

public static final String ENDPOINT = "azure.endpoint";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 4 strings are not used, can be removed

return ret;
}

private static TS3StorageParam getS3TStorageParam(Map<String, String> properties) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to refactor this later.

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 46.75% (72/154) 🎉
Increment coverage report
Complete coverage report

@CalvinKirs
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34872 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2ac33fcdae4f36821114d7ebc83547e6704b032a, data reload: false

------ Round 1 ----------------------------------
q1	17626	5193	5074	5074
q2	2003	315	217	217
q3	10265	1304	726	726
q4	10246	1051	538	538
q5	7502	2458	2455	2455
q6	188	167	141	141
q7	950	767	627	627
q8	9339	1354	1041	1041
q9	7054	5185	5226	5185
q10	6989	2401	1985	1985
q11	505	302	289	289
q12	367	373	238	238
q13	17786	3680	3020	3020
q14	241	244	215	215
q15	568	494	505	494
q16	1024	1012	965	965
q17	616	879	368	368
q18	7716	7194	7080	7080
q19	1098	977	575	575
q20	364	355	241	241
q21	3752	2632	2431	2431
q22	1076	1023	967	967
Total cold run time: 107275 ms
Total hot run time: 34872 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5149	5087	5201	5087
q2	259	339	232	232
q3	2194	2724	2281	2281
q4	1373	1778	1322	1322
q5	4228	4591	4688	4591
q6	233	182	133	133
q7	2071	2010	1810	1810
q8	2698	2714	2568	2568
q9	7405	7458	7505	7458
q10	3117	3195	2897	2897
q11	611	603	530	530
q12	781	795	632	632
q13	3561	4066	3314	3314
q14	309	325	283	283
q15	535	469	513	469
q16	1118	1110	1081	1081
q17	1237	1636	1409	1409
q18	7798	7690	7518	7518
q19	832	842	924	842
q20	2003	2137	2012	2012
q21	5017	4394	4388	4388
q22	1094	1022	1008	1008
Total cold run time: 53623 ms
Total hot run time: 51865 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188862 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2ac33fcdae4f36821114d7ebc83547e6704b032a, data reload: false

query1	1046	423	403	403
query2	6567	1726	1729	1726
query3	6760	230	224	224
query4	26264	23628	22999	22999
query5	4403	610	463	463
query6	334	232	211	211
query7	4650	519	303	303
query8	310	251	240	240
query9	8639	2599	2626	2599
query10	483	359	302	302
query11	15558	15085	15178	15085
query12	177	116	112	112
query13	1687	570	445	445
query14	10330	9112	9149	9112
query15	204	195	174	174
query16	7543	666	508	508
query17	1278	763	626	626
query18	2030	431	335	335
query19	199	197	167	167
query20	129	125	130	125
query21	212	131	114	114
query22	4379	4313	4064	4064
query23	33921	33029	32856	32856
query24	8494	2411	2413	2411
query25	564	511	461	461
query26	1252	289	164	164
query27	2722	513	356	356
query28	4357	2245	2229	2229
query29	834	614	520	520
query30	302	231	199	199
query31	933	837	739	739
query32	81	75	83	75
query33	611	392	363	363
query34	809	854	539	539
query35	827	863	770	770
query36	972	1038	923	923
query37	128	111	93	93
query38	3540	3527	3502	3502
query39	1550	1447	1417	1417
query40	231	136	125	125
query41	75	69	68	68
query42	128	116	111	111
query43	532	500	503	500
query44	1315	841	839	839
query45	188	177	169	169
query46	860	1030	652	652
query47	1783	1810	1747	1747
query48	386	422	318	318
query49	779	516	424	424
query50	670	683	409	409
query51	3941	3970	3923	3923
query52	110	116	110	110
query53	237	265	207	207
query54	606	603	577	577
query55	90	91	82	82
query56	337	314	304	304
query57	1224	1206	1134	1134
query58	271	272	269	269
query59	2653	2649	2592	2592
query60	339	335	337	335
query61	170	165	160	160
query62	831	750	696	696
query63	226	195	188	188
query64	4512	1178	859	859
query65	4070	3998	4028	3998
query66	1125	440	352	352
query67	15812	15636	15332	15332
query68	9002	926	594	594
query69	494	313	287	287
query70	1378	1276	1373	1276
query71	576	365	327	327
query72	5976	5041	5070	5041
query73	723	643	361	361
query74	9192	8910	8724	8724
query75	4349	3324	2871	2871
query76	3688	1173	738	738
query77	825	401	313	313
query78	9646	9960	8833	8833
query79	2125	848	602	602
query80	651	560	491	491
query81	469	272	234	234
query82	426	168	132	132
query83	302	263	248	248
query84	312	115	92	92
query85	912	480	507	480
query86	345	311	319	311
query87	3786	3779	3613	3613
query88	3088	2204	2231	2204
query89	395	332	301	301
query90	1906	209	210	209
query91	170	174	136	136
query92	86	64	60	60
query93	1183	980	699	699
query94	690	460	330	330
query95	399	320	314	314
query96	482	568	272	272
query97	2981	2973	2869	2869
query98	243	214	204	204
query99	1426	1420	1262	1262
Total cold run time: 276806 ms
Total hot run time: 188862 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.15 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2ac33fcdae4f36821114d7ebc83547e6704b032a, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.06	0.05
query3	0.25	0.08	0.09
query4	1.61	0.12	0.12
query5	0.28	0.27	0.25
query6	1.18	0.66	0.64
query7	0.03	0.03	0.02
query8	0.05	0.05	0.05
query9	0.60	0.53	0.53
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.14	0.12
query13	0.63	0.62	0.62
query14	1.03	1.02	1.04
query15	0.86	0.85	0.86
query16	0.40	0.39	0.40
query17	1.06	1.04	1.03
query18	0.21	0.20	0.20
query19	1.91	1.82	1.77
query20	0.02	0.01	0.01
query21	15.45	0.97	0.58
query22	0.78	1.13	0.62
query23	15.03	1.37	0.64
query24	6.98	0.71	0.30
query25	0.31	0.27	0.12
query26	0.68	0.15	0.13
query27	0.06	0.05	0.06
query28	9.60	0.93	0.41
query29	12.58	3.91	3.26
query30	0.28	0.14	0.11
query31	2.82	0.61	0.39
query32	3.26	0.56	0.47
query33	3.08	3.02	3.12
query34	16.20	5.45	4.82
query35	4.97	4.89	4.91
query36	0.71	0.51	0.50
query37	0.12	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.15	0.14
query41	0.08	0.04	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 104.47 s
Total hot run time: 29.15 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 46.36% (70/151) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 18, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@CalvinKirs CalvinKirs merged commit 87f8248 into apache:master Sep 18, 2025
30 of 32 checks passed
CalvinKirs added a commit to CalvinKirs/incubator-doris that referenced this pull request Sep 26, 2025
remove oldcode

(cherry picked from commit 87f8248)
morningman added a commit that referenced this pull request Sep 28, 2025
)

cherry-pick #55625 #56163

---------

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants