-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](variant) add column cache for variant sparse column #56159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 34850 ms |
TPC-DS: Total hot run time: 189228 ms |
ClickBench: Total hot run time: 29.77 s |
|
run buildall |
be/src/olap/rowset/segment_v2/variant/sparse_column_extract_iterator.h
Outdated
Show resolved
Hide resolved
be/src/olap/rowset/segment_v2/variant/sparse_column_extract_iterator.h
Outdated
Show resolved
Hide resolved
be/src/olap/rowset/segment_v2/variant/variant_column_reader.cpp
Outdated
Show resolved
Hide resolved
|
run buildall |
TPC-H: Total hot run time: 1496 ms |
TPC-DS: Total hot run time: 2756 ms |
ClickBench: Total hot run time: 0.06 s |
|
run buildall |
TPC-H: Total hot run time: 1517 ms |
TPC-DS: Total hot run time: 2799 ms |
ClickBench: Total hot run time: 0.07 s |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 1543 ms |
TPC-DS: Total hot run time: 2720 ms |
ClickBench: Total hot run time: 0.07 s |
3cccf60 to
9e8cdfb
Compare
|
run buildall |
TPC-H: Total hot run time: 1529 ms |
TPC-DS: Total hot run time: 2818 ms |
ClickBench: Total hot run time: 0.09 s |
|
run buildall |
TPC-H: Total hot run time: 1486 ms |
TPC-DS: Total hot run time: 2756 ms |
8b7621e to
ff8373a
Compare
|
run buildall |
ClickBench: Total hot run time: 30.54 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
airborne12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Optimize Variant sparse-column scans by introducing a per-segment sparse column cache so multiple readers/iterators reuse sparse column (keyed by column unique_id and path).
Optimize Variant sparse-column scans by introducing a per-segment sparse column cache so multiple readers/iterators reuse sparse column (keyed by column unique_id and path).
Optimize Variant sparse-column scans by introducing a per-segment sparse column cache so multiple readers/iterators reuse sparse column (keyed by column unique_id and path).
What problem does this PR solve?
Optimize Variant sparse-column scans by introducing a per-segment sparse column cache so multiple readers/iterators reuse sparse column (keyed by column unique_id and path).
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)