Skip to content

[feat](s3client) Use CustomAwsCredentialsProviderChain for aws sdk #56065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 4 commits into from
Oct 13, 2025
Merged

[feat](s3client) Use CustomAwsCredentialsProviderChain for aws sdk #56065

dataroaring merged 4 commits into from
Oct 13, 2025

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Sep 15, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 15, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 15, 2025

Cloud UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.47% (1534/1816)
Line Coverage 68.16% (27571/40453)
Region Coverage 68.91% (13591/19723)
Branch Coverage 59.07% (7264/12298)

@doris-robot
Copy link

doris-robot commented Sep 15, 2025

TPC-H: Total hot run time: 35050 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c2a1577135770bbd7f9b03d251f72c69448fdae7, data reload: false

------ Round 1 ----------------------------------
q1	17606	5306	5056	5056
q2	2019	322	219	219
q3	10247	1296	733	733
q4	10221	1031	529	529
q5	7500	2398	2403	2398
q6	183	168	135	135
q7	937	780	642	642
q8	9359	1348	1224	1224
q9	7107	5139	5240	5139
q10	6985	2410	1991	1991
q11	515	312	282	282
q12	374	375	227	227
q13	17775	3710	3063	3063
q14	240	235	222	222
q15	597	488	497	488
q16	1035	999	950	950
q17	599	873	384	384
q18	7345	7207	7151	7151
q19	1102	968	588	588
q20	351	346	236	236
q21	4042	3241	2416	2416
q22	1048	1032	977	977
Total cold run time: 107187 ms
Total hot run time: 35050 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5193	5154	5129	5129
q2	246	328	238	238
q3	2185	2664	2297	2297
q4	1360	1766	1353	1353
q5	4274	4554	4559	4554
q6	209	176	150	150
q7	2035	1999	1901	1901
q8	2669	2631	2589	2589
q9	7492	7308	7399	7308
q10	3112	3321	2860	2860
q11	569	515	501	501
q12	695	792	627	627
q13	3488	3992	3434	3434
q14	295	328	278	278
q15	518	475	497	475
q16	1310	1104	1058	1058
q17	1207	1550	1386	1386
q18	7892	7597	7921	7597
q19	811	853	917	853
q20	2011	2137	1916	1916
q21	4763	4414	4219	4219
q22	1094	1038	975	975
Total cold run time: 53428 ms
Total hot run time: 51698 ms

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 15, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Sep 15, 2025

TPC-DS: Total hot run time: 188515 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c2a1577135770bbd7f9b03d251f72c69448fdae7, data reload: false

query1	1101	416	418	416
query2	6574	1720	1724	1720
query3	6754	224	227	224
query4	26163	23562	23013	23013
query5	4385	654	482	482
query6	328	259	248	248
query7	4667	526	301	301
query8	321	261	254	254
query9	8670	2670	2689	2670
query10	489	366	291	291
query11	15314	15090	14848	14848
query12	171	112	113	112
query13	1674	577	432	432
query14	10364	9319	9209	9209
query15	212	203	180	180
query16	7150	686	488	488
query17	997	733	604	604
query18	2004	442	331	331
query19	203	211	176	176
query20	175	121	119	119
query21	213	130	118	118
query22	4019	4118	3920	3920
query23	33962	33000	33003	33000
query24	8479	2426	2435	2426
query25	616	512	423	423
query26	1240	279	161	161
query27	2745	521	358	358
query28	4382	2250	2224	2224
query29	805	623	479	479
query30	297	229	194	194
query31	914	819	731	731
query32	84	76	72	72
query33	599	376	327	327
query34	791	852	534	534
query35	810	816	749	749
query36	997	1003	914	914
query37	119	111	97	97
query38	3616	3603	3465	3465
query39	1495	1398	1412	1398
query40	223	168	119	119
query41	61	63	58	58
query42	131	122	116	116
query43	522	505	453	453
query44	1378	864	862	862
query45	191	179	172	172
query46	851	1018	678	678
query47	1772	1777	1719	1719
query48	390	424	308	308
query49	759	492	401	401
query50	647	683	416	416
query51	4017	3970	3947	3947
query52	109	108	104	104
query53	242	277	191	191
query54	604	604	548	548
query55	89	99	90	90
query56	330	313	320	313
query57	1161	1221	1118	1118
query58	272	266	270	266
query59	2547	2639	2482	2482
query60	354	347	332	332
query61	190	184	216	184
query62	838	780	695	695
query63	239	201	204	201
query64	4570	1217	838	838
query65	4039	3976	3951	3951
query66	1177	430	334	334
query67	15644	15327	15559	15327
query68	7833	941	585	585
query69	488	309	279	279
query70	1328	1324	1282	1282
query71	574	337	309	309
query72	5955	5120	5067	5067
query73	678	638	356	356
query74	8963	9021	8805	8805
query75	3645	3316	2809	2809
query76	3360	1162	751	751
query77	878	422	311	311
query78	9554	9849	8929	8929
query79	2017	873	585	585
query80	642	578	497	497
query81	486	258	227	227
query82	430	161	132	132
query83	260	276	264	264
query84	302	117	100	100
query85	896	459	412	412
query86	340	323	320	320
query87	3776	3803	3683	3683
query88	3296	2226	2233	2226
query89	412	334	286	286
query90	1921	216	217	216
query91	157	174	136	136
query92	77	116	62	62
query93	1097	989	657	657
query94	724	425	336	336
query95	397	317	309	309
query96	488	560	275	275
query97	2921	3000	2865	2865
query98	240	212	218	212
query99	1364	1413	1301	1301
Total cold run time: 272745 ms
Total hot run time: 188515 ms

@doris-robot
Copy link

doris-robot commented Sep 15, 2025

ClickBench: Total hot run time: 30.15 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c2a1577135770bbd7f9b03d251f72c69448fdae7, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.06
query3	0.26	0.08	0.08
query4	1.61	0.12	0.12
query5	0.30	0.26	0.25
query6	1.18	0.65	0.65
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.64	0.53	0.52
query10	0.59	0.58	0.57
query11	0.16	0.11	0.12
query12	0.15	0.14	0.13
query13	0.63	0.62	0.62
query14	1.03	1.04	1.04
query15	0.90	0.86	0.85
query16	0.41	0.39	0.40
query17	1.03	1.07	1.07
query18	0.21	0.19	0.20
query19	1.94	1.86	1.82
query20	0.02	0.01	0.01
query21	15.43	0.96	0.59
query22	0.78	1.06	0.60
query23	15.09	1.38	0.65
query24	7.39	1.13	0.91
query25	0.48	0.26	0.13
query26	0.56	0.16	0.15
query27	0.08	0.05	0.05
query28	9.55	0.89	0.42
query29	12.66	3.98	3.30
query30	0.28	0.13	0.11
query31	2.83	0.62	0.39
query32	3.26	0.57	0.48
query33	3.07	3.11	3.06
query34	16.15	5.41	4.89
query35	4.93	4.94	4.94
query36	0.69	0.51	0.52
query37	0.11	0.07	0.08
query38	0.07	0.05	0.04
query39	0.03	0.02	0.02
query40	0.18	0.15	0.15
query41	0.10	0.03	0.03
query42	0.04	0.04	0.03
query43	0.05	0.03	0.03
Total cold run time: 105.1 s
Total hot run time: 30.15 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 15, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.33% (17533/33503)
Line Coverage 37.49% (158981/424075)
Region Coverage 32.06% (121234/378148)
Branch Coverage 33.41% (53160/159126)

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 16, 2025

run p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 16, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 70.85% (23205/32752)
Line Coverage 57.21% (242017/423022)
Region Coverage 52.72% (201987/383113)
Branch Coverage 54.29% (86771/159823)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 16, 2025

FE Regression Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 17, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 17, 2025

Cloud UT Coverage Report

Increment line coverage 30.56% (11/36) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.99% (1542/1836)
Line Coverage 68.02% (27606/40587)
Region Coverage 68.44% (13586/19852)
Branch Coverage 58.66% (7252/12362)

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 17, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 17, 2025

Cloud UT Coverage Report

Increment line coverage 31.43% (11/35) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.90% (1542/1838)
Line Coverage 67.93% (27603/40635)
Region Coverage 68.40% (13585/19860)
Branch Coverage 58.61% (7249/12368)

@doris-robot
Copy link

doris-robot commented Sep 17, 2025

TPC-H: Total hot run time: 34714 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit aa42aaa71916e80a51ecc08a46e59fa347f0fd9b, data reload: false

------ Round 1 ----------------------------------
q1	17583	5341	5139	5139
q2	2011	329	217	217
q3	10277	1302	719	719
q4	10241	1027	512	512
q5	7568	2587	2376	2376
q6	184	167	135	135
q7	949	764	628	628
q8	9371	1420	1173	1173
q9	7091	5154	5122	5122
q10	6990	2405	1966	1966
q11	496	312	286	286
q12	371	357	228	228
q13	17780	3633	3030	3030
q14	235	243	223	223
q15	575	496	489	489
q16	1026	1011	950	950
q17	618	871	363	363
q18	7741	7156	7003	7003
q19	1089	960	569	569
q20	351	344	231	231
q21	3770	3229	2386	2386
q22	1052	1038	969	969
Total cold run time: 107369 ms
Total hot run time: 34714 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5214	5156	5150	5150
q2	256	336	227	227
q3	2171	2686	2320	2320
q4	1342	1771	1364	1364
q5	4291	4591	4496	4496
q6	223	175	133	133
q7	2017	2004	1823	1823
q8	2655	2608	2646	2608
q9	7515	7458	7281	7281
q10	3156	3304	2868	2868
q11	596	546	518	518
q12	886	799	634	634
q13	3532	3932	3336	3336
q14	289	295	289	289
q15	531	489	488	488
q16	1089	1126	1046	1046
q17	1226	1635	1385	1385
q18	8030	7614	7552	7552
q19	807	804	811	804
q20	1956	1992	1851	1851
q21	4734	4295	4383	4295
q22	1077	1039	1015	1015
Total cold run time: 53593 ms
Total hot run time: 51483 ms

@doris-robot
Copy link

doris-robot commented Sep 17, 2025

TPC-DS: Total hot run time: 188144 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit aa42aaa71916e80a51ecc08a46e59fa347f0fd9b, data reload: false

query1	1073	446	406	406
query2	6562	1675	1686	1675
query3	6750	225	226	225
query4	26315	23385	23478	23385
query5	4406	600	492	492
query6	321	224	220	220
query7	4648	506	294	294
query8	296	257	245	245
query9	8631	2605	2617	2605
query10	461	339	275	275
query11	15672	15029	14871	14871
query12	173	122	118	118
query13	1684	564	447	447
query14	10290	9288	9178	9178
query15	219	202	181	181
query16	7374	657	515	515
query17	1260	775	648	648
query18	2053	422	319	319
query19	208	197	166	166
query20	128	126	130	126
query21	214	136	116	116
query22	4086	4189	3940	3940
query23	33663	33086	32945	32945
query24	8517	2417	2451	2417
query25	571	507	455	455
query26	1240	272	157	157
query27	2760	508	370	370
query28	4365	2233	2222	2222
query29	809	596	492	492
query30	299	231	205	205
query31	907	794	761	761
query32	86	71	68	68
query33	576	384	319	319
query34	811	856	516	516
query35	815	859	730	730
query36	970	1058	919	919
query37	122	118	82	82
query38	3529	3501	3481	3481
query39	1487	1432	1495	1432
query40	227	129	116	116
query41	67	62	60	60
query42	126	119	111	111
query43	509	509	487	487
query44	1329	852	838	838
query45	190	180	172	172
query46	858	1036	661	661
query47	1764	1803	1718	1718
query48	380	421	311	311
query49	761	541	450	450
query50	654	702	401	401
query51	3995	4047	3866	3866
query52	112	108	102	102
query53	241	266	200	200
query54	599	591	538	538
query55	90	85	87	85
query56	331	326	302	302
query57	1188	1204	1148	1148
query58	280	268	262	262
query59	2533	2749	2573	2573
query60	350	332	330	330
query61	167	157	152	152
query62	813	734	684	684
query63	224	196	190	190
query64	4511	1135	837	837
query65	4061	3988	3927	3927
query66	1171	454	338	338
query67	15399	15262	14934	14934
query68	8215	924	582	582
query69	506	331	282	282
query70	1433	1297	1237	1237
query71	577	339	305	305
query72	6064	4964	5069	4964
query73	701	629	367	367
query74	9124	9123	8756	8756
query75	3478	3328	2851	2851
query76	3356	1164	738	738
query77	565	423	314	314
query78	9586	9606	8874	8874
query79	2017	852	582	582
query80	618	563	496	496
query81	497	264	235	235
query82	478	161	137	137
query83	268	267	255	255
query84	251	116	93	93
query85	996	442	444	442
query86	382	325	292	292
query87	3771	3749	3651	3651
query88	3748	2224	2224	2224
query89	390	329	295	295
query90	1939	216	209	209
query91	157	166	213	166
query92	83	67	61	61
query93	1775	1019	638	638
query94	702	450	315	315
query95	392	307	299	299
query96	485	574	275	275
query97	2912	2962	2897	2897
query98	241	214	209	209
query99	1347	1409	1292	1292
Total cold run time: 274335 ms
Total hot run time: 188144 ms

@doris-robot
Copy link

doris-robot commented Sep 17, 2025

ClickBench: Total hot run time: 29.55 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit aa42aaa71916e80a51ecc08a46e59fa347f0fd9b, data reload: false

query1	0.05	0.04	0.05
query2	0.09	0.06	0.06
query3	0.26	0.08	0.08
query4	1.61	0.11	0.12
query5	0.28	0.27	0.26
query6	1.21	0.66	0.64
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.62	0.52	0.51
query10	0.58	0.57	0.58
query11	0.16	0.11	0.12
query12	0.15	0.12	0.11
query13	0.66	0.62	0.62
query14	1.04	1.03	1.06
query15	0.88	0.88	0.86
query16	0.40	0.41	0.40
query17	1.04	1.04	1.06
query18	0.22	0.19	0.20
query19	1.96	1.85	1.78
query20	0.01	0.01	0.02
query21	15.43	0.92	0.58
query22	0.76	1.24	0.72
query23	14.84	1.41	0.67
query24	7.62	1.44	0.35
query25	0.28	0.11	0.17
query26	0.68	0.17	0.13
query27	0.07	0.06	0.05
query28	8.82	0.90	0.45
query29	12.58	3.97	3.28
query30	0.27	0.14	0.12
query31	2.83	0.61	0.40
query32	3.24	0.56	0.49
query33	3.14	3.09	3.08
query34	16.07	5.48	4.87
query35	4.93	4.88	4.93
query36	0.69	0.52	0.50
query37	0.10	0.07	0.08
query38	0.07	0.05	0.05
query39	0.04	0.03	0.03
query40	0.18	0.16	0.15
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 104.1 s
Total hot run time: 29.55 s

@doris-robot
Copy link

doris-robot commented Sep 17, 2025

BE UT Coverage Report

Increment line coverage 25.64% (10/39) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.32% (17549/33541)
Line Coverage 37.45% (159047/424667)
Region Coverage 32.03% (121317/378713)
Branch Coverage 33.37% (53199/159433)

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 17, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 17, 2025

Cloud UT Coverage Report

Increment line coverage 31.43% (11/35) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.90% (1542/1838)
Line Coverage 67.91% (27594/40635)
Region Coverage 68.39% (13584/19863)
Branch Coverage 58.60% (7249/12370)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 17, 2025

FE UT Coverage Report

Increment line coverage 43.75% (28/64) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Sep 17, 2025

TPC-H: Total hot run time: 35432 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fda6c0e67376e18bd46dcdae9fe1644acd31b4df, data reload: false

------ Round 1 ----------------------------------
q1	17601	5227	5069	5069
q2	2031	325	220	220
q3	10286	1348	717	717
q4	10235	1030	537	537
q5	7525	2491	2333	2333
q6	189	176	142	142
q7	934	774	637	637
q8	9340	1323	1112	1112
q9	6978	5109	5202	5109
q10	6986	2389	1998	1998
q11	500	313	296	296
q12	371	361	234	234
q13	17779	3624	3043	3043
q14	247	238	228	228
q15	587	494	494	494
q16	1001	996	928	928
q17	619	886	355	355
q18	8013	7181	7084	7084
q19	1096	950	581	581
q20	358	355	235	235
q21	4204	3249	3085	3085
q22	1070	1059	995	995
Total cold run time: 107950 ms
Total hot run time: 35432 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5134	5094	5135	5094
q2	246	334	228	228
q3	2165	2666	2330	2330
q4	1376	1777	1358	1358
q5	4433	4442	4576	4442
q6	220	176	135	135
q7	2069	1948	1922	1922
q8	2653	2581	2657	2581
q9	7609	7298	7233	7233
q10	3157	3339	2849	2849
q11	597	520	528	520
q12	776	772	642	642
q13	3754	3793	3362	3362
q14	295	314	295	295
q15	587	491	484	484
q16	1053	1100	1076	1076
q17	1308	1604	1424	1424
q18	7855	7715	7612	7612
q19	837	838	807	807
q20	2051	2150	1922	1922
q21	4845	4457	4328	4328
q22	1105	1071	1006	1006
Total cold run time: 54125 ms
Total hot run time: 51650 ms

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

FE Regression Coverage Report

Increment line coverage 4.69% (3/64) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

BE Regression && UT Coverage Report

Increment line coverage 91.89% (34/37) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.23% (18930/33078)
Line Coverage 42.46% (181161/426669)
Region Coverage 37.02% (143260/386944)
Branch Coverage 38.07% (61454/161423)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

BE Regression && UT Coverage Report

Increment line coverage 91.89% (34/37) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.23% (18931/33078)
Line Coverage 42.44% (181081/426669)
Region Coverage 37.05% (143377/386944)
Branch Coverage 38.06% (61440/161423)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

FE Regression Coverage Report

Increment line coverage 4.69% (3/64) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

FE Regression Coverage Report

Increment line coverage 4.69% (3/64) 🎉
Increment coverage report
Complete coverage report

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Oct 13, 2025

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

BE Regression && UT Coverage Report

Increment line coverage 91.89% (34/37) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.23% (18929/33078)
Line Coverage 42.45% (181110/426669)
Region Coverage 37.07% (143443/386944)
Branch Coverage 38.07% (61446/161423)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

FE Regression Coverage Report

Increment line coverage 4.69% (3/64) 🎉
Increment coverage report
Complete coverage report

dataroaring
dataroaring approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 4db0920 into apache:master Oct 13, 2025
28 of 29 checks passed
swjtu-zhanglei added a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Oct 14, 2025
@swjtu-zhanglei
branch-4.0: [feat](s3client) Use CustomAwsCredentialsProviderChain …
3d81968 
…for aws sdk (apache#56065)
@swjtu-zhanglei swjtu-zhanglei mentioned this pull request Oct 14, 2025
Merged
16 tasks
swjtu-zhanglei added a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Oct 14, 2025
@swjtu-zhanglei
branch-3.1: [feat](s3client) Use CustomAwsCredentialsProviderChain …
fc88fdb 
…for aws sdk (apache#56065)
@swjtu-zhanglei swjtu-zhanglei mentioned this pull request Oct 14, 2025
Merged
morrySnow pushed a commit that referenced this pull request Oct 15, 2025
@swjtu-zhanglei
branch-3.1: [feat](s3client) Use CustomAwsCredentialsProviderChain …
a5d34cf 
…for aws sdk #56065 (#56943)

picked from #56065
yiguolei pushed a commit that referenced this pull request Oct 16, 2025
@swjtu-zhanglei
branch-4.0: [feat](s3client) Use CustomAwsCredentialsProviderChain …
90a79e1 
…for aws sdk (#56065) (#56936)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.x dev/3.1.2-merged dev/4.0.2-merged kind/behavior-changed reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@swjtu-zhanglei @Thearas @hello-stephen @doris-robot @gavinchou @dataroaring @morrySnow