-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](paimon) Optimize Paimon Time Travel Implementation and Fix Schema Consistency Issues #56023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
morningman
merged 16 commits into
apache:master
from
vinlee19:remove_redurant_time_travel_code
Sep 23, 2025
Merged
[opt](paimon) Optimize Paimon Time Travel Implementation and Fix Schema Consistency Issues #56023
morningman
merged 16 commits into
apache:master
from
vinlee19:remove_redurant_time_travel_code
Sep 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 714b596.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34863 ms |
TPC-DS: Total hot run time: 188750 ms |
ClickBench: Total hot run time: 29.65 s |
Collaborator
|
run buildall |
TPC-H: Total hot run time: 34769 ms |
TPC-DS: Total hot run time: 188828 ms |
ClickBench: Total hot run time: 30.26 s |
Contributor
Author
|
run p0 |
Contributor
Author
|
run cloud_p0 |
suxiaogang223
approved these changes
Sep 16, 2025
Contributor
|
PR approved by anyone and no changes requested. |
morningman
approved these changes
Sep 23, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
…ma Consistency Issues (#56023) ### What problem does this PR solve? Following PR #55404 which addressed incorrect schema results for Paimon tables, this PR further optimizes the Paimon time travel implementation by removing redundant code and fixing the critical issue where schema ID and snapshot ID were fetched separately, causing consistency problems and unnecessary I/O overhead. #### Key Problem Solved The core challenge in Paimon time travel is efficiently constructing tables with specified snapshot ID and schema ID. Previously, these were fetched separately, causing unnecessary I/O overhead and potential consistency issues. #### Major Improvements 1. Performance Optimization - Unified schema and snapshot retrieval: Combined separate API calls for schema ID and snapshot ID into a single operation - Removed redundant metadata fetches: Eliminated duplicate calls to Paimon metadata store - Optimized branch schema handling: Streamlined branch-specific schema resolution 2. Bug Fixes - Fixed timezone-related query errors: Resolved incorrect results when using Paimon time travel syntax with non-UTC timezones - Fixed branch schema consistency: Ensured snapshot ID and schema ID are always fetched atomically to prevent mismatched metadata 3. Enhanced Timestamp Format Support for FOR TIME AS OF Now supports the following timestamp formats: - YYYY-MM-DD HH:MM:SS.SSS - Full timestamp with milliseconds (e.g., 2024-01-15 10:30:45.123) - YYYY-MM-DD HH:MM:SS - Timestamp with seconds precision (e.g., 2024-01-15 10:30:45) - YYYY-MM-DD - Date only format (defaults to 00:00:00.000) (e.g., 2024-01-15) Example usage: ``` -- Using different timestamp formats SELECT * FROM paimon_table FOR TIME AS OF "2024-01-15 10:30:45.123"; SELECT * FROM paimon_table FOR TIME AS OF "2024-01-15 10:30:45"; SELECT * FROM paimon_table FOR TIME AS OF "2024-01-15"; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Following PR #55404 which addressed incorrect schema results for Paimon tables, this PR further optimizes the Paimon time travel implementation by removing redundant code and fixing the critical issue where schema ID and snapshot ID were fetched separately, causing consistency problems and unnecessary I/O overhead.
Key Problem Solved
The core challenge in Paimon time travel is efficiently constructing tables with specified snapshot ID and schema ID. Previously, these were fetched separately, causing unnecessary I/O overhead and potential consistency issues.
Major Improvements
Now supports the following timestamp formats:
Example usage:
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)