Skip to content

[opt](properties) remove old dlf properties #55555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Sep 2, 2025
Merged

[opt](properties) remove old dlf properties #55555

morningman merged 2 commits into from
Sep 2, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Sep 1, 2025

Remove old DLFProperties

@Thearas
Copy link
Contributor

Thearas commented Sep 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Sep 1, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 1, 2025

TPC-H: Total hot run time: 33930 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a11a19f70b312134b71b0d15d437fc21a7197364, data reload: false

------ Round 1 ----------------------------------
q1	17654	5131	5067	5067
q2	1981	326	212	212
q3	10265	1257	699	699
q4	10234	1012	512	512
q5	7532	2410	2330	2330
q6	181	169	141	141
q7	943	766	629	629
q8	9339	1344	1121	1121
q9	6893	5092	5167	5092
q10	6917	2400	1997	1997
q11	480	299	274	274
q12	349	367	243	243
q13	17775	3576	3006	3006
q14	240	241	217	217
q15	583	514	496	496
q16	447	430	381	381
q17	590	827	384	384
q18	7420	7028	7051	7028
q19	1632	972	552	552
q20	339	339	252	252
q21	3774	3162	2331	2331
q22	1053	1021	966	966
Total cold run time: 106621 ms
Total hot run time: 33930 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5174	5080	5050	5050
q2	251	344	232	232
q3	2144	2674	2317	2317
q4	1360	1801	1324	1324
q5	4213	4232	4522	4232
q6	210	175	129	129
q7	2093	1977	1861	1861
q8	2714	2644	2472	2472
q9	7299	7350	7353	7350
q10	3164	3277	2878	2878
q11	580	506	502	502
q12	677	816	648	648
q13	3508	3936	3247	3247
q14	297	306	279	279
q15	519	485	489	485
q16	432	480	440	440
q17	1192	1550	1392	1392
q18	7818	7688	7681	7681
q19	827	824	938	824
q20	2001	2035	1789	1789
q21	4829	4287	4264	4264
q22	1069	1062	1006	1006
Total cold run time: 52371 ms
Total hot run time: 50402 ms

@doris-robot
Copy link

doris-robot commented Sep 1, 2025

TPC-DS: Total hot run time: 186556 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a11a19f70b312134b71b0d15d437fc21a7197364, data reload: false

query1	1034	463	422	422
query2	6544	1733	1692	1692
query3	6752	229	224	224
query4	26206	23249	23632	23249
query5	4440	651	519	519
query6	336	253	228	228
query7	4685	519	305	305
query8	314	274	255	255
query9	8714	2952	2953	2952
query10	529	335	289	289
query11	15965	14942	14775	14775
query12	172	119	120	119
query13	1668	542	429	429
query14	9091	5704	5799	5704
query15	210	230	170	170
query16	7230	638	480	480
query17	1219	794	626	626
query18	2005	418	341	341
query19	206	191	168	168
query20	137	132	127	127
query21	223	132	123	123
query22	4395	4476	4232	4232
query23	33790	32899	32983	32899
query24	8136	2336	2392	2336
query25	578	516	455	455
query26	1263	298	172	172
query27	2714	521	356	356
query28	4383	2337	2298	2298
query29	831	625	516	516
query30	299	227	195	195
query31	916	791	734	734
query32	93	83	89	83
query33	581	423	370	370
query34	815	856	510	510
query35	831	831	772	772
query36	996	1028	918	918
query37	130	116	95	95
query38	3991	4036	3965	3965
query39	1513	1434	1424	1424
query40	233	137	134	134
query41	74	68	68	68
query42	181	121	120	120
query43	538	488	487	487
query44	1344	856	855	855
query45	180	177	167	167
query46	851	1045	645	645
query47	1783	1834	1748	1748
query48	387	423	319	319
query49	755	543	404	404
query50	659	686	388	388
query51	4161	4096	4077	4077
query52	121	115	102	102
query53	256	263	207	207
query54	620	597	532	532
query55	90	92	88	88
query56	364	335	317	317
query57	1195	1209	1164	1164
query58	295	287	282	282
query59	2710	2730	2601	2601
query60	373	351	332	332
query61	165	162	165	162
query62	791	743	674	674
query63	237	193	195	193
query64	4446	1175	857	857
query65	4274	4231	4190	4190
query66	1174	450	346	346
query67	15610	15313	15097	15097
query68	8689	941	583	583
query69	502	331	296	296
query70	1229	1136	1121	1121
query71	566	347	319	319
query72	5635	5002	5154	5002
query73	766	736	360	360
query74	8894	9146	8831	8831
query75	4089	3077	2643	2643
query76	3625	1139	742	742
query77	837	402	320	320
query78	9575	9808	8879	8879
query79	2559	835	610	610
query80	681	579	519	519
query81	476	263	230	230
query82	494	140	112	112
query83	301	290	243	243
query84	310	112	97	97
query85	886	547	427	427
query86	353	330	294	294
query87	4308	4340	4176	4176
query88	3181	2224	2209	2209
query89	399	330	295	295
query90	1920	224	221	221
query91	165	167	132	132
query92	97	77	69	69
query93	1646	985	641	641
query94	706	404	319	319
query95	409	328	329	328
query96	495	588	274	274
query97	2669	2692	2687	2687
query98	333	217	222	217
query99	1466	1392	1277	1277
Total cold run time: 276063 ms
Total hot run time: 186556 ms

@doris-robot
Copy link

doris-robot commented Sep 1, 2025

ClickBench: Total hot run time: 32.21 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a11a19f70b312134b71b0d15d437fc21a7197364, data reload: false

query1	0.05	0.05	0.05
query2	0.08	0.05	0.05
query3	0.25	0.08	0.09
query4	1.61	0.12	0.12
query5	0.45	0.42	0.40
query6	1.17	0.64	0.65
query7	0.03	0.03	0.02
query8	0.06	0.05	0.04
query9	0.62	0.53	0.53
query10	0.58	0.59	0.57
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.62
query14	0.81	0.83	0.84
query15	0.87	0.86	0.87
query16	0.39	0.41	0.39
query17	1.10	1.06	1.02
query18	0.22	0.19	0.20
query19	1.93	1.80	1.79
query20	0.01	0.01	0.02
query21	15.43	0.95	0.59
query22	0.79	1.19	0.64
query23	14.94	1.39	0.63
query24	7.43	0.97	0.55
query25	0.57	0.22	0.07
query26	0.66	0.17	0.14
query27	0.07	0.05	0.05
query28	8.78	0.91	0.41
query29	12.62	3.92	3.27
query30	3.05	3.02	2.92
query31	2.83	0.58	0.37
query32	3.24	0.56	0.47
query33	3.15	3.04	3.11
query34	16.03	5.45	4.85
query35	4.91	4.91	4.91
query36	0.70	0.51	0.50
query37	0.11	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.14	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 106.92 s
Total hot run time: 32.21 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 2, 2025

FE UT Coverage Report

Increment line coverage 90.91% (10/11) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 2, 2025

FE Regression Coverage Report

Increment line coverage 90.91% (10/11) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

PR approved by anyone and no changes requested.

@morningman morningman merged commit 93989a6 into apache:master Sep 2, 2025
26 of 28 checks passed
CalvinKirs pushed a commit to CalvinKirs/incubator-doris that referenced this pull request Sep 18, 2025
@morningman @CalvinKirs
branch-3.1:[opt](properties) remove old dlf properties (apache#55555)
030d334 
apache#55555
@CalvinKirs CalvinKirs mentioned this pull request Sep 18, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 25, 2025
@CalvinKirs @morningman
branch-3.1: [opt](properties) remove old dlf properties #55555 (#56196)
247bab2 
cherry pick #55555

---------

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@morningman @Thearas @doris-robot @hello-stephen @CalvinKirs @zy-kkk @morrySnow