Skip to content

[feat](txn) Add txn write amplification brpc metrics #55544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Sep 24, 2025
Merged

[feat](txn) Add txn write amplification brpc metrics #55544

dataroaring merged 1 commit into from
Sep 24, 2025

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Sep 1, 2025

What problem does this PR solve?

add transaction write amplification brpc metrics

max and avg

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat wyxxxcat force-pushed the wa_metrics branch 6 times, most recently from e567b11 to 790a299 Compare September 2, 2025 03:38
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 2, 2025

run buildall

liaoxin01
liaoxin01 previously approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

PR approved by anyone and no changes requested.

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 2, 2025

run cloudut

@doris-robot
Copy link

doris-robot commented Sep 2, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.60% (1467/1734)
Line Coverage 67.79% (26181/38618)
Region Coverage 68.75% (13013/18928)
Branch Coverage 58.73% (6965/11860)

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 2, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 2, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 2, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (8/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.60% (1467/1734)
Line Coverage 67.77% (26173/38620)
Region Coverage 68.77% (13017/18928)
Branch Coverage 58.68% (6960/11860)

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 2, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 2, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (8/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.60% (1467/1734)
Line Coverage 67.81% (26192/38628)
Region Coverage 68.76% (13019/18935)
Branch Coverage 58.76% (6973/11866)

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 3, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 3, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (8/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.60% (1467/1734)
Line Coverage 67.87% (26217/38628)
Region Coverage 68.81% (13030/18935)
Branch Coverage 58.76% (6973/11866)

dataroaring
dataroaring previously approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

PR approved by at least one committer and no changes requested.

@wyxxxcat wyxxxcat force-pushed the wa_metrics branch 4 times, most recently from 0dea932 to 0fddc9f Compare September 16, 2025 09:32
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 16, 2025

Cloud UT Coverage Report

Increment line coverage 80.71% (113/140) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.04% (1548/1842)
Line Coverage 68.15% (27667/40598)
Region Coverage 68.54% (13612/19861)
Branch Coverage 58.82% (7269/12358)

@dataroaring
Copy link
Contributor

dataroaring commented Sep 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 19, 2025

Cloud UT Coverage Report

Increment line coverage 86.58% (129/149) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.19% (1560/1853)
Line Coverage 68.07% (27744/40759)
Region Coverage 68.43% (13652/19949)
Branch Coverage 58.68% (7277/12402)

gavinchou
gavinchou reviewed Sep 21, 2025
View reviewed changes
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 22, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 22, 2025

Cloud UT Coverage Report

Increment line coverage 86.67% (130/150) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.96% (1560/1858)
Line Coverage 67.91% (27753/40865)
Region Coverage 68.20% (13643/20005)
Branch Coverage 58.55% (7282/12438)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit a4a4c4a into apache:master Sep 24, 2025
26 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 24, 2025
@wyxxxcat
[feat](txn) Add txn write amplification brpc metrics (#55544)
ebead07 
### What problem does this PR solve?

add transaction write amplification brpc metrics
@github-actions github-actions bot mentioned this pull request Sep 24, 2025
Closed
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Oct 11, 2025
@wyxxxcat
[feat](txn) Add txn write amplification brpc metrics (apache#55544)
2e723bc 
add transaction write amplification brpc metrics
@wyxxxcat wyxxxcat mentioned this pull request Oct 11, 2025
Merged
morrySnow pushed a commit that referenced this pull request Oct 13, 2025
@wyxxxcat
branch-3.1: [feat](txn) Add txn write amplification brpc metrics #55544…
cc9dc33 
… (#56832)

picked from #55544
w41ter pushed a commit to w41ter/incubator-doris that referenced this pull request Dec 26, 2025
@wyxxxcat
[feat](txn) Add txn write amplification brpc metrics apache#55544 (ap…
528c178 
…ache#4944)

add transaction write amplification brpc metrics

pick: apache#55544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@liaoxin01 liaoxin01 liaoxin01 left review comments

@dataroaring dataroaring dataroaring left review comments

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

+1 more reviewer

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.2-merged dev/4.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@wyxxxcat @Thearas @doris-robot @hello-stephen @dataroaring @gavinchou @liaoxin01 @Yukang-Lian @yiguolei @morrySnow