Skip to content

[fix](multi-catalog) check paramType for TableScanParams #55364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Sep 2, 2025
Merged

[fix](multi-catalog) check paramType for TableScanParams #55364

morningman merged 2 commits into from
Sep 2, 2025

Conversation

@suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Aug 27, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Aug 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Aug 27, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 27, 2025

TPC-H: Total hot run time: 34011 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit be58eefa1ee90476bf60b9913a150e3acb0b9875, data reload: false

------ Round 1 ----------------------------------
q1	17614	5226	5050	5050
q2	1972	344	224	224
q3	10244	1380	772	772
q4	10240	1026	529	529
q5	7530	2329	2355	2329
q6	193	174	145	145
q7	937	772	642	642
q8	9349	1361	1043	1043
q9	7105	5101	5122	5101
q10	6905	2417	2006	2006
q11	491	289	292	289
q12	345	353	219	219
q13	17763	3631	3000	3000
q14	231	242	222	222
q15	548	499	498	498
q16	436	426	378	378
q17	579	850	371	371
q18	7768	7243	7076	7076
q19	1090	960	565	565
q20	351	345	220	220
q21	3751	2554	2353	2353
q22	1077	1052	979	979
Total cold run time: 106519 ms
Total hot run time: 34011 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5113	5057	5329	5057
q2	256	331	224	224
q3	2175	2642	2320	2320
q4	1353	1790	1357	1357
q5	4198	4291	4666	4291
q6	215	174	135	135
q7	2035	2019	1817	1817
q8	2642	2610	2622	2610
q9	7568	7437	7442	7437
q10	3158	3356	2843	2843
q11	584	508	525	508
q12	746	811	634	634
q13	3506	3891	3271	3271
q14	297	320	308	308
q15	526	471	473	471
q16	444	497	436	436
q17	1163	1495	1450	1450
q18	7922	7822	7554	7554
q19	819	846	852	846
q20	1994	2016	1989	1989
q21	5113	4516	4256	4256
q22	1068	1021	1015	1015
Total cold run time: 52895 ms
Total hot run time: 50829 ms

@doris-robot
Copy link

doris-robot commented Aug 27, 2025

TPC-DS: Total hot run time: 186765 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit be58eefa1ee90476bf60b9913a150e3acb0b9875, data reload: false

query1	1075	467	411	411
query2	6554	1756	1764	1756
query3	6748	230	227	227
query4	26504	23223	23204	23204
query5	4391	691	504	504
query6	347	240	252	240
query7	4655	505	309	309
query8	305	270	255	255
query9	8607	2911	2865	2865
query10	505	353	304	304
query11	15771	15042	14655	14655
query12	182	120	118	118
query13	1670	562	435	435
query14	10093	5790	5670	5670
query15	214	185	177	177
query16	7673	671	530	530
query17	1368	744	611	611
query18	2053	428	361	361
query19	209	203	173	173
query20	126	132	121	121
query21	221	132	111	111
query22	4239	4341	4133	4133
query23	33999	32896	32912	32896
query24	7931	2365	2357	2357
query25	564	529	437	437
query26	1262	292	169	169
query27	2721	510	359	359
query28	4368	2266	2260	2260
query29	801	586	481	481
query30	292	232	201	201
query31	918	798	722	722
query32	92	81	79	79
query33	571	392	354	354
query34	838	853	526	526
query35	830	825	756	756
query36	969	1051	909	909
query37	126	115	90	90
query38	4041	4043	3935	3935
query39	1499	1430	1443	1430
query40	222	131	126	126
query41	73	65	72	65
query42	127	112	115	112
query43	516	514	480	480
query44	1340	869	858	858
query45	188	174	178	174
query46	875	1008	652	652
query47	1773	1811	1736	1736
query48	394	436	314	314
query49	749	523	414	414
query50	646	674	399	399
query51	4143	4164	4097	4097
query52	121	115	108	108
query53	247	267	211	211
query54	615	638	544	544
query55	92	92	97	92
query56	339	327	315	315
query57	1192	1208	1129	1129
query58	287	283	283	283
query59	2604	2805	2659	2659
query60	368	351	366	351
query61	166	167	184	167
query62	852	754	663	663
query63	240	206	200	200
query64	4455	1183	984	984
query65	4313	4206	4188	4188
query66	1128	459	375	375
query67	15564	15288	15126	15126
query68	8090	929	603	603
query69	510	342	308	308
query70	1197	1197	1127	1127
query71	456	352	330	330
query72	5974	5067	5138	5067
query73	706	678	359	359
query74	9209	9161	8901	8901
query75	3399	3068	2657	2657
query76	3343	1135	732	732
query77	890	410	333	333
query78	9538	9886	8879	8879
query79	2226	807	603	603
query80	653	563	511	511
query81	492	259	237	237
query82	519	139	109	109
query83	270	263	263	263
query84	249	117	94	94
query85	879	480	488	480
query86	399	341	318	318
query87	4273	4391	4232	4232
query88	3627	2240	2240	2240
query89	398	358	297	297
query90	1957	231	236	231
query91	162	167	133	133
query92	92	75	71	71
query93	1848	1018	649	649
query94	739	423	316	316
query95	409	337	328	328
query96	491	573	278	278
query97	2732	2689	2607	2607
query98	253	223	223	223
query99	1416	1431	1296	1296
Total cold run time: 276357 ms
Total hot run time: 186765 ms

@doris-robot
Copy link

doris-robot commented Aug 27, 2025

ClickBench: Total hot run time: 32.5 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit be58eefa1ee90476bf60b9913a150e3acb0b9875, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.09	0.08
query4	1.61	0.11	0.11
query5	0.47	0.44	0.42
query6	1.20	0.65	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.61	0.53	0.53
query10	0.58	0.59	0.57
query11	0.17	0.12	0.12
query12	0.16	0.13	0.13
query13	0.64	0.64	0.62
query14	0.80	0.84	0.83
query15	0.89	0.86	0.86
query16	0.42	0.43	0.38
query17	1.03	1.06	1.05
query18	0.22	0.21	0.20
query19	1.86	1.86	1.84
query20	0.01	0.01	0.02
query21	15.44	0.94	0.60
query22	0.78	1.04	0.65
query23	15.11	1.40	0.62
query24	6.56	1.59	0.40
query25	0.47	0.28	0.20
query26	0.60	0.16	0.13
query27	0.06	0.05	0.06
query28	10.36	0.98	0.44
query29	12.61	3.90	3.24
query30	3.06	3.07	2.97
query31	2.83	0.58	0.39
query32	3.24	0.57	0.46
query33	3.21	3.17	3.08
query34	15.94	5.50	4.90
query35	4.91	4.96	4.93
query36	0.69	0.50	0.49
query37	0.10	0.07	0.07
query38	0.07	0.05	0.04
query39	0.03	0.03	0.04
query40	0.19	0.15	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 107.59 s
Total hot run time: 32.5 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 27, 2025

FE UT Coverage Report

Increment line coverage 60.00% (3/5) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

PR approved by anyone and no changes requested.

@suxiaogang223 suxiaogang223 mentioned this pull request Aug 28, 2025
Merged
morningman pushed a commit that referenced this pull request Aug 28, 2025
@suxiaogang223
branch-3.1: [fix](paimon) get the correct schema when querying paimon…
6299866 
… table #55070 #55364 (#55404)

bp:
- get the correct schema when querying paimon table #55070
- [fix](multi-catalog) check paramType for TableScanParams #55364
wm1581066
wm1581066 approved these changes Sep 1, 2025
View reviewed changes
Copy link
Collaborator

@wm1581066 wm1581066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 5488b12 into apache:master Sep 2, 2025
28 of 30 checks passed
@suxiaogang223 suxiaogang223 deleted the validate_scan_params branch September 23, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

+1 more reviewer

@wm1581066 wm1581066 wm1581066 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@suxiaogang223 @Thearas @doris-robot @hello-stephen @morningman @wm1581066