Skip to content

[fix](nereids)fix some show command's redirect policy #55185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 1 commit into from
Oct 14, 2025
Merged

[fix](nereids)fix some show command's redirect policy #55185

starocean999 merged 1 commit into from
Oct 14, 2025

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Aug 22, 2025 •
edited
Loading

What problem does this PR solve?

make the command's redirect policy same as old planner:

ShowBackupStmt
ShowConfigStmt
ShowRestoreStmt
ShowWorkloadGroupsStmt

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Aug 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

starocean999 commented Aug 22, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 22, 2025

TPC-H: Total hot run time: 34108 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bbd71718af32a8796a894af04fde5f9c0abe3b94, data reload: false

------ Round 1 ----------------------------------
q1	17566	5293	5155	5155
q2	1949	283	189	189
q3	10296	1299	705	705
q4	10231	999	536	536
q5	7480	2379	2366	2366
q6	173	160	129	129
q7	881	729	600	600
q8	9304	1291	1087	1087
q9	6920	5086	5086	5086
q10	6879	2368	1988	1988
q11	491	296	275	275
q12	348	343	223	223
q13	17774	3687	3046	3046
q14	228	236	216	216
q15	545	494	479	479
q16	423	427	383	383
q17	590	910	365	365
q18	7409	7213	7161	7161
q19	1241	954	570	570
q20	349	336	223	223
q21	3847	2553	2334	2334
q22	1074	1028	992	992
Total cold run time: 105998 ms
Total hot run time: 34108 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5206	5122	5139	5122
q2	245	322	222	222
q3	2232	2666	2308	2308
q4	1342	1806	1414	1414
q5	4200	4476	4541	4476
q6	217	170	127	127
q7	2063	1966	1862	1862
q8	2658	2650	2595	2595
q9	7347	7267	7262	7262
q10	3191	3279	2856	2856
q11	575	511	499	499
q12	688	788	686	686
q13	3564	3858	3361	3361
q14	327	328	281	281
q15	525	503	487	487
q16	473	506	461	461
q17	1159	1793	1436	1436
q18	8013	7635	7565	7565
q19	804	843	850	843
q20	1989	2019	1892	1892
q21	4710	4382	4258	4258
q22	1088	1024	980	980
Total cold run time: 52616 ms
Total hot run time: 50993 ms

@doris-robot
Copy link

doris-robot commented Aug 22, 2025

TPC-DS: Total hot run time: 183977 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bbd71718af32a8796a894af04fde5f9c0abe3b94, data reload: false

query1	987	399	403	399
query2	6536	1769	1777	1769
query3	6747	225	219	219
query4	26285	23077	23331	23077
query5	4371	616	498	498
query6	325	230	202	202
query7	4631	498	288	288
query8	297	254	223	223
query9	8570	2908	2827	2827
query10	492	329	278	278
query11	15781	15002	14745	14745
query12	168	115	114	114
query13	1651	532	412	412
query14	9666	5728	5793	5728
query15	209	190	161	161
query16	7643	644	483	483
query17	1181	707	569	569
query18	2020	403	305	305
query19	194	221	159	159
query20	127	119	113	113
query21	215	130	107	107
query22	4061	4090	4049	4049
query23	33878	32839	32767	32767
query24	8003	2343	2334	2334
query25	536	471	414	414
query26	1239	278	155	155
query27	2752	502	340	340
query28	4333	2259	2233	2233
query29	734	558	456	456
query30	297	223	186	186
query31	915	816	697	697
query32	84	74	74	74
query33	557	409	331	331
query34	773	856	512	512
query35	817	814	744	744
query36	964	1031	914	914
query37	117	106	89	89
query38	4045	4091	3990	3990
query39	1483	1427	1396	1396
query40	220	125	122	122
query41	60	59	53	53
query42	118	108	113	108
query43	506	503	474	474
query44	1348	858	855	855
query45	180	171	167	167
query46	861	1010	634	634
query47	1737	1804	1712	1712
query48	375	424	319	319
query49	729	492	384	384
query50	635	664	400	400
query51	4119	4100	4064	4064
query52	113	110	94	94
query53	232	253	194	194
query54	603	584	521	521
query55	88	87	93	87
query56	316	308	317	308
query57	1155	1196	1142	1142
query58	283	295	279	279
query59	2583	2842	2640	2640
query60	367	340	340	340
query61	128	117	120	117
query62	825	722	657	657
query63	224	185	190	185
query64	4284	1046	706	706
query65	4287	4202	4225	4202
query66	1063	403	319	319
query67	15623	15273	14944	14944
query68	5521	922	583	583
query69	483	326	281	281
query70	1204	1128	1120	1120
query71	419	333	306	306
query72	5493	4856	4804	4804
query73	669	625	357	357
query74	8944	9210	8609	8609
query75	3149	3070	2623	2623
query76	3255	1122	743	743
query77	481	395	325	325
query78	9522	9594	8836	8836
query79	2319	805	604	604
query80	722	540	482	482
query81	510	252	223	223
query82	390	143	102	102
query83	258	250	239	239
query84	250	109	85	85
query85	790	378	341	341
query86	340	306	301	301
query87	4264	4233	4156	4156
query88	2815	2211	2164	2164
query89	395	364	296	296
query90	1775	222	219	219
query91	140	138	110	110
query92	79	71	68	68
query93	1160	1001	655	655
query94	670	405	311	311
query95	400	318	305	305
query96	495	587	275	275
query97	2602	2709	2584	2584
query98	239	217	218	217
query99	1321	1425	1269	1269
Total cold run time: 267820 ms
Total hot run time: 183977 ms

@doris-robot
Copy link

doris-robot commented Aug 22, 2025

ClickBench: Total hot run time: 32.26 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bbd71718af32a8796a894af04fde5f9c0abe3b94, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.24	0.08	0.08
query4	1.60	0.11	0.11
query5	0.44	0.42	0.40
query6	1.17	0.64	0.64
query7	0.03	0.03	0.02
query8	0.04	0.03	0.03
query9	0.59	0.54	0.52
query10	0.60	0.58	0.58
query11	0.16	0.10	0.10
query12	0.15	0.12	0.11
query13	0.62	0.62	0.61
query14	0.80	0.83	0.84
query15	0.88	0.85	0.85
query16	0.39	0.38	0.38
query17	1.04	1.03	1.04
query18	0.21	0.20	0.20
query19	1.89	1.82	1.81
query20	0.02	0.01	0.01
query21	15.38	0.97	0.60
query22	0.78	1.21	0.74
query23	14.81	1.41	0.65
query24	6.65	0.82	0.32
query25	0.56	0.21	0.12
query26	0.56	0.16	0.12
query27	0.06	0.05	0.06
query28	9.55	1.04	0.43
query29	12.67	3.96	3.26
query30	3.04	2.97	2.97
query31	2.82	0.61	0.38
query32	3.23	0.54	0.46
query33	3.13	3.13	3.11
query34	16.21	5.53	4.87
query35	4.88	4.97	4.94
query36	0.69	0.50	0.51
query37	0.10	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.15	0.14
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.51 s
Total hot run time: 32.26 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 22, 2025

FE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@starocean999
Copy link
Contributor Author

starocean999 commented Oct 11, 2025

run buildall

@starocean999 starocean999 changed the title [fix](planner)nullableFromNereids is lost when clone Expr [fix](nereids)fix some show command's redirect policy Oct 11, 2025
@doris-robot
Copy link

doris-robot commented Oct 11, 2025

TPC-DS: Total hot run time: 190663 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8d0b79b2e0fd82b791438c44a8cac69decdee774, data reload: false

query1	1086	459	415	415
query2	6552	1718	1698	1698
query3	6762	222	220	220
query4	26599	24016	23255	23255
query5	5502	641	480	480
query6	352	243	216	216
query7	4664	486	301	301
query8	329	260	282	260
query9	8706	2587	2582	2582
query10	517	354	283	283
query11	15457	15059	14984	14984
query12	179	117	112	112
query13	1686	576	439	439
query14	11132	9312	9258	9258
query15	215	190	180	180
query16	7671	668	491	491
query17	1343	750	637	637
query18	2060	475	363	363
query19	219	239	179	179
query20	147	135	126	126
query21	226	139	123	123
query22	4546	4690	4653	4653
query23	35088	33832	33968	33832
query24	8742	2536	2604	2536
query25	589	528	475	475
query26	1290	294	179	179
query27	2962	537	379	379
query28	4509	2219	2229	2219
query29	858	649	535	535
query30	315	231	208	208
query31	930	873	783	783
query32	90	73	75	73
query33	597	423	337	337
query34	827	887	550	550
query35	892	901	813	813
query36	1033	1102	959	959
query37	126	117	82	82
query38	3474	3544	3518	3518
query39	1485	1425	1421	1421
query40	221	134	127	127
query41	61	58	59	58
query42	123	120	109	109
query43	478	491	475	475
query44	1327	837	833	833
query45	181	182	173	173
query46	838	997	650	650
query47	1791	1805	1711	1711
query48	399	419	332	332
query49	771	552	396	396
query50	645	692	413	413
query51	3976	3983	3871	3871
query52	111	114	99	99
query53	233	266	209	209
query54	601	592	527	527
query55	87	81	86	81
query56	341	342	317	317
query57	1177	1188	1147	1147
query58	290	273	268	268
query59	2521	2644	2544	2544
query60	349	358	327	327
query61	153	155	153	153
query62	812	750	667	667
query63	245	212	201	201
query64	4615	1262	919	919
query65	4134	4016	3954	3954
query66	1043	437	337	337
query67	15553	15337	15039	15039
query68	8008	946	595	595
query69	503	321	292	292
query70	1286	1324	1336	1324
query71	510	346	329	329
query72	5855	4960	4964	4960
query73	685	612	361	361
query74	9247	9314	8472	8472
query75	4127	3419	2846	2846
query76	3632	1178	747	747
query77	822	404	326	326
query78	9555	9781	8997	8997
query79	1862	812	614	614
query80	653	561	507	507
query81	500	260	236	236
query82	453	162	131	131
query83	275	274	256	256
query84	255	112	93	93
query85	939	546	508	508
query86	434	323	300	300
query87	3742	3766	3713	3713
query88	3022	2377	2262	2262
query89	398	341	304	304
query90	2035	222	218	218
query91	168	174	132	132
query92	80	68	68	68
query93	1108	989	650	650
query94	695	457	337	337
query95	398	325	312	312
query96	483	583	289	289
query97	2974	2995	2872	2872
query98	237	221	208	208
query99	1436	1412	1313	1313
Total cold run time: 279210 ms
Total hot run time: 190663 ms

@doris-robot
Copy link

doris-robot commented Oct 11, 2025

ClickBench: Total hot run time: 30.22 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8d0b79b2e0fd82b791438c44a8cac69decdee774, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.06	0.06
query3	0.25	0.08	0.08
query4	1.60	0.12	0.12
query5	0.28	0.27	0.25
query6	1.17	0.66	0.64
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.61	0.52	0.53
query10	0.61	0.59	0.58
query11	0.16	0.11	0.11
query12	0.16	0.12	0.12
query13	0.64	0.63	0.61
query14	1.02	1.03	1.02
query15	0.87	0.88	0.89
query16	0.41	0.41	0.40
query17	1.07	1.13	1.10
query18	0.21	0.21	0.20
query19	1.96	1.87	1.90
query20	0.01	0.01	0.02
query21	15.40	0.94	0.57
query22	0.76	1.26	0.72
query23	14.78	1.34	0.65
query24	7.72	1.24	0.50
query25	0.51	0.26	0.07
query26	0.63	0.16	0.14
query27	0.07	0.06	0.06
query28	8.83	1.35	0.93
query29	12.59	3.85	3.22
query30	0.29	0.14	0.11
query31	2.82	0.59	0.38
query32	3.26	0.57	0.47
query33	3.07	3.08	3.07
query34	16.11	5.50	4.85
query35	4.97	4.91	4.90
query36	0.70	0.52	0.51
query37	0.10	0.08	0.07
query38	0.06	0.05	0.04
query39	0.03	0.03	0.03
query40	0.17	0.15	0.15
query41	0.09	0.03	0.04
query42	0.03	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 104.27 s
Total hot run time: 30.22 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

FE Regression Coverage Report

Increment line coverage 60.00% (6/10) 🎉
Increment coverage report
Complete coverage report

2 similar comments
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

FE Regression Coverage Report

Increment line coverage 60.00% (6/10) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

FE Regression Coverage Report

Increment line coverage 60.00% (6/10) 🎉
Increment coverage report
Complete coverage report

@starocean999 starocean999 marked this pull request as ready for review October 13, 2025 06:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 588c37b into apache:master Oct 14, 2025
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 14, 2025
@starocean999
[fix](nereids)fix some show command's redirect policy (#55185)
65bd908 
make the command's redirect policy same as old planner:
```
ShowBackupStmt
ShowConfigStmt
ShowRestoreStmt
ShowWorkloadGroupsStmt
```
@github-actions github-actions bot mentioned this pull request Oct 14, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 16, 2025
@github-actions @starocean999
branch-4.0: [fix](nereids)fix some show command's redirect policy #55185
3e8f5b8 
 (#56952)

Cherry-picked from #55185

Co-authored-by: starocean999 <lichi@selectdb.com>
@yiguolei yiguolei mentioned this pull request Nov 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@starocean999 @Thearas @doris-robot @hello-stephen @englefly @morrySnow @yiguolei