Skip to content

[fix](filecache) remove unnecessary debug log #53348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 1 commit into from
Jul 17, 2025
Merged

[fix](filecache) remove unnecessary debug log #53348

gavinchou merged 1 commit into from
Jul 17, 2025

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Jul 16, 2025 •
edited
Loading

this log print too much, remove it

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
[fix](filecache) remove unnecessary debug log
45f8273 
this log print too much, remove it

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

freemandealer commented Jul 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

TPC-H: Total hot run time: 33349 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 45f827339f47672c800bb9324e3b3d4ec880df9f, data reload: false

------ Round 1 ----------------------------------
q1	17601	5319	5102	5102
q2	1937	286	182	182
q3	10328	1290	736	736
q4	10224	991	529	529
q5	7542	2403	2347	2347
q6	180	159	129	129
q7	910	746	592	592
q8	9310	1216	1102	1102
q9	7030	5148	5184	5148
q10	6883	2389	1954	1954
q11	481	287	271	271
q12	345	351	221	221
q13	17773	3714	3068	3068
q14	227	239	224	224
q15	545	488	481	481
q16	422	428	375	375
q17	608	865	382	382
q18	7551	7182	7109	7109
q19	1076	947	557	557
q20	344	319	213	213
q21	4062	3203	2332	2332
q22	362	325	295	295
Total cold run time: 105741 ms
Total hot run time: 33349 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5151	5218	5135	5135
q2	248	322	218	218
q3	2150	2672	2285	2285
q4	1397	1789	1348	1348
q5	4241	4330	4671	4330
q6	208	166	123	123
q7	2048	1948	1806	1806
q8	2587	2616	2530	2530
q9	7416	7404	7513	7404
q10	3091	3256	2770	2770
q11	583	524	514	514
q12	686	787	627	627
q13	3642	4008	3359	3359
q14	284	303	279	279
q15	533	499	480	480
q16	481	495	468	468
q17	1180	1576	1376	1376
q18	8139	7584	7718	7584
q19	804	824	924	824
q20	1982	2094	1957	1957
q21	5050	4648	4521	4521
q22	612	651	578	578
Total cold run time: 52513 ms
Total hot run time: 50516 ms

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

TPC-DS: Total hot run time: 188819 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 45f827339f47672c800bb9324e3b3d4ec880df9f, data reload: false

query1	981	391	376	376
query2	6501	1800	1812	1800
query3	6740	213	212	212
query4	26290	23954	23003	23003
query5	4301	573	441	441
query6	313	210	200	200
query7	4630	487	287	287
query8	271	231	217	217
query9	8632	2617	2620	2617
query10	467	329	256	256
query11	15573	15173	14908	14908
query12	144	107	101	101
query13	1651	508	388	388
query14	8499	6063	5973	5973
query15	202	207	161	161
query16	7151	424	257	257
query17	1341	693	573	573
query18	1982	402	299	299
query19	190	191	160	160
query20	129	123	118	118
query21	212	124	102	102
query22	4191	4369	4604	4369
query23	34860	34299	34275	34275
query24	8422	2359	2363	2359
query25	536	460	376	376
query26	1218	256	140	140
query27	2802	506	350	350
query28	4314	2115	2086	2086
query29	776	539	421	421
query30	282	217	193	193
query31	907	864	782	782
query32	71	63	57	57
query33	564	341	278	278
query34	810	831	526	526
query35	627	634	563	563
query36	955	1002	922	922
query37	113	100	77	77
query38	4091	4089	4054	4054
query39	1482	1467	1435	1435
query40	214	122	112	112
query41	67	93	53	53
query42	116	115	106	106
query43	517	531	495	495
query44	1354	824	831	824
query45	182	189	168	168
query46	827	1013	619	619
query47	1763	1802	1699	1699
query48	387	450	308	308
query49	736	466	377	377
query50	677	688	398	398
query51	5478	5506	5226	5226
query52	106	104	100	100
query53	231	249	182	182
query54	572	554	490	490
query55	78	79	80	79
query56	291	299	285	285
query57	1186	1196	1136	1136
query58	263	246	302	246
query59	2745	2782	2648	2648
query60	337	305	306	305
query61	119	119	119	119
query62	788	734	676	676
query63	238	187	189	187
query64	4443	1163	845	845
query65	4247	4243	4155	4155
query66	1134	423	340	340
query67	16253	15709	15570	15570
query68	7858	906	515	515
query69	521	309	272	272
query70	1239	1165	1149	1149
query71	436	333	307	307
query72	5586	4817	4828	4817
query73	669	642	342	342
query74	8887	9218	8863	8863
query75	3736	3182	2707	2707
query76	3442	1139	716	716
query77	770	412	288	288
query78	10886	11040	10345	10345
query79	1867	850	590	590
query80	592	555	431	431
query81	477	251	213	213
query82	174	119	93	93
query83	254	247	236	236
query84	245	98	91	91
query85	765	362	314	314
query86	372	298	285	285
query87	4476	4510	4350	4350
query88	3346	2288	2269	2269
query89	389	318	292	292
query90	1978	212	204	204
query91	137	136	109	109
query92	76	59	56	56
query93	1818	937	576	576
query94	626	312	204	204
query95	387	290	339	290
query96	489	571	281	281
query97	2750	2812	2663	2663
query98	222	200	198	198
query99	1354	1399	1293	1293
Total cold run time: 275394 ms
Total hot run time: 188819 ms

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

ClickBench: Total hot run time: 32.28 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 45f827339f47672c800bb9324e3b3d4ec880df9f, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.05	0.04
query3	0.24	0.07	0.07
query4	1.63	0.11	0.11
query5	0.44	0.44	0.42
query6	1.18	0.66	0.68
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.59	0.52	0.51
query10	0.58	0.58	0.57
query11	0.17	0.11	0.11
query12	0.15	0.11	0.12
query13	0.63	0.62	0.61
query14	0.82	0.79	0.80
query15	0.89	0.86	0.86
query16	0.39	0.39	0.40
query17	1.03	1.06	1.04
query18	0.22	0.22	0.21
query19	1.98	1.91	1.86
query20	0.01	0.02	0.02
query21	15.38	0.87	0.54
query22	0.76	1.40	0.67
query23	14.78	1.38	0.60
query24	6.78	1.37	0.69
query25	0.46	0.26	0.09
query26	0.68	0.17	0.15
query27	0.06	0.06	0.06
query28	9.63	0.88	0.44
query29	12.54	3.94	3.27
query30	3.00	2.93	2.95
query31	2.83	0.58	0.38
query32	3.23	0.56	0.48
query33	3.06	3.05	3.19
query34	15.91	5.44	4.78
query35	4.88	4.85	4.85
query36	0.66	0.52	0.50
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.14
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.02	0.02
Total cold run time: 106.27 s
Total hot run time: 32.28 s

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.51% (15741/27370)
Line Coverage 46.15% (140386/304169)
Region Coverage 35.47% (104709/295241)
Branch Coverage 38.05% (46134/121254)

dataroaring
dataroaring approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 16, 2025

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

@gavinchou gavinchou merged commit acdaab6 into apache:master Jul 17, 2025
31 of 35 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 17, 2025
@freemandealer
[fix](filecache) remove unnecessary debug log (#53348)
2d92c6b
@github-actions github-actions bot mentioned this pull request Jul 17, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 18, 2025
@github-actions @freemandealer
branch-3.1: [fix](filecache) remove unnecessary debug log #53348 (#53456
f049d5d 
)

Cherry-picked from #53348

Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>
freemandealer added a commit to freemandealer/doris that referenced this pull request Jul 22, 2025
@freemandealer
[fix](filecache) remove unnecessary debug log (apache#53348)
7d3855a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@freemandealer @hello-stephen @doris-robot @gavinchou @dataroaring @morrySnow