[Improvement](cloud) Hold tablets in another RPC thread #52879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33223 ms |
TPC-DS: Total hot run time: 185577 ms |
ClickBench: Total hot run time: 29.84 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33231 ms |
TPC-DS: Total hot run time: 185766 ms |
ClickBench: Total hot run time: 29.72 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33335 ms |
TPC-DS: Total hot run time: 184087 ms |
ClickBench: Total hot run time: 29.78 s |
Contributor
Author
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33354 ms |
TPC-DS: Total hot run time: 187594 ms |
ClickBench: Total hot run time: 29.88 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
reviewed
Jul 16, 2025
|
|
||
| Status OlapScanLocalState::init(RuntimeState* state, LocalStateInfo& info) { | ||
| RETURN_IF_ERROR(Base::init(state, info)); | ||
| RETURN_IF_ERROR(_sync_cloud_tablets(state)); |
Contributor
There was a problem hiding this comment.
这个_sync_cloud_tablets 实际是一个执行逻辑，但是我们把他放到了一个初始化的逻辑里，可能会有一些不可预期的问题
yiguolei
reviewed
Jul 16, 2025
| _tablets.resize(_scan_ranges.size()); | ||
| _tasks.reserve(_scan_ranges.size()); | ||
| _sync_statistics.resize(_scan_ranges.size()); | ||
| SCOPED_RAW_TIMER(&_duration_ns); |
Contributor
There was a problem hiding this comment.
这个_duration_ns 似乎没用，因为底下这个调用是异步的。
可能我们需要跟踪一下那个dependency的时间，比如他set ready的时候，记录一个时间，这样才是准确的。
Contributor
Author
|
run buildall |
yiguolei
approved these changes
Jul 16, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34017 ms |
TPC-DS: Total hot run time: 186876 ms |
ClickBench: Total hot run time: 31.95 s |
Mryange
approved these changes
Jul 16, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Jul 17, 2025
With cloud mode on, remote tablets will be loaded into local storage before execution. This will block execution thread now. If it's too slow, pipeline execution thread may hang. This PR makes remote tablets loading asynchronously.
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Jul 22, 2025
With cloud mode on, remote tablets will be loaded into local storage before execution. This will block execution thread now. If it's too slow, pipeline execution thread may hang. This PR makes remote tablets loading asynchronously.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
With cloud mode on, remote tablets will be loaded into local storage before execution. This will block execution thread now. If it's too slow, pipeline execution thread may hang.
This PR makes remote tablets loading asynchronously.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)