Skip to content

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Jan 19, 2021

Proposed changes

If there are too large fields in the table, there may be only one row in each page, and this row also has a zone map index
This causes the stored data to expand three times the original data,
It also takes up more memory when reading those segments
Therefore, we need to Disable the creation of zonemap indexes for segments with too few rows

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix Disable creating zonemap index for too large column #5237) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If these changes need document changes, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman self-assigned this Jan 23, 2021
@morningman morningman added area/storage Issues or PRs related to storage engine kind/improvement labels Jan 23, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jan 23, 2021
@morningman morningman merged commit 139709d into apache:master Jan 24, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
If there are too large fields in the table, there may be only one row in each page,
and this row also has a zone map index
This causes the stored data to expand three times the original data,
It also takes up more memory when reading those segments
Therefore, we need to Disable the creation of zonemap indexes for segments with too few rows

Change-Id: I5843e13cd4a2cd9c3596e8582f9e4805c9df7029
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
@yangzhg yangzhg deleted the opt_zonemap branch April 12, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/storage Issues or PRs related to storage engine kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable creating zonemap index for too large column

2 participants