-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](mow) Fix DeleteBitmap's assignment operator and constructor
#52582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
3f35215 to
f2b5fd6
Compare
|
run buildall |
ad7580a to
44b81ca
Compare
DeleteBitmap's assignment operatorDeleteBitmap's assignment operator and constructor
44b81ca to
03cb0db
Compare
TPC-H: Total hot run time: 33290 ms |
98cb439 to
7e54575
Compare
TPC-DS: Total hot run time: 185012 ms |
7e54575 to
60db2a4
Compare
ClickBench: Total hot run time: 29.6 s |
60db2a4 to
54c8ec9
Compare
|
run buildall |
TPC-H: Total hot run time: 35579 ms |
TPC-DS: Total hot run time: 189317 ms |
ClickBench: Total hot run time: 30.05 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run cloud_p0 |
TPC-DS: Total hot run time: 185161 ms |
ClickBench: Total hot run time: 29.67 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run cloud_p0 |
|
run external |
925f1a8 to
b250027
Compare
|
run buildall |
TPC-H: Total hot run time: 33149 ms |
TPC-DS: Total hot run time: 185763 ms |
ClickBench: Total hot run time: 29.31 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…52582) ### What problem does this PR solve? Currently, `DeleteBitmap`'s wrong move assignment operator can cause correctness problem on mow table if SC's alter process produce delete bitmaps when calculating delete bitmaps for incremental rowsets after the modification in `CloudSchemaChangeJob::_process_delete_bitmap` of #52440 because `origin_dbm` and `delete_bitmap` refer to the same `DeleteBitmap` object. 
…52582) ### What problem does this PR solve? Currently, `DeleteBitmap`'s wrong move assignment operator can cause correctness problem on mow table if SC's alter process produce delete bitmaps when calculating delete bitmaps for incremental rowsets after the modification in `CloudSchemaChangeJob::_process_delete_bitmap` of #52440 because `origin_dbm` and `delete_bitmap` refer to the same `DeleteBitmap` object. 
…r and constructor (apache#4133) pick apache#52582 jira: http://39.106.86.136:8090/browse/CORE-5352
What problem does this PR solve?
Currently,

DeleteBitmap's wrong move assignment operator can cause correctness problem on mow table if SC's alter process produce delete bitmaps when calculating delete bitmaps for incremental rowsets after the modification inCloudSchemaChangeJob::_process_delete_bitmapof #52440 becauseorigin_dbmanddelete_bitmaprefer to the sameDeleteBitmapobject.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)