Skip to content

branch-3.1: [Opt](multi-catalog)Disable dict filter in parquet/orc reader if have non-single conjuncts #44777 #52559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 1, 2025
Merged

branch-3.1: [Opt](multi-catalog)Disable dict filter in parquet/orc reader if have non-single conjuncts #44777 #52559

morrySnow merged 1 commit into from
Jul 1, 2025

Conversation

@kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Jun 30, 2025 •
edited by morrySnow
Loading

Cherry-picked from #44777

@kaka11chen
[Opt](multi-catalog)Disable dict filter in parquet/orc reader if have…
c542282 
… non-single conjuncts. (apache#44777)

Related PR: apache#26386

Problem Summary:

Because of apache#26386, we split the conjunctions into
`single_slot_filter_conjuncts` and `non_single_slot_filter_conjuncts`,
where you can use the final dictionary filtering and delayed
materialization of the `single_slot_filter_conjuncts` part to perform
`non_single_slot_filter_conjuncts`. However, this results in fewer
conditions for late materialization, so the effect will be poor.
@kaka11chen kaka11chen requested a review from morrySnow as a code owner June 30, 2025 15:49
@Thearas
Copy link
Contributor

Thearas commented Jun 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaka11chen
Copy link
Contributor Author

kaka11chen commented Jun 30, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 30, 2025

BE UT Coverage Report

Increment line coverage 5.56% (3/54) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 44.98% (12351/27459)
Line Coverage 36.01% (109402/303796)
Region Coverage 35.08% (56690/161602)
Branch Coverage 32.20% (30754/95514)

@morrySnow morrySnow changed the title [Opt](multi-catalog)Disable dict filter in parquet/orc reader if have non-single conjuncts. branch-3.1: [Opt](multi-catalog)Disable dict filter in parquet/orc reader if have non-single conjuncts #44777 Jul 1, 2025
@morrySnow morrySnow merged commit 9f166d1 into apache:branch-3.1 Jul 1, 2025
21 of 24 checks passed
kaka11chen added a commit to kaka11chen/doris that referenced this pull request Jul 1, 2025
@kaka11chen
branch-3.1: [Opt](multi-catalog)Disable dict filter in parquet/orc re…
dc2e310 
…ader if have non-single conjuncts apache#44777 (apache#52559)

Cherry-picked from apache#44777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaka11chen @Thearas @hello-stephen @morrySnow