Skip to content

[cherry-pick](branch-30) fix array_map cause coredump as NULL (#51618) #51740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangstar333 merged 1 commit into from
Jun 30, 2025
Merged

[cherry-pick](branch-30) fix array_map cause coredump as NULL (#51618) #51740

zhangstar333 merged 1 commit into from
Jun 30, 2025

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Jun 16, 2025 •
edited
Loading

Problem Summary:
cherry-pick from #51618

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jun 16, 2025

run buildall

@zhangstar333
[bug](function) fix array_map cause coredump as NULL (apache#51618)
3bb875c 
if column_array is NULL, we know the array_data_column will not write
any data,
so the column is empty. eg : (x) -> concat('|',x + "1"). if still
execute the lambda function, will cause the bolck rows are not equal.
the x column is empty, but "|" is const literal, size of column is 1, so
the block rows is 1, but the x column is empty, will be coredump.
@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jun 16, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 16, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/27) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.17% (10896/26465)
Line Coverage 31.98% (93184/291337)
Region Coverage 31.07% (48075/154729)
Branch Coverage 27.54% (24626/89410)

dataroaring
dataroaring approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

PR approved by anyone and no changes requested.

@zhangstar333 zhangstar333 merged commit e3ba787 into apache:branch-3.0 Jun 30, 2025
19 of 23 checks passed
koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
@zhangstar333 @koarz
[cherry-pick](branch-30) fix array_map cause coredump as NULL (apache…
2078f32 
…#51618) (apache#51740)

Problem Summary:
cherry-pick from apache#51618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangstar333 @hello-stephen @dataroaring