[Load] support ignoring eovercrowded when tablet sink #5156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
Dec 28, 2020
Contributor
|
@vagetablechicken LGTM. please update the doc for the new config. |
Contributor
Author
Done. And I found opening tablet writer may be failed too. So I add |
Contributor
|
@vagetablechicken Hi, please fix the conficts. |
kangkaisen
approved these changes
Jan 6, 2021
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Jan 26, 2021
If adding the ignore_eovercrowded flag, the `PTabletWriterAddBatchRequest` won't failed on `EOVERCROWDED` to avoid load jobs failed in this error. It only effects the NodeChannel(the load job), other rpc requests will still check if overcrowded.
levy5307
pushed a commit
to levy5307/incubator-doris
that referenced
this pull request
Nov 14, 2022
If adding the ignore_eovercrowded flag, the `PTabletWriterAddBatchRequest` won't failed on `EOVERCROWDED` to avoid load jobs failed in this error. It only effects the NodeChannel(the load job), other rpc requests will still check if overcrowded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If adding the ignore_eovercrowded flag, the
PTabletWriterAddBatchRequestwon't failed onEOVERCROWDEDto avoid load jobs failed in this error. It only effects the NodeChannel(the load job), other rpc requests will still check if overcrowded.Types of changes
Checklist