Skip to content

[bug](function) fix array_map coredump when no rows #50913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
May 18, 2025
Merged

[bug](function) fix array_map coredump when no rows #50913

yiguolei merged 2 commits into from
May 18, 2025

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented May 14, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:
when block is empty, it's also should execute once to insert empty result column.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented May 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented May 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 14, 2025

TPC-H: Total hot run time: 33980 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1e868cbec6dedc3cdde910ca13053b38edba3abf, data reload: false

------ Round 1 ----------------------------------
q1	25741	5093	5030	5030
q2	2070	305	191	191
q3	10376	1246	714	714
q4	10237	989	541	541
q5	7508	2371	2371	2371
q6	179	161	132	132
q7	932	744	626	626
q8	9332	1286	1060	1060
q9	6815	5105	5062	5062
q10	6880	2313	1905	1905
q11	484	293	286	286
q12	360	356	223	223
q13	17786	3677	3103	3103
q14	225	228	214	214
q15	527	489	502	489
q16	442	441	373	373
q17	588	849	348	348
q18	7487	7140	7137	7137
q19	1819	943	560	560
q20	319	327	220	220
q21	4101	3329	2454	2454
q22	1012	1032	941	941
Total cold run time: 115220 ms
Total hot run time: 33980 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5247	5160	5103	5103
q2	233	325	227	227
q3	2134	2665	2284	2284
q4	1382	1772	1364	1364
q5	4428	4362	4358	4358
q6	224	168	130	130
q7	2009	1952	1760	1760
q8	2573	2560	2513	2513
q9	7086	7138	6975	6975
q10	3074	3265	2809	2809
q11	596	530	494	494
q12	701	805	648	648
q13	3673	4028	3435	3435
q14	305	333	280	280
q15	523	468	470	468
q16	450	522	446	446
q17	1172	1531	1406	1406
q18	7707	7473	7543	7473
q19	844	866	967	866
q20	1931	1977	1853	1853
q21	5239	4744	4694	4694
q22	1103	1070	1014	1014
Total cold run time: 52634 ms
Total hot run time: 50600 ms

@doris-robot
Copy link

doris-robot commented May 14, 2025

TPC-DS: Total hot run time: 193314 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1e868cbec6dedc3cdde910ca13053b38edba3abf, data reload: false

query1	1398	1091	1086	1086
query2	6086	1857	1878	1857
query3	10989	4587	4399	4399
query4	53376	25154	23507	23507
query5	5033	544	472	472
query6	354	224	196	196
query7	4933	520	293	293
query8	315	265	234	234
query9	5661	2647	2639	2639
query10	449	333	280	280
query11	14987	15161	14768	14768
query12	178	107	105	105
query13	1042	536	398	398
query14	10125	6308	7248	6308
query15	198	214	216	214
query16	7106	660	515	515
query17	1066	768	596	596
query18	1512	403	312	312
query19	209	188	165	165
query20	132	133	126	126
query21	210	131	115	115
query22	4420	4364	4294	4294
query23	33963	33612	33566	33566
query24	6026	2385	2446	2385
query25	458	471	409	409
query26	677	279	151	151
query27	1819	486	351	351
query28	2727	2179	2174	2174
query29	579	588	441	441
query30	274	223	199	199
query31	851	857	793	793
query32	79	63	68	63
query33	466	413	335	335
query34	824	888	538	538
query35	829	852	764	764
query36	970	1001	907	907
query37	119	105	88	88
query38	4229	4227	4117	4117
query39	1478	1459	1508	1459
query40	215	131	113	113
query41	67	60	64	60
query42	127	123	116	116
query43	507	526	523	523
query44	1335	844	842	842
query45	186	171	211	171
query46	869	1067	691	691
query47	1872	1866	1805	1805
query48	398	425	329	329
query49	694	528	448	448
query50	667	713	421	421
query51	4213	4285	4182	4182
query52	113	114	110	110
query53	222	269	188	188
query54	614	594	527	527
query55	87	91	83	83
query56	329	311	288	288
query57	1181	1211	1182	1182
query58	274	256	268	256
query59	2835	2944	2735	2735
query60	350	337	297	297
query61	122	123	124	123
query62	738	748	679	679
query63	228	197	194	194
query64	1484	1045	680	680
query65	4279	4206	4239	4206
query66	733	412	308	308
query67	15909	15516	15337	15337
query68	7620	885	536	536
query69	529	309	265	265
query70	1205	1134	1094	1094
query71	479	329	348	329
query72	5735	4781	4718	4718
query73	1411	621	354	354
query74	9231	9139	8891	8891
query75	3796	3268	2692	2692
query76	4190	1204	765	765
query77	627	383	365	365
query78	10092	10164	9264	9264
query79	2399	821	590	590
query80	725	513	439	439
query81	485	250	218	218
query82	452	138	93	93
query83	373	254	225	225
query84	293	102	88	88
query85	793	413	306	306
query86	390	301	284	284
query87	4414	4449	4269	4269
query88	3480	2289	2287	2287
query89	408	319	295	295
query90	1846	207	207	207
query91	142	141	109	109
query92	79	57	55	55
query93	1790	965	578	578
query94	669	409	297	297
query95	367	294	285	285
query96	504	582	282	282
query97	3188	3243	3120	3120
query98	223	211	208	208
query99	1421	1403	1293	1293
Total cold run time: 296151 ms
Total hot run time: 193314 ms

@doris-robot
Copy link

doris-robot commented May 14, 2025

ClickBench: Total hot run time: 29.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1e868cbec6dedc3cdde910ca13053b38edba3abf, data reload: false

query1	0.04	0.03	0.03
query2	0.12	0.10	0.11
query3	0.24	0.19	0.19
query4	1.59	0.19	0.20
query5	0.59	0.57	0.57
query6	1.18	0.73	0.72
query7	0.03	0.02	0.02
query8	0.04	0.04	0.03
query9	0.57	0.51	0.51
query10	0.57	0.58	0.56
query11	0.15	0.11	0.10
query12	0.14	0.12	0.12
query13	0.62	0.60	0.60
query14	0.79	0.79	0.80
query15	0.87	0.84	0.84
query16	0.41	0.38	0.39
query17	1.02	1.04	1.06
query18	0.22	0.22	0.21
query19	1.87	1.85	1.83
query20	0.02	0.01	0.01
query21	15.40	0.90	0.53
query22	0.76	1.20	0.64
query23	14.92	1.40	0.58
query24	7.02	1.71	1.07
query25	0.50	0.15	0.15
query26	0.73	0.15	0.13
query27	0.06	0.05	0.04
query28	9.82	0.83	0.46
query29	12.56	3.88	3.26
query30	0.27	0.10	0.07
query31	2.81	0.61	0.39
query32	3.22	0.55	0.47
query33	3.00	3.02	3.04
query34	15.91	5.04	4.49
query35	4.55	4.49	4.46
query36	0.66	0.51	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.15	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 103.74 s
Total hot run time: 29.4 s

@hello-stephen
Copy link
Contributor

hello-stephen commented May 14, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 55.81% (14899/26698)
Line Coverage 44.60% (131871/295691)
Region Coverage 43.65% (66288/151876)
Branch Coverage 38.26% (33968/88776)

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented May 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 14, 2025

TPC-H: Total hot run time: 33876 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 744fef353214681bbfe72a7cdd8821c5b02e7bdd, data reload: false

------ Round 1 ----------------------------------
q1	26589	5056	5065	5056
q2	2060	287	192	192
q3	10429	1257	736	736
q4	10266	995	533	533
q5	7946	2362	2348	2348
q6	208	166	135	135
q7	930	760	601	601
q8	9319	1293	1082	1082
q9	6765	5010	5055	5010
q10	6857	2317	1866	1866
q11	494	286	264	264
q12	340	348	207	207
q13	17761	3668	3121	3121
q14	241	231	216	216
q15	546	490	500	490
q16	424	435	379	379
q17	597	859	360	360
q18	7851	7232	7167	7167
q19	1556	950	552	552
q20	325	326	208	208
q21	3983	2630	2378	2378
q22	1025	1014	975	975
Total cold run time: 116512 ms
Total hot run time: 33876 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5360	5051	5046	5046
q2	244	339	224	224
q3	2143	2650	2283	2283
q4	1423	1861	1470	1470
q5	4593	4475	4302	4302
q6	213	179	127	127
q7	1986	1898	1727	1727
q8	2565	2583	2579	2579
q9	7183	7013	7176	7013
q10	3027	3204	2761	2761
q11	575	513	504	504
q12	680	784	603	603
q13	3511	3927	3309	3309
q14	292	303	267	267
q15	515	484	469	469
q16	435	488	457	457
q17	1187	1586	1354	1354
q18	7623	7489	7423	7423
q19	793	774	823	774
q20	2010	2038	1881	1881
q21	5001	4505	4596	4505
q22	1049	1028	976	976
Total cold run time: 52408 ms
Total hot run time: 50054 ms

@doris-robot
Copy link

doris-robot commented May 14, 2025

TPC-DS: Total hot run time: 186375 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 744fef353214681bbfe72a7cdd8821c5b02e7bdd, data reload: false

query1	992	501	518	501
query2	6566	1854	1815	1815
query3	6758	221	216	216
query4	25971	23493	23324	23324
query5	4394	606	472	472
query6	303	210	190	190
query7	4640	498	297	297
query8	304	262	241	241
query9	8619	2662	2683	2662
query10	508	337	273	273
query11	15459	15076	14768	14768
query12	151	109	103	103
query13	1660	524	411	411
query14	8550	6188	6227	6188
query15	202	197	173	173
query16	7125	612	473	473
query17	1149	689	548	548
query18	1957	383	297	297
query19	189	186	157	157
query20	119	113	117	113
query21	250	129	106	106
query22	4104	4091	4048	4048
query23	34136	33003	33033	33003
query24	8538	2392	2393	2392
query25	546	469	386	386
query26	1238	272	156	156
query27	2751	505	340	340
query28	4364	2141	2120	2120
query29	791	565	431	431
query30	282	217	195	195
query31	942	875	775	775
query32	79	67	72	67
query33	571	362	320	320
query34	829	844	537	537
query35	785	798	759	759
query36	955	976	924	924
query37	120	107	79	79
query38	4244	4185	4048	4048
query39	1482	1413	1407	1407
query40	216	127	114	114
query41	64	64	64	64
query42	139	112	116	112
query43	508	502	470	470
query44	1325	830	824	824
query45	182	180	168	168
query46	844	1059	653	653
query47	1721	1781	1729	1729
query48	400	425	325	325
query49	771	516	430	430
query50	649	677	410	410
query51	4170	4256	4113	4113
query52	111	103	101	101
query53	240	251	181	181
query54	601	582	525	525
query55	86	84	85	84
query56	312	324	285	285
query57	1113	1143	1099	1099
query58	271	256	256	256
query59	2530	2685	2571	2571
query60	357	346	304	304
query61	126	122	126	122
query62	799	754	647	647
query63	221	193	195	193
query64	4409	988	653	653
query65	4349	4227	4258	4227
query66	1166	417	305	305
query67	16015	15562	15327	15327
query68	7907	892	526	526
query69	476	308	283	283
query70	1203	1111	1133	1111
query71	443	312	298	298
query72	5604	4708	4829	4708
query73	620	670	352	352
query74	9212	9245	8683	8683
query75	3649	3261	2723	2723
query76	3365	1184	765	765
query77	813	368	299	299
query78	10048	10205	9385	9385
query79	2538	833	588	588
query80	621	519	447	447
query81	508	257	224	224
query82	465	129	95	95
query83	257	257	242	242
query84	262	102	88	88
query85	794	361	310	310
query86	387	318	268	268
query87	4536	4490	4371	4371
query88	3981	2307	2289	2289
query89	391	315	281	281
query90	1866	205	208	205
query91	141	145	114	114
query92	80	58	58	58
query93	1911	952	583	583
query94	695	429	311	311
query95	386	290	293	290
query96	497	564	283	283
query97	3152	3237	3109	3109
query98	241	220	209	209
query99	1383	1388	1270	1270
Total cold run time: 274750 ms
Total hot run time: 186375 ms

@doris-robot
Copy link

doris-robot commented May 14, 2025

ClickBench: Total hot run time: 28.92 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 744fef353214681bbfe72a7cdd8821c5b02e7bdd, data reload: false

query1	0.05	0.04	0.03
query2	0.13	0.10	0.11
query3	0.26	0.19	0.20
query4	1.60	0.20	0.11
query5	0.58	0.56	0.55
query6	1.20	0.71	0.74
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.58	0.52	0.51
query10	0.57	0.58	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	0.79	0.80	0.80
query15	0.88	0.85	0.87
query16	0.39	0.37	0.38
query17	1.04	1.02	1.06
query18	0.23	0.22	0.21
query19	1.91	1.86	1.78
query20	0.02	0.02	0.01
query21	15.43	0.92	0.54
query22	0.76	1.26	0.76
query23	14.75	1.38	0.61
query24	7.55	1.25	0.56
query25	0.47	0.28	0.08
query26	0.50	0.15	0.14
query27	0.06	0.04	0.05
query28	9.97	0.84	0.46
query29	12.56	3.94	3.29
query30	0.26	0.11	0.07
query31	2.81	0.61	0.40
query32	3.22	0.56	0.48
query33	3.03	3.10	3.08
query34	15.87	5.08	4.47
query35	4.51	4.49	4.47
query36	0.66	0.51	0.49
query37	0.09	0.06	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.14	0.12
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.12 s
Total hot run time: 28.92 s

@doris-robot
Copy link

doris-robot commented May 14, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 55.81% (14901/26698)
Line Coverage 44.61% (131898/295691)
Region Coverage 43.66% (66304/151878)
Branch Coverage 38.27% (33976/88778)

@hello-stephen
Copy link
Contributor

hello-stephen commented May 14, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.33% (20834/26264)
Line Coverage 72.54% (214460/295627)
Region Coverage 70.75% (126208/178383)
Branch Coverage 64.51% (65402/101388)

mrhhsg
mrhhsg approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit dc88e55 into apache:master May 18, 2025
28 of 30 checks passed
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request May 20, 2025
@zhangstar333
[bug](function) fix array_map coredump when no rows (apache#50913)
870ae98 
### What problem does this PR solve?
Problem Summary:
when block is empty, it's also should execute once to insert empty
result column.
@zhangstar333 zhangstar333 mentioned this pull request May 20, 2025
Merged
16 tasks
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request May 20, 2025
@zhangstar333
[bug](function) fix array_map coredump when no rows (apache#50913)
ce6c3ad 
### What problem does this PR solve?
Problem Summary:
when block is empty, it's also should execute once to insert empty
result column.
@zhangstar333 zhangstar333 mentioned this pull request May 20, 2025
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request May 22, 2025
@zhangstar333
[cherry-pick](branch-21) pick (#50913) (#51072)
fbad523 
### What problem does this PR solve?
Problem Summary:
pick from master (#50913)

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@zhangstar333 @koarz
[bug](function) fix array_map coredump when no rows (apache#50913)
8955e9f 
### What problem does this PR solve?
Problem Summary:
when block is empty, it's also should execute once to insert empty
result column.
dataroaring pushed a commit that referenced this pull request Jun 11, 2025
@zhangstar333
[cherry-pick](branch-30) pick (#50913) (#51073)
20279a2 
### What problem does this PR solve?
Problem Summary:
pick from master (#50913)
@yiguolei yiguolei mentioned this pull request Aug 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrhhsg mrhhsg mrhhsg approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.11-merged dev/3.0.7-merged dev/3.1.0-merged p0_c reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zhangstar333 @hello-stephen @doris-robot @mrhhsg @yiguolei @dataroaring @morrySnow