Skip to content

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Dec 14, 2020

Proposed changes

Add ninja build system support, if you installed ninja you can building be by ninja using bash build.sh --be --ninja.
ninja build is more faster than make, in my env with -j 25, make build be from clean use 2m47s , ninja use 2m17s

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@EmmyMiao87 EmmyMiao87 added the kind/chore Issues or PRs related to compile and install label Dec 14, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg merged commit 2e5126c into apache:master Dec 15, 2020
@yangzhg yangzhg deleted the support_ninja branch December 22, 2020 07:13
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jan 5, 2021
Add ninja build system support, if you installed ninja you can building be by ninja using bash build.sh --be --ninja.
ninja build is more faster than make
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
…during profile collection. apache#56806 (apache#5192)

cherry-picks from apache#56806
Related to apache#5076

Co-authored-by: daidai <changyuwei@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/chore Issues or PRs related to compile and install

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants