Skip to content

[fix](join)Consider mark join when computing right_col_idx(#50720) #50727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
May 19, 2025
Merged

[fix](join)Consider mark join when computing right_col_idx(#50720) #50727

yiguolei merged 1 commit into from
May 19, 2025

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented May 9, 2025

What problem does this PR solve?

pick #50720

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@mrhhsg mrhhsg requested a review from yiguolei as a code owner May 9, 2025 01:15
@hello-stephen
Copy link
Contributor

hello-stephen commented May 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg
Copy link
Member Author

mrhhsg commented May 9, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented May 9, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.91% (10289/26445)
Line Coverage 29.94% (85443/285368)
Region Coverage 28.62% (44083/154036)
Branch Coverage 25.35% (22557/88972)

@hello-stephen
Copy link
Contributor

hello-stephen commented May 9, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.46% (19398/26053)
Line Coverage 69.17% (196157/283573)
Region Coverage 66.76% (119735/179349)
Branch Coverage 59.83% (60205/100630)

@mrhhsg
Copy link
Member Author

mrhhsg commented May 16, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented May 16, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/125) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.94% (10299/26449)
Line Coverage 29.98% (85602/285493)
Region Coverage 28.65% (44158/154119)
Branch Coverage 25.39% (22602/89008)

@mrhhsg
Copy link
Member Author

mrhhsg commented May 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 16, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/126) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.94% (10300/26449)
Line Coverage 30.00% (85635/285493)
Region Coverage 28.65% (44162/154117)
Branch Coverage 25.41% (22615/89008)

@hello-stephen
Copy link
Contributor

hello-stephen commented May 16, 2025

BE Regression && UT Coverage Report

Increment line coverage 88.10% (111/126) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.51% (19413/26054)
Line Coverage 69.21% (196350/283689)
Region Coverage 66.74% (119757/179429)
Branch Coverage 59.83% (60227/100664)

@mrhhsg
Copy link
Member Author

mrhhsg commented May 17, 2025

run p0

@hello-stephen
Copy link
Contributor

hello-stephen commented May 19, 2025

run feut

@hello-stephen
Copy link
Contributor

hello-stephen commented May 19, 2025

run beut

@hello-stephen hello-stephen reopened this May 19, 2025
@doris-robot
Copy link

doris-robot commented May 19, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/130) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.03% (10323/26449)
Line Coverage 30.04% (85771/285500)
Region Coverage 28.70% (44237/154124)
Branch Coverage 25.44% (22642/89012)

@hello-stephen
Copy link
Contributor

hello-stephen commented May 19, 2025

BE Regression && UT Coverage Report

Increment line coverage 88.46% (115/130) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.54% (19421/26054)
Line Coverage 69.24% (196430/283688)
Region Coverage 66.78% (119815/179429)
Branch Coverage 59.82% (60222/100666)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 51b39d0 into apache:branch-2.1 May 19, 2025
29 of 31 checks passed
mrhhsg added a commit to mrhhsg/doris that referenced this pull request May 22, 2025
@mrhhsg
[fix](join)Consider mark join when computing right_col_idx(apache#50720…
7eb7960 
…) (apache#50727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrhhsg @hello-stephen @doris-robot @BiteTheDDDDt @yiguolei